Remove implicit pointer conversions

Author: jfirebaugh

examples/hello.cpp

@@ -57,7 +57,7 @@ static void RegisterHighLevel(JavaVM* vm)
                 u"Hello, " + jni::Make<std::u16string>(env, args.Get(env, 0)) + u" (Native High-Level)"));
        };
 
-    jni::RegisterNatives(env, jni::Class<Greeter>::Find(env),
+    jni::RegisterNatives(env, *jni::Class<Greeter>::Find(env),
          jni::MakeNativeMethod("greet", greet));
    }
 

include/jni/array.hpp

@@ -40,7 +40,6 @@ namespace jni
         public:
             explicit operator bool() const { return array; }
 
-            operator UntaggedType*() const { return array; }
             UntaggedType& operator*() const { return *array; }
             UntaggedType* Get() const { return array; }
 
@@ -131,7 +130,6 @@ namespace jni
         public:
             explicit operator bool() const { return array; }
 
-            operator UntaggedType*() const { return array; }
             UntaggedType& operator*() const { return *array; }
             UntaggedType* Get() const { return array; }
 

include/jni/class.hpp

@@ -43,7 +43,6 @@ namespace jni
         public:
             explicit operator bool() const { return clazz; }
 
-            operator jclass&() const { return *clazz; }
             jclass& operator*() const { return *clazz; }
             jclass* Get() const { return clazz; }
 

include/jni/field.hpp

@@ -19,7 +19,7 @@ namespace jni
             using FieldType = T;
 
             Field(JNIEnv& env, const Class<TagType>& clazz, const char* name)
-              : field(GetFieldID(env, clazz, name, TypeSignature<T>()()))
+              : field(GetFieldID(env, *clazz, name, TypeSignature<T>()()))
                {}
 
             operator jfieldID&() const { return field; }

include/jni/method.hpp

@@ -23,7 +23,7 @@ namespace jni
             using ReturnType = R;
 
             Method(JNIEnv& env, const Class<TagType>& clazz, const char* name)
-              : method(GetMethodID(env, clazz, name, TypeSignature<R (Args...)>()()))
+              : method(GetMethodID(env, *clazz, name, TypeSignature<R (Args...)>()()))
                {}
 
             operator jmethodID&() const { return method; }

include/jni/native_method.hpp

@@ -313,7 +313,7 @@ namespace jni
     void RegisterNativePeer(JNIEnv& env, const Class<TagType>& clazz, const char* fieldName, Methods&&... methods)
        {
         static Field<TagType, jni::jlong> field { env, clazz, fieldName };
-        RegisterNatives(env, clazz, methods.template operator()<Peer>(field)...);
+        RegisterNatives(env, *clazz, methods.template operator()<Peer>(field)...);
        }
 
     template < class Peer, class TagType, class >
@@ -363,7 +363,7 @@ namespace jni
         using InitializerMethodType = typename NativeMethodTraits<Initializer>::Type;
         NativePeerHelper<Peer, TagType, InitializerMethodType> helper;
 
-        RegisterNatives(env, clazz,
+        RegisterNatives(env, *clazz,
             helper.MakeInitializer(field, initializeMethodName, initialize),
             helper.MakeFinalizer(field, finalizeMethodName),
             methods.template operator()<Peer>(field)...);

include/jni/object.hpp

@@ -47,7 +47,7 @@ namespace jni
             template < class OtherTag >
             bool IsInstanceOf(JNIEnv& env, const Class<OtherTag>& clazz) const
                {
-                return jni::IsInstanceOf(env, ptr, clazz);
+                return jni::IsInstanceOf(env, ptr, *clazz);
                }
        };
 
@@ -98,8 +98,6 @@ namespace jni
 
         public:
             UntaggedType* Get() const { return reinterpret_cast<UntaggedType*>(this->ptr); }
-
-            operator UntaggedType*() const { return Get(); }
             UntaggedType& operator*() const { return *Get(); }
 
             template < class T >

include/jni/static_field.hpp

@@ -19,7 +19,7 @@ namespace jni
             using FieldType = T;
 
             StaticField(JNIEnv& env, const Class<TagType>& clazz, const char* name)
-              : field(GetStaticFieldID(env, clazz, name, TypeSignature<T>()()))
+              : field(GetStaticFieldID(env, *clazz, name, TypeSignature<T>()()))
                {}
 
             operator jfieldID&() const { return field; }

include/jni/static_method.hpp

@@ -23,7 +23,7 @@ namespace jni
             using ReturnType = R;
 
             StaticMethod(JNIEnv& env, const Class<TagType>& clazz, const char* name)
-              : method(GetStaticMethodID(env, clazz, name, TypeSignature<R (Args...)>()()))
+              : method(GetStaticMethodID(env, *clazz, name, TypeSignature<R (Args...)>()()))
                {}
 
             operator jmethodID&() const { return method; }