NewGlobalRef shouldn't throw on null output if input is null

jfirebaugh · jfirebaugh · commit a2e71d9c911f · 2016-03-03T12:24:03.000-08:00
diff --git a/include/jni/functions.hpp b/include/jni/functions.hpp
@@ -131,7 +131,7 @@ namespace jni
        {
         jobject* obj = Wrap<jobject*>(env.NewGlobalRef(Unwrap(t)));
         CheckJavaException(env);
-        if (!obj)
+        if (t && !obj)
             throw std::bad_alloc();
         return UniqueGlobalRef<T>(reinterpret_cast<T*>(obj), GlobalRefDeleter(env));
        }

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ namespace jni`
`131`	`131`	`{`
`132`	`132`	`jobject* obj = Wrap<jobject*>(env.NewGlobalRef(Unwrap(t)));`
`133`	`133`	`CheckJavaException(env);`
`134`		`- if (!obj)`
	`134`	`+ if (t && !obj)`
`135`	`135`	`throw std::bad_alloc();`
`136`	`136`	`return UniqueGlobalRef<T>(reinterpret_cast<T*>(obj), GlobalRefDeleter(env));`
`137`	`137`	`}`