Array initialElement can't be a default initialized value

jfirebaugh · jfirebaugh · commit f837f74dc562 · 2018-09-04T12:57:51.000-07:00
diff --git a/include/jni/array.hpp b/include/jni/array.hpp
@@ -144,9 +144,9 @@ namespace jni
                 SetObjectArrayElement(env, SafeDereference(env, array), index, Untag(value));
                }
 
-            static Local<Array<Object<TheTag>>> New(JNIEnv& env, jsize length, const Object<TheTag>& initialElement = Object<TheTag>())
+            static Local<Array<Object<TheTag>>> New(JNIEnv& env, jsize length, const Object<TheTag>* initialElement = nullptr)
                {
-                return Local<Array<Object<TheTag>>>(env, &NewObjectArray(env, length, Class<TheTag>::Singleton(env), initialElement.Get()));
+                return Local<Array<Object<TheTag>>>(env, &NewObjectArray(env, length, Class<TheTag>::Singleton(env), initialElement ? initialElement->Get() : nullptr));
                }
 
             template < template < RefDeletionMethod > class Deleter = DefaultRefDeleter >

Original file line number	Diff line number	Diff line change
`@@ -144,9 +144,9 @@ namespace jni`
`144`	`144`	`SetObjectArrayElement(env, SafeDereference(env, array), index, Untag(value));`
`145`	`145`	`}`
`146`	`146`
`147`		`- static Local<Array<Object<TheTag>>> New(JNIEnv& env, jsize length, const Object<TheTag>& initialElement = Object<TheTag>())`
	`147`	`+ static Local<Array<Object<TheTag>>> New(JNIEnv& env, jsize length, const Object<TheTag>* initialElement = nullptr)`
`148`	`148`	`{`
`149`		`- return Local<Array<Object<TheTag>>>(env, &NewObjectArray(env, length, Class<TheTag>::Singleton(env), initialElement.Get()));`
	`149`	`+ return Local<Array<Object<TheTag>>>(env, &NewObjectArray(env, length, Class<TheTag>::Singleton(env), initialElement ? initialElement->Get() : nullptr));`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`template < template < RefDeletionMethod > class Deleter = DefaultRefDeleter >`