Fix setPlaceholder not returning the updated placeholder string (#502)

Author: marexandre

CHANGELOG.md

@@ -1,5 +1,11 @@
 ## HEAD
 
+## 5.0.2
+
+### Bug fixes 🐛
+
+- Fix `setPlaceholder` so that when `setPlaceholder` is called afterwards it return updated placeholder string [#502](https://github.com/mapbox/mapbox-gl-geocoder/pull/502)
+
 ## 5.0.1
 
 ### Bug fixes 🐛

lib/index.js

@@ -1058,9 +1058,9 @@ MapboxGeocoder.prototype = {
    * @returns {MapboxGeocoder} this
    */
   setPlaceholder: function(placeholder){
-    this.placeholder = (placeholder) ? placeholder : this._getPlaceholderText();
-    this._inputEl.placeholder = this.placeholder;
-    this._inputEl.setAttribute('aria-label', this.placeholder);
+    this.options.placeholder = (placeholder) ? placeholder : this._getPlaceholderText();
+    this._inputEl.placeholder = this.options.placeholder;
+    this._inputEl.setAttribute('aria-label', this.options.placeholder);
     return this
   },
 

test/test.geocoder.js

@@ -959,6 +959,7 @@ test('geocoder', function(tt) {
     t.equals(geocoder._inputEl.placeholder, 'Test', 'the right placeholder is set on initialization');
     geocoder.setPlaceholder('Search');
     t.equals(geocoder._inputEl.placeholder, 'Search', 'the placeholder was changed in the  UI element');
+    t.equals(geocoder.getPlaceholder(), 'Search', 'the placeholder returned from getPlaceholder is the right value');
     t.end();
   });