Check conflation region against layer index to enable clip layer (internal-8892)

GitOrigin-RevId: ff22f1e84ceb468c817ff5c313d083aa8c22174b

Author: nicozink

3d-style/data/bucket/building_bucket.ts

@@ -39,7 +39,7 @@ import Point from '@mapbox/point-geometry';
 import {VectorTileFeature} from '@mapbox/vector-tile';
 const vectorTileFeatureTypes = VectorTileFeature.types;
 import {waitForBuildingGen, getBuildingGen} from '../../util/loaders';
-import {footprintTrianglesIntersect, regionsEquals, ReplacementOrderBuilding, type Region, type ReplacementSource} from '../../source/replacement_source';
+import {footprintTrianglesIntersect, regionsEquals, type Region, type ReplacementSource} from '../../source/replacement_source';
 import TriangleGridIndex from '../../../src/util/triangle_grid_index';
 import earcut from 'earcut';
 import assert from 'assert';
@@ -1365,7 +1365,7 @@ export class BuildingBucket implements BucketWithGroundEffect {
 
         // Hide all centroids that are overlapping with footprints from the replacement source
         for (const region of this.activeReplacements) {
-            if ((region.order <= ReplacementOrderBuilding)) continue; // fill-extrusions always get removed. This will be separated (similar to symbol and model) in future.
+            if ((region.order < layerIndex)) continue;
 
             // Apply slight padding to footprints. This reduces false positives where two adjacent lines
             // would be reported overlapping due to limited precision (16 bit) of tile units.

test/ignores/all.js

@@ -279,11 +279,6 @@ const skip = [
     "render-tests/building/terrain/terrain-unsupported",
     "render-tests/building/globe-unsupported",
 
-    // Ignore procedural buiding clip layer render tests for now.
-    "render-tests/building/clip-layer/default",
-    "render-tests/building/clip-layer/lower-order-clipping-skipped",
-    "render-tests/building/clip-layer/with-FE-and-landmarks",
-
     // Not implemented, https://mapbox.atlassian.net/browse/GLJS-1591
     "render-tests/slots/inner-slot-before-outer",
     "render-tests/slots/mixed-slot-order-with-imports",