Clean up CameraAnimationsPluginImpl.startHighLevelAnimation (#6580)

Previously we were calling `commitChanges` on animation end. That is not
necessary anymore since we commit on every animation evaluation. It was
done because previously we were coalescing the camera changes at Maps
SDK level and there were some issues with user animators (see
#597).

Also, we were cleaning the `highLevelAnimatorSet` only if there was an
animation listener provided. But it should be independent of that.

I also took the opportunity to remove some unnecessary anonymous object
creation:

| Before    | After |
| -------- | ------- |
| <img width="1413" height="1667" alt="Screenshot 2025-09-16 at 15 45
10"
src="https://github.com/user-attachments/assets/2ddce143-04d6-49ad-9ee1-7080206e168a"
/> | <img width="1413" height="1667" alt="Screenshot 2025-09-16 at 15 47
45"
src="https://github.com/user-attachments/assets/3345a114-5670-448a-9519-fd4e157d92d5"
/> |

cc @mapbox/maps-android

GitOrigin-RevId: 0daa7ff9f1920d9af5f57bf0435a7e122107e1eb

Author: jush

plugin-animation/src/main/java/com/mapbox/maps/plugin/animation/CameraAnimationsPluginImpl.kt

@@ -389,20 +389,21 @@ internal class CameraAnimationsPluginImpl : CameraAnimationsPlugin, MapCameraPlu
   }
 
   private fun registerInternalUpdateListener(animator: CameraAnimator<*>) {
-    animator.addInternalUpdateListener {
-      postOnMainThread { onAnimationUpdateInternal(animator, it) }
-    }
+    // Since we have the `animator` we can constructor the update listener once here instead of
+    // every time the animator is updated.
+    val updateInternalFun = { onAnimationUpdateInternal(animator) }
+    animator.addInternalUpdateListener { postOnMainThread(updateInternalFun) }
   }
 
-  private fun onAnimationUpdateInternal(animator: CameraAnimator<*>, valueAnimator: ValueAnimator) {
+  private fun onAnimationUpdateInternal(animator: CameraAnimator<*>) {
     // add current animator to queue-set if was not present
     runningAnimatorsQueue.add(animator)
 
     // set current animator value in any case
     updateCameraValue(animator, animator.animatedValue, cameraOptionsBuilder)
 
     if (animator.type == CameraAnimatorType.ANCHOR) {
-      anchor = valueAnimator.animatedValue as ScreenCoordinate
+      anchor = animator.animatedValue as ScreenCoordinate
     }
 
     // commit applies changes immediately
@@ -912,6 +913,19 @@ internal class CameraAnimationsPluginImpl : CameraAnimationsPlugin, MapCameraPlu
     }
   }
 
+  /**
+   * Convenient property to clean up highLevelAnimatorSet listener on animation end.
+   * This is reused to avoid recreating new listener each time.
+   */
+  private val clearHighLevelAnimatorSetListener = object : AnimatorListenerAdapter() {
+    override fun onAnimationEnd(animation: Animator) {
+      // Make sure we only clean the current highLevelAnimatorSet
+      if (highLevelAnimatorSet?.animatorSet === animation) {
+        highLevelAnimatorSet = null
+      }
+    }
+  }
+
   private fun startHighLevelAnimation(
     animators: Array<CameraAnimator<*>>,
     animationOptions: MapAnimationOptions?,
@@ -941,23 +955,14 @@ internal class CameraAnimationsPluginImpl : CameraAnimationsPlugin, MapCameraPlu
       animationOptions?.interpolator?.let {
         interpolator = it
       }
-      animatorListener?.let {
-        // listeners in Android SDK use non thread safe lists
-        postOnAnimatorThread {
-          addListener(object : AnimatorListenerAdapter() {
-            override fun onAnimationEnd(animation: Animator) {
-              postOnMainThread {
-                commitChanges()
-              }
-
-              if (highLevelAnimatorSet?.animatorSet === animation) {
-                highLevelAnimatorSet = null
-              }
-            }
-          })
+      // listeners in Android SDK use non thread safe lists
+      postOnAnimatorThread {
+        addListener(clearHighLevelAnimatorSetListener)
+        animatorListener?.let {
           addListener(it)
         }
       }
+
       playTogether(*animators)
     }
     animatorSet.calculateCameraAnimationHint(cameraAnimationHintFractions)?.let {