Skip to content

Commit 3e125f5

Browse files
pozdnyakovgithub-actions[bot]
authored andcommitted
MapboxRenderer.resetThreadServiceType() is called on the UIThread
GitOrigin-RevId: c94d05f88ecfe381c481c70505c94e50bb3314bb
1 parent 5d0d9fc commit 3e125f5

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

maps-sdk/src/main/java/com/mapbox/maps/renderer/MapboxRenderThread.kt

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -224,16 +224,6 @@ internal class MapboxRenderThread : Choreographer.FrameCallback {
224224
)
225225
}
226226

227-
/**
228-
* Resets the renderer thread service type to Interactive.
229-
* Must be called on the render thread.
230-
*/
231-
@OptIn(MapboxExperimental::class)
232-
@RenderThread
233-
private fun resetThreadServiceType() {
234-
mapboxRenderer.resetThreadServiceType()
235-
}
236-
237227
private fun setUpRenderThread(creatingSurface: Boolean): Boolean {
238228
surfaceProcessingLock.withLock {
239229
try {
@@ -727,7 +717,7 @@ internal class MapboxRenderThread : Choreographer.FrameCallback {
727717
fun resume() {
728718
paused = false
729719
logI(TAG, "Renderer resumed, renderThreadPrepared=$renderThreadPrepared, surface.isValid=${surface?.isValid}")
730-
postNonRenderEvent(RenderEvent(::resetThreadServiceType, false))
720+
mapboxRenderer.resetThreadServiceType()
731721
// schedule render if we resume not after first create (e.g. bring map back to front)
732722
renderPreparedGuardedRun(::postPrepareRenderFrame)
733723
}

maps-sdk/src/main/java/com/mapbox/maps/renderer/MapboxRenderer.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ internal abstract class MapboxRenderer(mapName: String) : DelegatingMapClient {
127127
* Must be called on the render thread.
128128
*/
129129
@MapboxExperimental
130-
@RenderThread
130+
@UiThread
131131
fun resetThreadServiceType() {
132132
map?.resetThreadServiceType()
133133
}

0 commit comments

Comments
 (0)