[maps-android] create separate scheduleThreadServiceTypeReset (#5203)

GitOrigin-RevId: a516d62fc37c72b7f40177f011c76880509106fc

Author: natiginfo

maps-sdk/src/main/java/com/mapbox/maps/renderer/MapboxRenderThread.kt

@@ -707,6 +707,24 @@ internal class MapboxRenderThread : Choreographer.FrameCallback {
     }
   }
 
+  /**
+   * Schedules a resetThreadServiceType on the render thread after a specified delay.
+   * This method is called on resume to ensure CPU affinity is properly set
+   * when coming back from background, addressing timing issues where CPU affinity
+   * might not be immediately available.
+   */
+  @OptIn(MapboxExperimental::class)
+  fun scheduleThreadServiceTypeReset() {
+    logI(TAG, "Scheduling thread service type reset with delay")
+    postNonRenderEvent(
+      RenderEvent({
+        logI(TAG, "Executing thread service type reset")
+        mapboxRenderer.resetThreadServiceType()
+      }, false),
+      RESET_THREAD_SERVICE_TYPE_DELAY_MS
+    )
+  }
+
   @UiThread
   fun pause() {
     paused = true
@@ -717,12 +735,6 @@ internal class MapboxRenderThread : Choreographer.FrameCallback {
   fun resume() {
     paused = false
     logI(TAG, "Renderer resumed, renderThreadPrepared=$renderThreadPrepared, surface.isValid=${surface?.isValid}")
-    postNonRenderEvent(
-      RenderEvent({
-        mapboxRenderer.resetThreadServiceType()
-      }, false),
-      RESET_THREAD_SERVICE_TYPE_DELAY_MS
-    )
     // schedule render if we resume not after first create (e.g. bring map back to front)
     renderPreparedGuardedRun(::postPrepareRenderFrame)
   }

maps-sdk/src/main/java/com/mapbox/maps/renderer/MapboxRenderer.kt

@@ -147,7 +147,7 @@ internal abstract class MapboxRenderer(mapName: String) : DelegatingMapClient {
 
   @UiThread
   fun onResume() {
-    renderThread.resume()
+    renderThread.scheduleThreadServiceTypeReset()
   }
 
   @RenderThread

maps-sdk/src/test/java/com/mapbox/maps/renderer/MapboxRendererTest.kt

@@ -78,7 +78,7 @@ internal abstract class MapboxRendererTest {
   @Test
   fun onResumeTest() {
     mapboxRenderer.onResume()
-    verify { renderThread.resume() }
+    verify { renderThread.scheduleThreadServiceTypeReset() }
   }
 
   @Test

plugin-animation/api/Release/metalava.txt

@@ -2,6 +2,8 @@
 package com.mapbox.maps.plugin.animation {
 
   public final class CameraAnimationsUtils {
+    method @RestrictTo(androidx.annotation.RestrictTo.Scope.LIBRARY_GROUP_PREFIX) @kotlin.jvm.JvmSynthetic public static com.mapbox.maps.CameraAnimationHint! calculateCameraAnimationHint(android.animation.AnimatorSet, java.util.List<? extends java.lang.Float> fractions, com.mapbox.maps.CameraState? startCameraState = null);
+    method @RestrictTo(androidx.annotation.RestrictTo.Scope.LIBRARY_GROUP_PREFIX) @kotlin.jvm.JvmSynthetic public static <T extends com.mapbox.maps.plugin.animation.animator.CameraAnimator<?>> com.mapbox.maps.CameraAnimationHint! calculateCameraAnimationHint(java.util.List<? extends T>, java.util.List<? extends java.lang.Float> fractions, com.mapbox.maps.CameraState? startCameraState = null);
     method public static com.mapbox.common.Cancelable easeTo(com.mapbox.maps.plugin.delegates.MapPluginExtensionsDelegate, com.mapbox.maps.CameraOptions cameraOptions, com.mapbox.maps.plugin.animation.MapAnimationOptions? animationOptions = null, android.animation.Animator.AnimatorListener? animatorListener = null);
     method public static com.mapbox.common.Cancelable easeTo(com.mapbox.maps.plugin.delegates.MapPluginExtensionsDelegate, com.mapbox.maps.CameraOptions cameraOptions, com.mapbox.maps.plugin.animation.MapAnimationOptions? animationOptions = null);
     method public static com.mapbox.common.Cancelable easeTo(com.mapbox.maps.plugin.delegates.MapPluginExtensionsDelegate, com.mapbox.maps.CameraOptions cameraOptions);

plugin-lifecycle-lint-rules/src/main/java/com/mapbox/maps/lint/lifecycle/LifecycleMethodDetector.kt

@@ -9,7 +9,7 @@ import org.jetbrains.uast.UCallExpression
  */
 class LifecycleMethodDetector : Detector(), Detector.UastScanner {
 
-  override fun getApplicableMethodNames() = listOf(ON_START, ON_STOP, ON_DESTROY, ON_LOW_MEMORY)
+  override fun getApplicableMethodNames() = listOf(ON_START, ON_STOP, ON_RESUME, ON_DESTROY, ON_LOW_MEMORY)
 
   override fun visitMethodCall(context: JavaContext, node: UCallExpression, method: PsiMethod) {
     if (context.evaluator.isMemberInClass(method, "com.mapbox.maps.MapView")) {
@@ -23,14 +23,14 @@ class LifecycleMethodDetector : Detector(), Detector.UastScanner {
   companion object Issues {
     private const val ON_START = "onStart"
     private const val ON_STOP = "onStop"
-    private const val ON_PAUSE = "onPause"
+    private const val ON_RESUME = "onResume"
     private const val ON_DESTROY = "onDestroy"
     private const val ON_LOW_MEMORY = "onLowMemory"
     private const val ISSUE_ID = "Lifecycle"
     private const val BRIEF_DESCRIPTION = "Redundant method call"
     private const val PRIORITY = 8
     private const val REPORT_MESSAGE =
-      "It's no longer required to manually invoke onStart/onStop/onPause/onDestroy/onLowMemory MapView lifecycle methods explicitly. The Mapbox Maps SDK for Android depends on the plugin-lifecycle that leverages androidx.lifecycle to make the MapView a lifecycle aware component. This behavior is automatically enforced when appcompact 1.3.0+ is used. The plugin-lifecycle can be removed from class path to opt-out of the associated behavior."
+      "It's no longer required to manually invoke onStart/onStop/onResume/onDestroy/onLowMemory MapView lifecycle methods explicitly. The Mapbox Maps SDK for Android depends on the plugin-lifecycle that leverages androidx.lifecycle to make the MapView a lifecycle aware component. This behavior is automatically enforced when appcompact 1.3.0+ is used. The plugin-lifecycle can be removed from class path to opt-out of the associated behavior."
 
     private val IMPLEMENTATION = Implementation(
       LifecycleMethodDetector::class.java, Scope.JAVA_FILE_SCOPE