Upgrade Gradle and AGP (#4703)

[MAPSAND-1709](https://mapbox.atlassian.net/browse/MAPSAND-1709)

Changes in this PR:
- The Gradle wrapper is now 8.11.1
- Instead of each project having its Gradle wrapper related files we now
use soft links to the `platform/android/gradle*`. Except `maps-android`
because it uses the public one (`maps-android/mapbox-maps-android`).
- Upgrade AGP to 8.10.1
- Each module package name is now defined in the build Gradle file
`namespace` property.
- Android target SDK is now 33 for common
- Maven publication now uses `android.publishing {..}` to produce the
javadocs and source jars. Applicable to gl-native and common
(maps-android already did it)
- Align the Gradle properties related to JVM configuration.

Ideally the `gradle.properties` of each Android project would be linked
to a common one (in `<root>/platform/android`) but we can't because each
of them needs to define a slightly different `mapbox.mapboxSdkRoot`
relative path in it 😞

cc @mapbox/gl-native
cc @mapbox/maps-android
cc @mapbox/core-sdk
cc @mapbox/sdk-ci
cc @mapbox/3d-live-navigation

[MAPSAND-1709]:
https://mapbox.atlassian.net/browse/MAPSAND-1709?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

cc @mapbox/navnative

cc @mapbox/search-sdk-native

cc @mapbox/nav-core-sdk

GitOrigin-RevId: f7c432c98282c3b7d4d05e1d81582da65eb9b541

Author: jush

android-auto-app/build.gradle.kts

@@ -14,7 +14,7 @@ android {
     versionName = "0.1.0"
     multiDexEnabled = true
     testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
-    testInstrumentationRunnerArguments(mapOf("clearPackageData" to "true"))
+    testInstrumentationRunnerArguments["clearPackageData"] = "true"
   }
 
   compileOptions {

app/build.gradle.kts

@@ -39,7 +39,7 @@ android {
     versionName = project.property("TEST_APP_VERSION_NAME") as String
     multiDexEnabled = true
     testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
-    testInstrumentationRunnerArguments += mapOf("clearPackageData" to "true")
+    testInstrumentationRunnerArguments["clearPackageData"] = "true"
     ndk {
       val abi: String =
         if (System.getenv("ANDROID_ABI") != null) System.getenv("ANDROID_ABI") else ""
@@ -80,6 +80,7 @@ android {
 
   buildFeatures {
     viewBinding = true
+    buildConfig = true
   }
 
   testOptions {

compose-app/build.gradle.kts

@@ -15,7 +15,7 @@ android {
     versionName = "0.1.0"
     multiDexEnabled = true
     testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
-    testInstrumentationRunnerArguments(mapOf("clearPackageData" to "true"))
+    testInstrumentationRunnerArguments["clearPackageData"] = "true"
     vectorDrawables {
       useSupportLibrary = true
     }

extension-style-app/build.gradle.kts

@@ -15,7 +15,7 @@ android {
     versionName = "0.1.0"
     multiDexEnabled = true
     testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
-    testInstrumentationRunnerArguments(mapOf("clearPackageData" to "true"))
+    testInstrumentationRunnerArguments["clearPackageData"] = "true"
   }
 
   compileOptions {

gradle.properties

@@ -9,9 +9,30 @@ TEST_APP_VERSION_NAME=0.1.0
 # any settings specified in this file.
 # For more details on how to configure your build environment visit
 # http://www.gradle.org/docs/current/userguide/build_environment.html
+
 # Specifies the JVM arguments used for the daemon process.
 # The setting is particularly useful for tweaking memory settings.
-org.gradle.jvmargs=-Xmx12g -XX:MaxPermSize=1024m -XX:+UseParallelGC
+# Ensure important default jvmargs aren't overwritten. See https://github.com/gradle/gradle/issues/19750
+#
+# For more information about how Gradle memory options were chosen:
+# - Metaspace See https://www.jasonpearson.dev/metaspace-in-jvm-builds/
+# - SoftRefLRUPolicyMSPerMB would default to 1000 which with a 4gb heap translates to ~51 minutes.
+#   A value of 1 means ~4 seconds before SoftRefs can be collected, which means its realistic to
+#   collect them as needed during a build that should take seconds to minutes.
+# - CodeCache normally defaults to a very small size. Increasing it from platform defaults of 32-48m
+#   because of how many classes can be loaded into memory and then cached as native compiled code
+#   for a small speed boost.
+# - Increased stack size (Xss) fixes StackOverFlow during javadoc generation
+org.gradle.jvmargs=-Dfile.encoding=UTF-8 -XX:+UseG1GC -XX:SoftRefLRUPolicyMSPerMB=1 -XX:ReservedCodeCacheSize=256m -XX:+HeapDumpOnOutOfMemoryError -Xmx16g -Xms4g -Xss4m
+
+# For more information about how Kotlin Daemon memory options were chosen:
+# - Kotlin JVM args only inherit Xmx, ReservedCodeCache, and MaxMetaspace. Since we are specifying
+#   other args we need to specify all of them here.
+# - We're using the Kotlin Gradle Plugin's default value for ReservedCodeCacheSize, if we do not then
+#   the Gradle JVM arg value for ReservedCodeCacheSize will be used.
+kotlin.daemon.jvmargs=-Dfile.encoding=UTF-8 -XX:+UseG1GC -XX:SoftRefLRUPolicyMSPerMB=1 -XX:ReservedCodeCacheSize=320m -XX:+HeapDumpOnOutOfMemoryError -Xmx16g -Xms4g
+
+
 # When configured, Gradle will run in incubating parallel mode.
 # This option should only be used with decoupled projects. More details, visit
 # http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
@@ -20,16 +41,15 @@ org.gradle.jvmargs=-Xmx12g -XX:MaxPermSize=1024m -XX:+UseParallelGC
 # Android operating system, and which are packaged with your app's APK
 # https://developer.android.com/topic/libraries/support-library/androidx-rn
 android.useAndroidX=true
-# Automatically convert third-party libraries to use AndroidX
-android.enableJetifier=false
 # Kotlin code style for this project: "official" or "obsolete":
 kotlin.code.style=official
-# Work around Jetifier can't handle multi-release jars
-# https://github.com/bcgit/bc-java/issues/762
-# https://issuetracker.google.com/issues/172784894
-# android.jetifier.blacklist=bcprov-jdk15on
-android.jetifier.ignorelist=bcprov-jdk15on
 # Internal build flag to build from source.
 buildFromSource=false
 # Disable ksp incremental feature due to ksp bug in https://github.com/google/ksp/issues/1280
-ksp.incremental=false
+ksp.incremental=false
+
+android.nonTransitiveRClass=false
+#android.nonFinalResIds=false
+
+# Enable caching between builds.
+org.gradle.caching=true

gradle/libs.versions.toml

@@ -15,12 +15,12 @@ exampleCompileSdkVersion = "34"
 
 # Plugins
 pluginJacoco = "0.8.12"
-pluginGradle = "7.4.2"
+pluginGradle = "8.10.1"
 pluginLicense = "0.9.0"
 pluginMapboxAccessToken = "0.4.0"
 pluginMapboxSdkRegistry = "1.3.3"
 pluginMapboxSdkVersions = "1.1.3"
-pluginMapboxNdk = "0.1.0"
+pluginMapboxNdk = "0.2.0"
 pluginTaskTree = "2.1.0"
 pluginPlayPublisher = "3.7.0"
 pluginGradleVersions = "0.42.0"
@@ -64,7 +64,7 @@ googleCarAppLibrary = "1.2.0"
 kotlinCoroutines = "1.6.1"
 junit = "4.13.2"
 mockk = "1.13.5"
-robolectric = "4.9.2"
+robolectric = "4.10.3"
 robolectricEgl = "gl1.1-android-2.1_r1"
 lint = "30.4.2"
 hamcrest = "2.1"

gradle/wrapper/gradle-wrapper.properties

@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-all.zip

mapbox-convention-plugin/build.gradle.kts

@@ -41,10 +41,8 @@ gradlePlugin {
 
 kotlin {
   explicitApi()
-}
-tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile>().configureEach {
-  kotlinOptions {
-    kotlinOptions.allWarningsAsErrors = true
+  compilerOptions {
+    allWarningsAsErrors = true
   }
 }
 

mapbox-convention-plugin/src/main/kotlin/com/mapbox/maps/gradle/plugins/extensions/MapboxJacocoExtension.kt

@@ -92,9 +92,9 @@ public abstract class MapboxJacocoExtension @Inject constructor(objects: ObjectF
 
   private fun Project.configureJacocoForVariant(variant: Variant) {
     val variantName = variant.name
-    val capitalizedVariant = variantName.capitalize(Locale.ROOT)
+    val capitalizedVariant = variantName.replaceFirstChar { it.uppercase(Locale.ROOT) }
     val testTaskName = "test${capitalizedVariant}UnitTest"
-    val reportTaskName = "jacoco${testTaskName.capitalize(Locale.ROOT)}Report"
+    val reportTaskName = "jacoco${testTaskName.replaceFirstChar { it.uppercase(Locale.ROOT) }}Report"
 
     tasks.register<JacocoReport>(reportTaskName) {
       dependsOn(testTaskName)
@@ -118,10 +118,10 @@ public abstract class MapboxJacocoExtension @Inject constructor(objects: ObjectF
         )
       }
 
-      val javaClasses = fileTree("$buildDir/intermediates/javac/$variantName") {
+      val javaClasses = fileTree(layout.buildDirectory.dir("intermediates/javac/$variantName")) {
         exclude(this@MapboxJacocoExtension.excludes)
       }
-      val kotlinClasses = fileTree("$buildDir/tmp/kotlin-classes/$variantName") {
+      val kotlinClasses = fileTree(layout.buildDirectory.dir("tmp/kotlin-classes/$variantName")) {
         exclude(this@MapboxJacocoExtension.excludes)
       }
 
@@ -137,7 +137,7 @@ public abstract class MapboxJacocoExtension @Inject constructor(objects: ObjectF
       )
 
       executionData.setFrom(
-        fileTree(buildDir) {
+        fileTree(layout.buildDirectory) {
           include(
             "jacoco/$testTaskName.exec",
             "outputs/unit_test_code_coverage/${variantName}UnitTest/$testTaskName.exec"

mapbox-convention-plugin/src/main/kotlin/com/mapbox/maps/gradle/plugins/extensions/MapboxLibraryExtension.kt

@@ -1,5 +1,6 @@
 package com.mapbox.maps.gradle.plugins.extensions
 
+import com.android.build.api.variant.LibraryAndroidComponentsExtension
 import com.android.build.gradle.LibraryExtension
 import com.mapbox.maps.gradle.plugins.internal.getVersionCatalog
 import com.mapbox.maps.gradle.plugins.internal.newInstance
@@ -10,6 +11,7 @@ import org.gradle.api.model.ObjectFactory
 import org.gradle.api.provider.Property
 import org.gradle.kotlin.dsl.property
 import javax.inject.Inject
+import com.android.build.api.dsl.LibraryExtension as ApiLibraryExtension
 
 public abstract class MapboxLibraryExtension @Inject constructor(objects: ObjectFactory) :
   MapboxDependenciesExtension(objects) {
@@ -53,11 +55,15 @@ public abstract class MapboxLibraryExtension @Inject constructor(objects: Object
 
   override fun applyTo(project: Project) {
     project.applyRequiredPlugins()
-    val libraryExtension = project.extensions.getByType(LibraryExtension::class.java)
     super.applyTo(project)
-    libraryExtension.configurePublicResource(project)
-    libraryExtension.setMinCompileSdkVersion(project)
-    dokka.applyTo(project, libraryExtension)
+
+    val androidComponentsExtension = project.extensions.getByType(LibraryAndroidComponentsExtension::class.java)
+    androidComponentsExtension.finalizeDsl { libraryExtension: ApiLibraryExtension ->
+      libraryExtension.enableBuildConfig()
+      libraryExtension.configurePublicResource(project)
+      libraryExtension.setMinCompileSdkVersion(project)
+    }
+    dokka.applyTo(project, project.extensions.getByType(LibraryExtension::class.java))
     // we allow to disable jApiCmp so first we have to evaluate
     project.afterEvaluate {
       if (jApiCmpEnabledProperty.getOrElse(true)) {
@@ -81,14 +87,14 @@ public abstract class MapboxLibraryExtension @Inject constructor(objects: Object
   }
 }
 
-private fun LibraryExtension.configurePublicResource(project: Project) {
+private fun ApiLibraryExtension.configurePublicResource(project: Project) {
   sourceSets.all {
     // limit amount of exposed library resources
     res.srcDir("${project.projectDir}/src/$name/res-public")
   }
 }
 
-private fun LibraryExtension.setMinCompileSdkVersion(project: Project) {
+private fun ApiLibraryExtension.setMinCompileSdkVersion(project: Project) {
   val androidMinCompileSdkVersion =
     project.getVersionCatalog().findVersion("androidMinCompileSdkVersion")
   if (androidMinCompileSdkVersion.isPresent) {
@@ -98,4 +104,8 @@ private fun LibraryExtension.setMinCompileSdkVersion(project: Project) {
   } else {
     project.logger.warn("androidMinCompileSdkVersion not found in versions catalog, skip setting minCompileSdkVersion..")
   }
+}
+
+private fun ApiLibraryExtension.enableBuildConfig() {
+  buildFeatures.buildConfig = true
 }