Fix a crash in MapView.snapshot (#2344)

Author: kiryldz

CHANGELOG.md

@@ -2,10 +2,11 @@
 
 Mapbox welcomes participation and contributions from everyone.
 
-# 10.16.7
+# 10.17.0
 ## Bug fixes 🐞
 * Fix map being pixelated on some devices when `ContextMode.SHARED` is used (e.g. in AndroidAuto extension).
 * Fix incorrect widget position and scale when resizing the drawing surface.
+* Fix a crash in `MapView.snapshot` happening on specific devices.
 
 # 10.16.6 March 04, 2024
 ## Bug fixes 🐞

sdk/src/main/java/com/mapbox/maps/renderer/MapboxRenderer.kt

@@ -204,9 +204,10 @@ internal abstract class MapboxRenderer : MapClient {
       pixelReader?.release()
       pixelReader = PixelReader(width, height)
     }
+    val pixelReader = pixelReader!!
 
-    pixelReader?.let {
-      val buffer = it.readPixels()
+    try {
+      val buffer = pixelReader.readPixels()
       buffer.rewind()
       val flipped = Bitmap.createBitmap(
         width,
@@ -228,6 +229,18 @@ internal abstract class MapboxRenderer : MapClient {
       } finally {
         flipped.recycle()
       }
+    } catch (e: Throwable) {
+      logW(TAG, "Exception ${e.localizedMessage} happened when reading pixels")
+      if (pixelReader.supportsPbo) {
+        logW(TAG, "Re-creating PixelReader with no PBO support and making snapshot again")
+        pixelReader.release()
+        this.pixelReader = PixelReader(
+          width = pixelReader.width,
+          height = pixelReader.height,
+          supportsPbo = false
+        )
+        return performSnapshot()
+      }
     }
     return null
   }

sdk/src/main/java/com/mapbox/maps/renderer/gl/PixelReader.kt

@@ -20,7 +20,9 @@ import java.nio.IntBuffer
  */
 internal class PixelReader(
   val width: Int,
-  val height: Int
+  val height: Int,
+  @ChecksSdkIntAtLeast(api = Build.VERSION_CODES.N)
+  internal val supportsPbo: Boolean = Build.VERSION.SDK_INT >= Build.VERSION_CODES.N
 ) {
   private val bufferSize = width * height * channelNum
   private var buffer = ByteBuffer
@@ -86,7 +88,5 @@ internal class PixelReader(
   companion object {
     // currently support just RGBA
     private const val channelNum = 4
-    @ChecksSdkIntAtLeast(api = Build.VERSION_CODES.N)
-    private val supportsPbo = Build.VERSION.SDK_INT >= Build.VERSION_CODES.N
   }
 }