Skip to content

Commit 776f831

Browse files
natiginfogithub-actions[bot]
authored andcommitted
[maps-android] remove detekt plugin (#4688)
Removing it since we don't utilize results of it. Creating separate internal ticket to bring detekt plugin back with custom rules in future. GitOrigin-RevId: 3d6125d8762626c3df5d052b69fc54bde2c55910
1 parent 5dd0074 commit 776f831

File tree

29 files changed

+17
-213
lines changed

29 files changed

+17
-213
lines changed

android-auto-app/build.gradle.kts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,10 @@ dependencies {
5858
androidTestImplementation(libs.androidx.testJUnit)
5959
androidTestImplementation(libs.androidx.uiAutomator)
6060
testImplementation(libs.junit)
61-
detektPlugins(libs.detektFormatting)
6261
}
6362

6463
project.apply {
6564
from("$rootDir/gradle/ktlint.gradle")
6665
from("$rootDir/gradle/lint.gradle")
67-
from("$rootDir/gradle/detekt.gradle")
6866
from("$rootDir/gradle/dependency-updates.gradle")
6967
}

app/build.gradle.kts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,12 +131,10 @@ dependencies {
131131
androidTestImplementation(libs.androidx.testJUnit)
132132
androidTestImplementation(libs.androidx.uiAutomator)
133133
testImplementation(libs.junit)
134-
detektPlugins(libs.detektFormatting)
135134
}
136135

137136
project.apply {
138137
from("$rootDir/gradle/ktlint.gradle")
139138
from("$rootDir/gradle/lint.gradle")
140-
from("$rootDir/gradle/detekt.gradle")
141139
from("$rootDir/gradle/dependency-updates.gradle")
142-
}
140+
}

build.gradle.kts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ subprojects {
7979
plugins {
8080
id("com.mapbox.gradle.root")
8181
// the IDE mistakenly highlights `libs` as an error, see https://github.com/gradle/gradle/issues/22797
82-
alias(libs.plugins.detekt) apply false
8382
alias(libs.plugins.binaryCompatibilityValidatorId)
8483
// Used to print dependency tree of the task, useful to debug gradle tasks
8584
// Ticket to track adding this feature to gradle officially: https://github.com/gradle/gradle/issues/980
@@ -146,4 +145,3 @@ public val isBuildingReleaseTag = "^v[0-9]+\\.[0-9]+\\.[0-9]+.*\$".toRegex().mat
146145
* @return True if this build is part of Circleci job triggered from a PR that targets a release branch
147146
*/
148147
public val isTargettingReleaseBranch = "^v[0-9]+\\.[0-9]+\$".toRegex().matches(System.getenv("PR_TARGET_BRANCH") ?: "")
149-

compose-app/build.gradle.kts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,11 @@ dependencies {
8484
androidTestImplementation(libs.androidx.testJUnit)
8585
androidTestImplementation(libs.androidx.uiAutomator)
8686
testImplementation(libs.junit)
87-
detektPlugins(libs.detektFormatting)
8887
debugImplementation(appsLibs.squareLeakCanary)
8988
}
9089

9190
project.apply {
9291
from("$rootDir/gradle/ktlint.gradle")
9392
from("$rootDir/gradle/lint.gradle")
94-
from("$rootDir/gradle/detekt.gradle")
9593
from("$rootDir/gradle/dependency-updates.gradle")
9694
}

detekt.yml

Lines changed: 0 additions & 116 deletions
This file was deleted.

extension-androidauto/build.gradle.kts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,11 @@ dependencies {
4343

4444
testImplementation(libs.bundles.base.dependenciesTests)
4545
androidTestImplementation(libs.bundles.base.dependenciesAndroidTests)
46-
detektPlugins(libs.detektFormatting)
4746
}
4847

4948
project.apply {
5049
from("$rootDir/gradle/ktlint.gradle")
5150
from("$rootDir/gradle/lint.gradle")
5251
from("$rootDir/gradle/track-public-apis.gradle")
53-
from("$rootDir/gradle/detekt.gradle")
5452
from("$rootDir/gradle/dependency-updates.gradle")
5553
}

extension-compose/build.gradle.kts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,15 +85,12 @@ dependencies {
8585
testImplementation(libs.bundles.base.dependenciesTests)
8686
testImplementation(project(":maps-sdk"))
8787
testImplementation(libs.junit)
88-
89-
detektPlugins(libs.detektFormatting)
9088
}
9189
}
9290

9391
project.apply {
9492
from("$rootDir/gradle/ktlint.gradle")
9593
from("$rootDir/gradle/lint.gradle")
9694
from("$rootDir/gradle/track-public-apis.gradle")
97-
from("$rootDir/gradle/detekt.gradle")
9895
from("$rootDir/gradle/dependency-updates.gradle")
9996
}

extension-localization/build.gradle.kts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,11 @@ dependencies {
2929

3030
testImplementation(libs.bundles.base.dependenciesTests)
3131
androidTestImplementation(libs.bundles.base.dependenciesAndroidTests)
32-
detektPlugins(libs.detektFormatting)
3332
}
3433

3534
project.apply {
3635
from("$rootDir/gradle/ktlint.gradle")
3736
from("$rootDir/gradle/lint.gradle")
3837
from("$rootDir/gradle/track-public-apis.gradle")
39-
from("$rootDir/gradle/detekt.gradle")
4038
from("$rootDir/gradle/dependency-updates.gradle")
41-
}
39+
}

extension-style-app/build.gradle.kts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,11 @@ dependencies {
4242
androidTestImplementation(libs.androidx.testJUnit)
4343
androidTestImplementation(libs.androidx.uiAutomator)
4444
testImplementation(libs.junit)
45-
detektPlugins(libs.detektFormatting)
4645
}
4746

4847
project.apply {
4948
from("$rootDir/gradle/ktlint.gradle")
5049
from("$rootDir/gradle/lint.gradle")
51-
from("$rootDir/gradle/detekt.gradle")
5250
from("$rootDir/gradle/dependency-updates.gradle")
5351
}
5452

extension-style/build.gradle.kts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,12 @@ dependencies {
2929

3030
testImplementation(libs.bundles.base.dependenciesTests)
3131
androidTestImplementation(libs.bundles.base.dependenciesAndroidTests)
32-
detektPlugins(libs.detektFormatting)
3332
lintPublish(project(":extension-style-lint-rules"))
3433
}
3534

3635
project.apply {
3736
from("$rootDir/gradle/ktlint.gradle")
3837
from("$rootDir/gradle/lint.gradle")
3938
from("$rootDir/gradle/track-public-apis.gradle")
40-
from("$rootDir/gradle/detekt.gradle")
4139
from("$rootDir/gradle/dependency-updates.gradle")
42-
}
40+
}

0 commit comments

Comments
 (0)