Fix duration=0 bug for custome puck animators (#2801)

kiryldz · web-flow · commit bf4f43c8ccad · 2024-10-15T11:46:35.000+03:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,9 @@
 Mapbox welcomes participation and contributions from everyone.
 
 # main
+# 11.8.0-rc.1
+## Bug fixes 🐞
+* Fix an Android 12 specific bug where location puck custom animator options lambda without explicit `ValueAnimator.duration` resulted in `duration = 0`.
 
 # 11.8.0-beta.1 October 14, 2024
 ## Features ✨ and improvements 🏁
diff --git a/plugin-locationcomponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/animators/PuckAnimator.kt b/plugin-locationcomponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/animators/PuckAnimator.kt
@@ -42,6 +42,9 @@ internal abstract class PuckAnimator<T>(
     duration = LocationComponentConstants.DEFAULT_INTERVAL_MILLIS
     interpolator = DEFAULT_INTERPOLATOR
     userConfiguredAnimator = clone()
+    // workaround for bug in Android 12 described in
+    // https://github.com/mapbox/mapbox-maps-android/issues/1446
+    userConfiguredAnimator.duration = duration
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,9 @@ internal abstract class PuckAnimator<T>(`
`42`	`42`	`duration = LocationComponentConstants.DEFAULT_INTERVAL_MILLIS`
`43`	`43`	`interpolator = DEFAULT_INTERPOLATOR`
`44`	`44`	`userConfiguredAnimator = clone()`
	`45`	`+ // workaround for bug in Android 12 described in`
	`46`	`+ // https://github.com/mapbox/mapbox-maps-android/issues/1446`
	`47`	`+ userConfiguredAnimator.duration = duration`
`45`	`48`	`}`
`46`	`49`
`47`	`50`	`/**`