Skip to content

Commit cc2e97a

Browse files
authored
[v10] fix click listener issues introduced by async click handling (#3095)
1 parent 0599574 commit cc2e97a

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@
33
Mapbox welcomes participation and contributions from everyone.
44

55

6+
# 10.19.1
7+
8+
## Bug fixes 🐞
9+
* Fixed map clicks being blocked by annotation managers with no click listeners
10+
611
# 10.19.0 December 13, 2024
712
## Features ✨ and improvements 🏁
813
* Publish Mapbox Maps Android artifacts using NDK 27 and [support for 16 KB page sizes](https://developer.android.com/guide/practices/page-sizes).

plugin-annotation/src/main/java/com/mapbox/maps/plugin/annotation/AnnotationManagerImpl.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -623,6 +623,9 @@ abstract class AnnotationManagerImpl<G : Geometry, T : Annotation<G>, S : Annota
623623
*/
624624
override fun asyncHandleClick(point: Point, continueToNextListener: () -> Unit) {
625625
if (couldSkipClick()) {
626+
// If click won't be handled, we should continue to next listener
627+
// Otherwise, listeners such as OnMapClickListener won't be invoked with annotation managers.
628+
continueToNextListener()
626629
return
627630
}
628631
try {

0 commit comments

Comments
 (0)