Fix Ktlint format crashing on JVM 17+ (#6512)

jush · github-actions[bot] · commit e3f4c861c838 · 2025-09-12T13:46:58.000Z
Due to the [Java Platform Module System](http://openjdk.java.net/projects/jigsaw/spec/sotms) that was introduced in Java 9 `./gradlew ktlintFormat` was failing with error: ``` Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field private transient java.lang.Object java.lang.Throwable.backtrace accessible: module java.base does not "opens java.lang" to unnamed module @3ab35c25 ``` This PR: - fixes it by adding the `add-opens` to `ktlinFormat` task. - Rewrote `ktlin.grale` to Kotlin. - From now on `build.gradle.kts` are also formatted cc @mapbox/maps-android GitOrigin-RevId: c784b4f85f976f9eba3629ccd223e333445b7ea0
diff --git a/android-auto-app/build.gradle.kts b/android-auto-app/build.gradle.kts
@@ -2,7 +2,6 @@ plugins {
   id("com.mapbox.gradle.application")
 }
 
-
 android {
   compileSdk = libs.versions.autoCompileSdkVersion.get().toInt()
   namespace = "com.mapbox.maps.testapp.auto"
@@ -61,7 +60,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
 }
diff --git a/app/build.gradle.kts b/app/build.gradle.kts
@@ -135,7 +135,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
 }
diff --git a/compose-app/build.gradle.kts b/compose-app/build.gradle.kts
@@ -3,7 +3,6 @@ plugins {
   id("org.jetbrains.kotlin.plugin.parcelize")
 }
 
-
 android {
   compileSdk = libs.versions.androidCompileSdkVersion.get().toInt()
   namespace = "com.mapbox.maps.compose.testapp"
@@ -88,7 +87,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
 }
diff --git a/extension-androidauto/build.gradle.kts b/extension-androidauto/build.gradle.kts
@@ -46,7 +46,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/extension-compose/build.gradle.kts b/extension-compose/build.gradle.kts
@@ -60,7 +60,6 @@ mapboxLibrary {
   }
 }
 
-
 dependencies {
   dependencies {
     compileOnly(project(":maps-sdk"))
@@ -89,7 +88,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/extension-localization/build.gradle.kts b/extension-localization/build.gradle.kts
@@ -32,7 +32,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/extension-style-app/build.gradle.kts b/extension-style-app/build.gradle.kts
@@ -3,7 +3,6 @@ plugins {
   id("com.mapbox.maps.token")
 }
 
-
 android {
   compileSdk = libs.versions.androidCompileSdkVersion.get().toInt()
   namespace = "com.mapbox.maps.extension.testapp"
@@ -28,7 +27,6 @@ android {
       execution = "ANDROIDX_TEST_ORCHESTRATOR"
     }
   }
-
 }
 
 dependencies {
@@ -45,10 +43,10 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
 }
 
-val localPath:String = org.apache.commons.io.FilenameUtils.getFullPathNoEndSeparator(project.buildscript.sourceFile.toString())
-the<com.mapbox.AccessTokenExtension>().file = "${localPath}/src/main/res/values/developer-config.xml"
+val localPath: String = org.apache.commons.io.FilenameUtils.getFullPathNoEndSeparator(project.buildscript.sourceFile.toString())
+the<com.mapbox.AccessTokenExtension>().file = "$localPath/src/main/res/values/developer-config.xml"
diff --git a/extension-style-lint-rules/build.gradle.kts b/extension-style-lint-rules/build.gradle.kts
@@ -21,17 +21,17 @@ dependencies {
   compileOnly(libs.lintApi)
   compileOnly(libs.lintChecks)
   compileOnly(libs.kotlin)
-  
+
   testImplementation(libs.junit)
   testImplementation(libs.lint)
   testImplementation(libs.lintTests)
   testImplementation(libs.testUtils)
 }
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/dependency-updates.gradle")
 }
 
 tasks.withType<Test> {
   maxParallelForks = (Runtime.getRuntime().availableProcessors()).takeIf { it > 0 } ?: 1
-}
+}
diff --git a/extension-style/build.gradle.kts b/extension-style/build.gradle.kts
@@ -33,7 +33,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/gradle/ktlint.gradle b/gradle/ktlint.gradle
diff --git a/gradle/ktlint.gradle.kts b/gradle/ktlint.gradle.kts
@@ -0,0 +1,35 @@
+val ktlintConfig by configurations.creating
+
+dependencies {
+  ktlintConfig("com.pinterest:ktlint:0.48.2")
+}
+
+val ktlint by tasks.registering(JavaExec::class) {
+  group = LifecycleBasePlugin.VERIFICATION_GROUP
+  description = "Check Kotlin code style"
+  classpath = ktlintConfig
+  mainClass.set("com.pinterest.ktlint.Main")
+  // see https://pinterest.github.io/ktlint/latest/install/cli/#command-line-usage for more information
+  args(
+    "**/src/**/*.kt",
+    "**.kts",
+    "!**/build/**",
+    "!**/ksp/**/*.kt",
+  )
+}
+
+tasks.register<JavaExec>("ktlintFormat") {
+  group = LifecycleBasePlugin.VERIFICATION_GROUP
+  description = "Check Kotlin code style and format"
+  classpath = ktlintConfig
+  mainClass.set("com.pinterest.ktlint.Main")
+  jvmArgs("--add-opens=java.base/java.lang=ALL-UNNAMED")
+  // see https://pinterest.github.io/ktlint/latest/install/cli/#command-line-usage for more information
+  args(
+    "-F",
+    "**/src/**/*.kt",
+    "**.kts",
+    "!**/build/**",
+    "!**/ksp/**/*.kt",
+  )
+}
diff --git a/maps-sdk/build.gradle.kts b/maps-sdk/build.gradle.kts
@@ -125,7 +125,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/module-telemetry/build.gradle.kts b/module-telemetry/build.gradle.kts
@@ -44,7 +44,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/plugin-animation/build.gradle.kts b/plugin-animation/build.gradle.kts
@@ -42,7 +42,7 @@ dependencies {
 tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> { kotlinOptions.jvmTarget = "1.8" }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/plugin-annotation/build.gradle.kts b/plugin-annotation/build.gradle.kts
@@ -40,7 +40,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/plugin-attribution/build.gradle.kts b/plugin-attribution/build.gradle.kts
@@ -38,7 +38,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/plugin-compass/build.gradle.kts b/plugin-compass/build.gradle.kts
@@ -35,7 +35,7 @@ dependencies {
 tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> { kotlinOptions.jvmTarget = "1.8" }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/plugin-gestures/build.gradle.kts b/plugin-gestures/build.gradle.kts
@@ -42,7 +42,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/plugin-lifecycle-lint-rules/build.gradle.kts b/plugin-lifecycle-lint-rules/build.gradle.kts
@@ -27,6 +27,6 @@ dependencies {
   testImplementation(libs.testUtils)
 }
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/dependency-updates.gradle")
 }
diff --git a/plugin-lifecycle/build.gradle.kts b/plugin-lifecycle/build.gradle.kts
@@ -42,7 +42,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/plugin-locationcomponent/build.gradle.kts b/plugin-locationcomponent/build.gradle.kts
@@ -39,7 +39,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/plugin-logo/build.gradle.kts b/plugin-logo/build.gradle.kts
@@ -31,7 +31,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/plugin-overlay/build.gradle.kts b/plugin-overlay/build.gradle.kts
@@ -31,7 +31,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/plugin-scalebar/build.gradle.kts b/plugin-scalebar/build.gradle.kts
@@ -34,7 +34,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/plugin-viewport/build.gradle.kts b/plugin-viewport/build.gradle.kts
@@ -35,7 +35,7 @@ dependencies {
 tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> { kotlinOptions.jvmTarget = "1.8" }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")
diff --git a/sdk-base/build.gradle.kts b/sdk-base/build.gradle.kts
@@ -4,7 +4,7 @@ import java.util.Locale
 plugins {
   id("com.mapbox.gradle.library")
   id("com.jaredsburrows.license")
-  //id("com.mapbox.maps.token") #mapbox-android-gradle-plugins/issues/29
+  // id("com.mapbox.maps.token") #mapbox-android-gradle-plugins/issues/29
   id("kotlin-parcelize")
   id("com.google.devtools.ksp").version("${libs.versions.kotlin.get()}-${libs.versions.ksp.get()}")
 }
@@ -35,7 +35,7 @@ android {
     tasks.withType(KspTaskJvm::class.java).all {
       // Make KSP tasks optional - only run when explicitly requested
       enabled = shouldGenerateKsp
-      
+
       val generatedKspFilesFolder = destination
       var lastFolder = generatedKspFilesFolder.toPath().fileName.toString()
       // We handle "debug" and "release" build types as equal so remove them
@@ -74,18 +74,18 @@ android {
       }
 
       // Always create the classes directory for metalava, regardless of KSP generation
-      val createClassesDirTask = tasks.register("createKspClassesDir${variantName}") {
+      val createClassesDirTask = tasks.register("createKspClassesDir$variantName") {
         doLast {
           generatedKspFilesFolder.resolve("classes").mkdirs()
         }
       }
 
       if (shouldGenerateKsp) {
         // If KSP generation is enabled, add the copy task as a dependency to the compile task
-        tasks.findByName("compile${variantName}")?.dependsOn(copyTask)
+        tasks.findByName("compile$variantName")?.dependsOn(copyTask)
       } else {
         // If KSP generation is disabled, still create the classes directory for metalava
-        tasks.findByName("compile${variantName}")?.dependsOn(createClassesDirTask)
+        tasks.findByName("compile$variantName")?.dependsOn(createClassesDirTask)
       }
     }
   }
@@ -121,7 +121,7 @@ dependencies {
 }
 
 project.apply {
-  from("$rootDir/gradle/ktlint.gradle")
+  from("$rootDir/gradle/ktlint.gradle.kts")
   from("$rootDir/gradle/lint.gradle")
   from("$rootDir/gradle/track-public-apis.gradle")
   from("$rootDir/gradle/dependency-updates.gradle")

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,6 @@ plugins {`
`2`	`2`	`id("com.mapbox.gradle.application")`
`3`	`3`	`}`
`4`	`4`
`5`		`-`
`6`	`5`	`android {`
`7`	`6`	`compileSdk = libs.versions.autoCompileSdkVersion.get().toInt()`
`8`	`7`	`namespace = "com.mapbox.maps.testapp.auto"`
`@@ -61,7 +60,7 @@ dependencies {`
`61`	`60`	`}`
`62`	`61`
`63`	`62`	`project.apply {`
`64`		`- from("$rootDir/gradle/ktlint.gradle")`
	`63`	`+ from("$rootDir/gradle/ktlint.gradle.kts")`
`65`	`64`	`from("$rootDir/gradle/lint.gradle")`
`66`	`65`	`from("$rootDir/gradle/dependency-updates.gradle")`
`67`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ dependencies {`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`project.apply {`
`138`		`- from("$rootDir/gradle/ktlint.gradle")`
	`138`	`+ from("$rootDir/gradle/ktlint.gradle.kts")`
`139`	`139`	`from("$rootDir/gradle/lint.gradle")`
`140`	`140`	`from("$rootDir/gradle/dependency-updates.gradle")`
`141`	`141`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@ plugins {`
`3`	`3`	`id("org.jetbrains.kotlin.plugin.parcelize")`
`4`	`4`	`}`
`5`	`5`
`6`		`-`
`7`	`6`	`android {`
`8`	`7`	`compileSdk = libs.versions.androidCompileSdkVersion.get().toInt()`
`9`	`8`	`namespace = "com.mapbox.maps.compose.testapp"`
`@@ -88,7 +87,7 @@ dependencies {`
`88`	`87`	`}`
`89`	`88`
`90`	`89`	`project.apply {`
`91`		`- from("$rootDir/gradle/ktlint.gradle")`
	`90`	`+ from("$rootDir/gradle/ktlint.gradle.kts")`
`92`	`91`	`from("$rootDir/gradle/lint.gradle")`
`93`	`92`	`from("$rootDir/gradle/dependency-updates.gradle")`
`94`	`93`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ dependencies {`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`project.apply {`
`49`		`- from("$rootDir/gradle/ktlint.gradle")`
	`49`	`+ from("$rootDir/gradle/ktlint.gradle.kts")`
`50`	`50`	`from("$rootDir/gradle/lint.gradle")`
`51`	`51`	`from("$rootDir/gradle/track-public-apis.gradle")`
`52`	`52`	`from("$rootDir/gradle/dependency-updates.gradle")`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,6 @@ mapboxLibrary {`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`
`63`		`-`
`64`	`63`	`dependencies {`
`65`	`64`	`dependencies {`
`66`	`65`	`compileOnly(project(":maps-sdk"))`
`@@ -89,7 +88,7 @@ dependencies {`
`89`	`88`	`}`
`90`	`89`
`91`	`90`	`project.apply {`
`92`		`- from("$rootDir/gradle/ktlint.gradle")`
	`91`	`+ from("$rootDir/gradle/ktlint.gradle.kts")`
`93`	`92`	`from("$rootDir/gradle/lint.gradle")`
`94`	`93`	`from("$rootDir/gradle/track-public-apis.gradle")`
`95`	`94`	`from("$rootDir/gradle/dependency-updates.gradle")`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ dependencies {`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`project.apply {`
`35`		`- from("$rootDir/gradle/ktlint.gradle")`
	`35`	`+ from("$rootDir/gradle/ktlint.gradle.kts")`
`36`	`36`	`from("$rootDir/gradle/lint.gradle")`
`37`	`37`	`from("$rootDir/gradle/track-public-apis.gradle")`
`38`	`38`	`from("$rootDir/gradle/dependency-updates.gradle")`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@ plugins {`
`3`	`3`	`id("com.mapbox.maps.token")`
`4`	`4`	`}`
`5`	`5`
`6`		`-`
`7`	`6`	`android {`
`8`	`7`	`compileSdk = libs.versions.androidCompileSdkVersion.get().toInt()`
`9`	`8`	`namespace = "com.mapbox.maps.extension.testapp"`
`@@ -28,7 +27,6 @@ android {`
`28`	`27`	`execution = "ANDROIDX_TEST_ORCHESTRATOR"`
`29`	`28`	`}`
`30`	`29`	`}`
`31`		`-`
`32`	`30`	`}`
`33`	`31`
`34`	`32`	`dependencies {`
`@@ -45,10 +43,10 @@ dependencies {`
`45`	`43`	`}`
`46`	`44`
`47`	`45`	`project.apply {`
`48`		`- from("$rootDir/gradle/ktlint.gradle")`
	`46`	`+ from("$rootDir/gradle/ktlint.gradle.kts")`
`49`	`47`	`from("$rootDir/gradle/lint.gradle")`
`50`	`48`	`from("$rootDir/gradle/dependency-updates.gradle")`
`51`	`49`	`}`
`52`	`50`
`53`		`-val localPath:String = org.apache.commons.io.FilenameUtils.getFullPathNoEndSeparator(project.buildscript.sourceFile.toString())`
`54`		`-the<com.mapbox.AccessTokenExtension>().file = "${localPath}/src/main/res/values/developer-config.xml"`
	`51`	`+val localPath: String = org.apache.commons.io.FilenameUtils.getFullPathNoEndSeparator(project.buildscript.sourceFile.toString())`
	`52`	`+the<com.mapbox.AccessTokenExtension>().file = "$localPath/src/main/res/values/developer-config.xml"`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ dependencies {`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`project.apply {`
`36`		`- from("$rootDir/gradle/ktlint.gradle")`
	`36`	`+ from("$rootDir/gradle/ktlint.gradle.kts")`
`37`	`37`	`from("$rootDir/gradle/lint.gradle")`
`38`	`38`	`from("$rootDir/gradle/track-public-apis.gradle")`
`39`	`39`	`from("$rootDir/gradle/dependency-updates.gradle")`