Skip to content

Commit e8f95c6

Browse files
pjleonard37actions-userzmiao
authored andcommitted
[Backport release/v0.17] MAPSSDK-932 fix generation of GeoJSONSource.minzoom property (#8382) (#8520)
We previously added the `GeoJSONSource.minZoom` property for iOS and Android. This PR updates that generation to align with `maxzoom` and other GeoJSONOptions properties. Specifically: - Getting `minzoom` is currently disabled at the native level. This PR updates geojson_options to enable getting `minzoom`. - Like other GeoJSONOptions properties, `minzoom` can only be set when the source is created. This PR updates the generator to reflect this and removes separate set methods. (cherry picked from commit 35b4df8c0b881d90bd3e65b656b2b13dee3f09cb) cc @mapbox/maps-ios cc @mapbox/gl-native cc @mapbox/maps-android cc @mapbox/sdk-ci --------- Co-authored-by: Changelog autocreator bot <[email protected]> Co-authored-by: zmiao <[email protected]> GitOrigin-RevId: 708f3fda96a882c4ccd9e64140e5c5f64230ce5b
1 parent db519f7 commit e8f95c6

File tree

5 files changed

+0
-32
lines changed

5 files changed

+0
-32
lines changed

extension-style-app/src/androidTest/java/com/mapbox/maps/testapp/style/sources/generated/GeoJsonSourceTest.kt

Lines changed: 0 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extension-style/api/Release/metalava.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7654,7 +7654,6 @@ package com.mapbox.maps.extension.style.sources.generated {
76547654
method public com.mapbox.maps.extension.style.types.PromoteId? getPromoteId();
76557655
method public com.mapbox.maps.TileCacheBudget? getTileCacheBudget();
76567656
method public Double? getTolerance();
7657-
method public com.mapbox.maps.extension.style.sources.generated.GeoJsonSource minzoom(long value = 0L);
76587657
method public com.mapbox.maps.extension.style.sources.generated.GeoJsonSource prefetchZoomDelta(long value = 4L);
76597658
method public com.mapbox.maps.extension.style.sources.generated.GeoJsonSource tileCacheBudget(com.mapbox.maps.TileCacheBudget value);
76607659
method @Deprecated public com.mapbox.maps.extension.style.sources.generated.GeoJsonSource url(String value, String dataId = "");

extension-style/api/extension-style.api

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6423,8 +6423,6 @@ public final class com/mapbox/maps/extension/style/sources/generated/GeoJsonSour
64236423
public final fun getPromoteId ()Lcom/mapbox/maps/extension/style/types/PromoteId;
64246424
public final fun getTileCacheBudget ()Lcom/mapbox/maps/TileCacheBudget;
64256425
public final fun getTolerance ()Ljava/lang/Double;
6426-
public final fun minzoom (J)Lcom/mapbox/maps/extension/style/sources/generated/GeoJsonSource;
6427-
public static synthetic fun minzoom$default (Lcom/mapbox/maps/extension/style/sources/generated/GeoJsonSource;JILjava/lang/Object;)Lcom/mapbox/maps/extension/style/sources/generated/GeoJsonSource;
64286426
public final fun prefetchZoomDelta (J)Lcom/mapbox/maps/extension/style/sources/generated/GeoJsonSource;
64296427
public static synthetic fun prefetchZoomDelta$default (Lcom/mapbox/maps/extension/style/sources/generated/GeoJsonSource;JILjava/lang/Object;)Lcom/mapbox/maps/extension/style/sources/generated/GeoJsonSource;
64306428
public final fun tileCacheBudget (Lcom/mapbox/maps/TileCacheBudget;)Lcom/mapbox/maps/extension/style/sources/generated/GeoJsonSource;

extension-style/src/main/java/com/mapbox/maps/extension/style/sources/generated/GeoJsonSource.kt

Lines changed: 0 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extension-style/src/test/java/com/mapbox/maps/extension/style/sources/generated/GeoJsonSourceTest.kt

Lines changed: 0 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)