Skip to content

Commit eea9dff

Browse files
authored
Use composite builds for gl-native and common (#2819)
1 parent 2700dca commit eea9dff

File tree

206 files changed

+38
-96
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

206 files changed

+38
-96
lines changed

.circleci/config.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ commands:
128128
store-results:
129129
steps:
130130
- store_artifacts:
131-
path: sdk/build
131+
path: maps-sdk/build
132132
- store_artifacts:
133133
path: LICENSE.md
134134

@@ -142,7 +142,7 @@ commands:
142142
name: Initialize developer access token for sdk tests
143143
command: |
144144
if [ -n "${MAPBOX_DEVELOPER_CONFIG_XML}" ]; then
145-
echo "${MAPBOX_DEVELOPER_CONFIG_XML}" > sdk/src/androidTest/res/values/developer-config.xml
145+
echo "${MAPBOX_DEVELOPER_CONFIG_XML}" > maps-sdk/src/androidTest/res/values/developer-config.xml
146146
fi
147147
- run:
148148
name: Build << parameters.module_target >> instrumentation test apk
@@ -385,7 +385,7 @@ jobs:
385385
name: check release runtime Mapbox dependencies to fail fast
386386
command: |
387387
echo "PR Target branch: $PR_TARGET_BRANCH"
388-
./gradlew sdk:dependencyInsight --configuration releaseRuntimeClasspath --dependency com.mapbox.maps | grep -vzq 'FAILED'
388+
./gradlew maps-sdk:dependencyInsight --configuration releaseRuntimeClasspath --dependency com.mapbox.maps | grep -vzq 'FAILED'
389389
- run:
390390
name: check changelog
391391
command: |
@@ -620,7 +620,7 @@ jobs:
620620
- mapbox-gl-native-begin
621621
- login-google-cloud-platform
622622
- run-firebase-instrumentation:
623-
module_target: "sdk"
623+
module_target: "maps-sdk"
624624
multiple_devices: false
625625
- mapbox-gl-native-end
626626
- run: exit 0
@@ -633,7 +633,7 @@ jobs:
633633
- read-from-workspace
634634
- login-google-cloud-platform
635635
- run-firebase-instrumentation:
636-
module_target: "sdk"
636+
module_target: "maps-sdk"
637637
multiple_devices: true
638638
- slack/notify:
639639
event: fail
@@ -737,13 +737,13 @@ jobs:
737737
- save-to-workspace:
738738
path: "app/build/outputs/apk/androidTest/debug/app-debug-androidTest.apk"
739739
- build-instrumentation-test:
740-
module_target: "sdk"
740+
module_target: "maps-sdk"
741741
- save-to-workspace:
742-
path: "sdk/build/outputs/apk/androidTest/debug/sdk-debug-androidTest.apk"
742+
path: "maps-sdk/build/outputs/apk/androidTest/debug/maps-sdk-debug-androidTest.apk"
743743
- build-instrumentation-test:
744744
module_target: "module-telemetry"
745745
- save-to-workspace:
746-
path: "module-telemetry/build/outputs/apk/androidTest/debug/sdk-debug-androidTest.apk"
746+
path: "module-telemetry/build/outputs/apk/androidTest/debug/module-telemetry-debug-androidTest.apk"
747747
- store_artifacts:
748748
path: app/build/outputs/apk
749749
destination: .

DEVELOPING.md

Lines changed: 3 additions & 3 deletions

LICENSE.md

Lines changed: 1 addition & 1 deletion

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,15 @@ clean:
3030

3131
.PHONY: codecoverage
3232
codecoverage:
33-
./gradlew sdk:jacocoTestDebugUnitTestReport && google-chrome sdk/build/jacoco/jacocoHtml/index.html
33+
./gradlew maps-sdk:jacocoTestDebugUnitTestReport && google-chrome maps-sdk/build/jacoco/jacocoHtml/index.html
3434

3535
.PHONY: unit-tests
3636
unit-tests:
3737
./gradlew test -i
3838

3939
.PHONY: instrumentation-tests
4040
instrumentation-tests:
41-
./gradlew sdk:connectedDebugAndroidTest && ./gradlew app:connectedDebugAndroidTest
41+
./gradlew maps-sdk:connectedDebugAndroidTest && ./gradlew app:connectedDebugAndroidTest
4242

4343
.PHONY: instrumentation-clean
4444
instrumentation-clean:

android-auto-app/build.gradle.kts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ plugins {
22
id("com.mapbox.gradle.application")
33
}
44

5-
val buildFromSource: String by project
65

76
android {
87
compileSdk = libs.versions.autoCompileSdkVersion.get().toInt()
@@ -27,12 +26,6 @@ android {
2726
execution = "ANDROIDX_TEST_ORCHESTRATOR"
2827
}
2928
}
30-
31-
packagingOptions {
32-
if (buildFromSource.toBoolean()) {
33-
jniLibs.pickFirsts.add("**/libc++_shared.so")
34-
}
35-
}
3629
}
3730

3831
dependencies {
@@ -41,7 +34,7 @@ dependencies {
4134

4235
// Please review the compatibility guide. This app is showcasing the latest features with latest Maps SDK main branch.
4336
// https://github.com/mapbox/mapbox-maps-android/tree/main/extension-androidauto#compatibility-with-maps-sdk-v11
44-
implementation(project(":sdk"))
37+
implementation(project(":maps-sdk"))
4538

4639
implementation(libs.kotlin)
4740
implementation(libs.androidx.appCompat)

app/build.gradle.kts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ apply {
77
from("$rootDir/gradle/script-git-version.gradle")
88
from("$rootDir/gradle/play-publisher.gradle")
99
}
10-
val buildFromSource: String by project
1110

1211
android {
1312
compileSdk = libs.versions.exampleCompileSdkVersion.get().toInt()
@@ -84,16 +83,10 @@ android {
8483
path = file("src/main/cpp/CMakeLists.txt")
8584
}
8685
}
87-
88-
packagingOptions {
89-
if (buildFromSource.toBoolean()) {
90-
jniLibs.pickFirsts.add("**/libc++_shared.so")
91-
}
92-
}
9386
}
9487

9588
dependencies {
96-
implementation(project(":sdk"))
89+
implementation(project(":maps-sdk"))
9790
implementation(libs.kotlin)
9891
implementation(libs.mapbox.javaTurf)
9992
implementation(libs.mapbox.javaGeoJSON)

compose-app/build.gradle.kts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ plugins {
33
id("org.jetbrains.kotlin.plugin.parcelize")
44
}
55

6-
val buildFromSource: String by project
76

87
android {
98
compileSdk = libs.versions.androidCompileSdkVersion.get().toInt()
@@ -54,19 +53,13 @@ android {
5453
}
5554
}
5655

57-
packagingOptions {
58-
if (buildFromSource.toBoolean()) {
59-
jniLibs.pickFirsts.add("**/libc++_shared.so")
60-
}
61-
}
62-
6356
buildFeatures {
6457
compose = true
6558
}
6659
}
6760

6861
dependencies {
69-
implementation(project(":sdk"))
62+
implementation(project(":maps-sdk"))
7063
implementation(project(":extension-compose"))
7164
implementation(platform(libs.compose.bom))
7265
implementation(libs.compose.ui)

extension-androidauto/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ mapboxLibrary {
3434
}
3535

3636
dependencies {
37-
api(project(":sdk"))
37+
api(project(":maps-sdk"))
3838
api(libs.googleCarAppLibrary)
3939
implementation(libs.kotlin)
4040
implementation(libs.androidx.coreKtx)

extension-compose/build.gradle.kts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ mapboxLibrary {
5050

5151
dependencies {
5252
dependencies {
53-
compileOnly(project(":sdk"))
53+
compileOnly(project(":maps-sdk"))
5454
implementation(platform(libs.compose.bom))
5555
implementation(libs.mapbox.javaGeoJSON)
5656
implementation(libs.compose.ui)
@@ -67,11 +67,11 @@ dependencies {
6767
androidTestImplementation(libs.androidx.testJUnit)
6868
androidTestImplementation(libs.androidx.espresso)
6969
androidTestImplementation(libs.androidx.uiAutomator)
70-
androidTestImplementation(project(":sdk"))
70+
androidTestImplementation(project(":maps-sdk"))
7171
androidTestImplementation(libs.compose.uiTest)
7272

7373
testImplementation(libs.bundles.base.dependenciesTests)
74-
testImplementation(project(":sdk"))
74+
testImplementation(project(":maps-sdk"))
7575
testImplementation(libs.junit)
7676

7777
detektPlugins(libs.detektFormatting)

extension-style-app/build.gradle.kts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ plugins {
33
id("com.mapbox.maps.token")
44
}
55

6-
val buildFromSource: String by project
76

87
android {
98
compileSdk = libs.versions.androidCompileSdkVersion.get().toInt()
@@ -29,15 +28,10 @@ android {
2928
}
3029
}
3130

32-
packagingOptions {
33-
if (buildFromSource.toBoolean()) {
34-
jniLibs.pickFirsts.add("**/libc++_shared.so")
35-
}
36-
}
3731
}
3832

3933
dependencies {
40-
implementation(project(":sdk"))
34+
implementation(project(":maps-sdk"))
4135
implementation(libs.kotlin)
4236
implementation(libs.androidx.appCompat)
4337
androidTestUtil(libs.androidx.orchestrator)

0 commit comments

Comments
 (0)