Add setStyleSourceProperty overload with importId parameter (#8217)

This is "backport" to main of a fix, [which
PR](mapbox/mapbox-sdk#8205) was merged directly
to release/v0.17

Adds a new overloaded setStyleSourceProperty method to
MapboxStyleManager that supports modifying source properties within
imported styles.

Changes

- Added new setStyleSourceProperty(importId, sourceId, property, value)
method
- Annotated with @MapboxExperimental as this wraps experimental
functionality
- Maintains thread safety with @mainthread and ThreadChecker validation
- Falls back to root style when importId is empty

This PR is a hotfix for [this
issue](https://mapbox.slack.com/archives/C08UBP5UMPB/p1763547109463079)
and exceptionally merging to release/v0.17 as it needs to be included
ASAP to v0.17-rc.1 release.

cc @mapbox/maps-android

GitOrigin-RevId: 8e2fdfb01a001b4a97cc0ece9608fcb6c354a7dd

Author: lyydikoi

maps-sdk/api/maps-sdk.api

@@ -560,6 +560,7 @@ public final class com/mapbox/maps/Style : com/mapbox/maps/MapboxStyleManager {
 	public fun setStyleProjectionProperty (Ljava/lang/String;Lcom/mapbox/bindgen/Value;)Lcom/mapbox/bindgen/Expected;
 	public fun setStyleSourceProperties (Ljava/lang/String;Lcom/mapbox/bindgen/Value;)Lcom/mapbox/bindgen/Expected;
 	public fun setStyleSourceProperty (Ljava/lang/String;Ljava/lang/String;Lcom/mapbox/bindgen/Value;)Lcom/mapbox/bindgen/Expected;
+	public fun setStyleSourceProperty (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lcom/mapbox/bindgen/Value;)Lcom/mapbox/bindgen/Expected;
 	public fun setStyleTerrain (Lcom/mapbox/bindgen/Value;)Lcom/mapbox/bindgen/Expected;
 	public fun setStyleTerrainProperty (Ljava/lang/String;Lcom/mapbox/bindgen/Value;)Lcom/mapbox/bindgen/Expected;
 	public fun setStyleTransition (Lcom/mapbox/maps/TransitionOptions;)V

maps-sdk/src/main/java/com/mapbox/maps/NativeMapImpl.kt

@@ -615,6 +615,17 @@ internal class NativeMapImpl(val map: Map) {
     return map.setStyleSourceProperty(sourceId, property, value)
   }
 
+  @MapboxExperimental
+  @OptIn(com.mapbox.annotation.MapboxExperimental::class)
+  fun setStyleSourceProperty(
+    importId: String,
+    sourceId: String,
+    property: String,
+    value: Value
+  ): Expected<String, None> {
+    return map.setStyleSourceProperty(importId, sourceId, property, value)
+  }
+
   fun coordinateBoundsZoomForCamera(camera: CameraOptions): CoordinateBoundsZoom {
     return map.coordinateBoundsZoomForCamera(camera)
   }

maps-sdk/src/main/java/com/mapbox/maps/Style.kt

@@ -101,6 +101,32 @@ class Style internal constructor(
     return super.setStyleSourceProperty(sourceId, property, value)
   }
 
+  /**
+   * Sets a value to a style source property for a source that belongs to a specific style import.
+   *
+   * This method allows modification of source properties within imported styles, enabling
+   * fine-grained control over sources from different style fragments or imports.
+   * If `importId` is empty, this method falls back to updating the root style.
+   *
+   * @param importId An identifier of the style import containing the target source.
+   * @param sourceId A style source identifier.
+   * @param property The style source property name.
+   * @param value The style source property value.
+   *
+   * @return A string describing an error if the operation was not successful, empty otherwise.
+   */
+  @MapboxExperimental
+  @MainThread
+  override fun setStyleSourceProperty(
+    importId: String,
+    sourceId: String,
+    property: String,
+    value: Value
+  ): Expected<String, None> {
+    checkNativeStyle("setStyleSourceProperty")
+    return super.setStyleSourceProperty(importId, sourceId, property, value)
+  }
+
   /**
    * Returns the map style's transition options. By default, the style parser will attempt
    * to read the style default transition options, if any, fallbacking to an immediate transition

maps-sdk/src/test/java/com/mapbox/maps/NativeMapTest.kt

@@ -277,6 +277,14 @@ class NativeMapTest {
     verify { map.setStyleSourceProperty("foo", "bar", value) }
   }
 
+  @Test
+  fun setStyleSourcePropertyWithImportId() {
+    val value = mockk<Value>()
+    val nativeMap = NativeMapImpl(map)
+    nativeMap.setStyleSourceProperty("importId", "foo", "bar", value)
+    verify { map.setStyleSourceProperty("importId", "foo", "bar", value) }
+  }
+
   @Test
   fun getStyleSourceProperties() {
     val nativeMap = NativeMapImpl(map)

maps-sdk/src/test/java/com/mapbox/maps/StyleTest.kt

@@ -270,6 +270,12 @@ class StyleTest {
     verify { styleManager.setStyleSourceProperty("id", "foobar", value) }
   }
 
+  @Test
+  fun setSourcePropertyWithImportId() {
+    val value = mockk<Value>()
+    style.setStyleSourceProperty("importId", "id", "foobar", value)
+    verify { styleManager.setStyleSourceProperty("importId", "id", "foobar", value) }
+  }
   @Test
   fun getSourceProperty() {
     style.getStyleSourceProperty("id", "foobar")

sdk-base/api/Release/metalava.txt

@@ -239,6 +239,7 @@ package com.mapbox.maps {
     method @CallSuper @MainThread @com.mapbox.maps.MapboxExperimental public com.mapbox.bindgen.Expected<java.lang.String,com.mapbox.bindgen.None> setStyleSnowProperty(String property, com.mapbox.bindgen.Value value);
     method @CallSuper @MainThread public com.mapbox.bindgen.Expected<java.lang.String,com.mapbox.bindgen.None> setStyleSourceProperties(String sourceId, com.mapbox.bindgen.Value properties);
     method @CallSuper @MainThread public com.mapbox.bindgen.Expected<java.lang.String,com.mapbox.bindgen.None> setStyleSourceProperty(String sourceId, String property, com.mapbox.bindgen.Value value);
+    method @CallSuper @MainThread @com.mapbox.maps.MapboxExperimental public com.mapbox.bindgen.Expected<java.lang.String,com.mapbox.bindgen.None> setStyleSourceProperty(String importId, String sourceId, String property, com.mapbox.bindgen.Value value);
     method @CallSuper @MainThread public com.mapbox.bindgen.Expected<java.lang.String,com.mapbox.bindgen.None> setStyleTerrain(com.mapbox.bindgen.Value properties);
     method @CallSuper @MainThread public com.mapbox.bindgen.Expected<java.lang.String,com.mapbox.bindgen.None> setStyleTerrainProperty(String property, com.mapbox.bindgen.Value value);
     method @CallSuper @MainThread public void setStyleTransition(com.mapbox.maps.TransitionOptions transitionOptions);

sdk-base/api/sdk-base.api

@@ -263,6 +263,7 @@ public class com/mapbox/maps/MapboxStyleManager {
 	public fun setStyleSnowProperty (Ljava/lang/String;Lcom/mapbox/bindgen/Value;)Lcom/mapbox/bindgen/Expected;
 	public fun setStyleSourceProperties (Ljava/lang/String;Lcom/mapbox/bindgen/Value;)Lcom/mapbox/bindgen/Expected;
 	public fun setStyleSourceProperty (Ljava/lang/String;Ljava/lang/String;Lcom/mapbox/bindgen/Value;)Lcom/mapbox/bindgen/Expected;
+	public fun setStyleSourceProperty (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lcom/mapbox/bindgen/Value;)Lcom/mapbox/bindgen/Expected;
 	public fun setStyleTerrain (Lcom/mapbox/bindgen/Value;)Lcom/mapbox/bindgen/Expected;
 	public fun setStyleTerrainProperty (Ljava/lang/String;Lcom/mapbox/bindgen/Value;)Lcom/mapbox/bindgen/Expected;
 	public fun setStyleTransition (Lcom/mapbox/maps/TransitionOptions;)V

sdk-base/src/main/java/com/mapbox/maps/MapboxStyleManager.kt

@@ -747,6 +747,33 @@ open class MapboxStyleManager @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP_PREFIX)
     return styleManager.setStyleSourceProperty(sourceId, property, value)
   }
 
+  /**
+   * Sets a value to a style source property for a source that belongs to a specific style import.
+   *
+   * This method allows modification of source properties within imported styles, enabling
+   * fine-grained control over sources from different style fragments or imports.
+   * If `importId` is empty, this method falls back to updating the root style.
+   *
+   * @param importId An identifier of the style import containing the target source.
+   * @param sourceId A style source identifier.
+   * @param property The style source property name.
+   * @param value The style source property value.
+   *
+   * @return A string describing an error if the operation was not successful, empty otherwise.
+   */
+  @MapboxExperimental
+  @CallSuper
+  @MainThread
+  open fun setStyleSourceProperty(
+    importId: String,
+    sourceId: String,
+    property: String,
+    value: Value
+  ): Expected<String, None> {
+    ThreadChecker.throwIfNotMainThread()
+    return styleManager.setStyleSourceProperty(importId, sourceId, property, value)
+  }
+
   /**
    * Gets style source properties.
    *