Avoid creating objects during render pass (#4612)

GitOrigin-RevId: adeb205908596273fd78594e65a0d66068471426

Author: jush

maps-sdk/src/main/java/com/mapbox/maps/renderer/FpsManager.kt

@@ -2,7 +2,7 @@ package com.mapbox.maps.renderer
 
 import android.os.Handler
 import androidx.annotation.RestrictTo
-import androidx.core.os.postDelayed
+import androidx.core.os.HandlerCompat
 import com.mapbox.maps.logI
 import com.mapbox.maps.logW
 import kotlin.math.pow
@@ -85,6 +85,10 @@ internal class FpsManager(
     return true
   }
 
+  /**
+   * Keep a runnable to [onRenderingPaused] to avoid creating a new one every time.
+   */
+  private val onRenderingPausedRunnable = Runnable { onRenderingPaused() }
   fun postRender() {
     val frameRenderTimeNs = System.nanoTime() - preRenderTimeNs
     frameRenderTimeAccumulatedNs += frameRenderTimeNs
@@ -95,12 +99,12 @@ internal class FpsManager(
       // however to produce correct values we also update FPS after IDLE_TIMEOUT_MS
       // otherwise when updating the map after it was IDLE first update will report
       // huge delta between new frame and last frame (as we're using dirty rendering)
-      handler.postDelayed(
-        VSYNC_COUNT_TILL_IDLE * (screenRefreshPeriodNs / ONE_MILLISECOND_NS),
-        fpsManagerToken
-      ) {
-        onRenderingPaused()
-      }
+      HandlerCompat.postDelayed(
+        handler,
+        onRenderingPausedRunnable,
+        fpsManagerToken,
+        VSYNC_COUNT_TILL_IDLE * (screenRefreshPeriodNs / ONE_MILLISECOND_NS)
+      )
     }
     preRenderTimeNs = -1L
   }

maps-sdk/src/main/java/com/mapbox/maps/renderer/MapboxRenderThread.kt

@@ -211,11 +211,15 @@ internal class MapboxRenderThread : Choreographer.FrameCallback {
     this.TAG = ""
   }
 
+  /**
+   * Keep a runnable to [prepareRenderFrame] to avoid creating a new one on every frame.
+   */
+  private val prepareRenderFrameRunnable: Runnable = Runnable {
+      prepareRenderFrame()
+  }
   private fun postPrepareRenderFrame(delayMillis: Long = 0L) {
     renderHandlerThread.postDelayed(
-      {
-        prepareRenderFrame()
-      },
+      prepareRenderFrameRunnable,
       delayMillis
     )
   }
@@ -506,8 +510,8 @@ internal class MapboxRenderThread : Choreographer.FrameCallback {
   fun onSurfaceSizeChanged(width: Int, height: Int) {
     if (this.width != width || this.height != height) {
       renderHandlerThread.post {
-        this.width = width
-        this.height = height
+        this@MapboxRenderThread.width = width
+        this@MapboxRenderThread.height = height
         sizeChanged = true
         prepareRenderFrame()
       }
@@ -522,7 +526,7 @@ internal class MapboxRenderThread : Choreographer.FrameCallback {
         if (renderHandlerThread.isRunning) {
           renderHandlerThread.post {
             awaitingNextVsync = false
-            Choreographer.getInstance().removeFrameCallback(this)
+            Choreographer.getInstance().removeFrameCallback(this@MapboxRenderThread)
             surfaceProcessingLock.withLock {
               // TODO https://github.com/mapbox/mapbox-maps-android/issues/607
               if (nativeRenderCreated && mapboxRenderer is MapboxTextureViewRenderer) {
@@ -687,9 +691,11 @@ internal class MapboxRenderThread : Choreographer.FrameCallback {
             renderThreadPrepared -> {
               renderEvent.runnable?.run()
             }
+
             paused -> {
               nonRenderEventQueue.add(renderEvent)
             }
+
             else -> {
               logW(TAG, "Non-render event could not be run, retrying in $RETRY_DELAY_MS ms...")
               postNonRenderEvent(renderEvent, delayMillis = RETRY_DELAY_MS)
@@ -712,9 +718,7 @@ internal class MapboxRenderThread : Choreographer.FrameCallback {
     paused = false
     logI(TAG, "Renderer resumed, renderThreadPrepared=$renderThreadPrepared, surface.isValid=${surface?.isValid}")
     // schedule render if we resume not after first create (e.g. bring map back to front)
-    renderPreparedGuardedRun {
-      postPrepareRenderFrame()
-    }
+    renderPreparedGuardedRun(::postPrepareRenderFrame)
   }
 
   @UiThread

maps-sdk/src/main/java/com/mapbox/maps/renderer/RenderHandlerThread.kt

@@ -31,11 +31,11 @@ internal class RenderHandlerThread(
   @Suppress("PrivatePropertyName")
   private val TAG = "Mbgl-$handlerThreadName" + if (mapName.isNotBlank()) "\\$mapName" else ""
 
-  fun post(task: () -> Unit) {
+  fun post(task: Runnable) {
     postDelayed(task, 0)
   }
 
-  fun postDelayed(task: () -> Unit, delayMillis: Long) {
+  fun postDelayed(task: Runnable, delayMillis: Long) {
     handler?.let {
       val message = Message.obtain(it, task)
       it.sendMessageDelayed(message, delayMillis)