Activity fixes (Tilestore crash, experimental line-trim properties) (#2800)

* Fix offline activity crash

* PR fixes + line trim updates

* Add missing changelog

---------

Co-authored-by: kiryldz <[email protected]>

Author: jush

CHANGELOG.md

@@ -12,6 +12,7 @@ Mapbox welcomes participation and contributions from everyone.
 ## Features ✨ and improvements 🏁
 * Introduce `Style.STANDARD_EXPERIMENTAL` style supporting featuresets and map interactions. **Important: this style should not be used in production as the style definition on backend is a subject to change after v11.8.0 stable release!**
 * Introduce fully typed map click and long click interactions working with `Style.STANDARD_EXPERIMENTAL`: `standardPoi`, `standardPlaceLabels`, `standardBuildings`.
+* Use [Cronet](https://developer.android.com/develop/connectivity/cronet) as the default network stack. If Cronet is not available, network stack defaults to [OkHttp](https://square.github.io/okhttp/) used in previous versions.
 * Introduce `OnClusterClickListener` and `OnClusterLongClickListener` for `CircleAnnotationManager` and `PointAnnotationManager`. These callbacks receive the clicked cluster represented by a `ClusterFeature`.
 * Introduce experimental `getStyleGlyphURL` / `setStyleGlyphURL` functions for `MapboxMap` and `Style`.
 * Make `fill-extrusion-emissive-strength` property data-driven.

app/src/main/java/com/mapbox/maps/testapp/examples/MapViewCustomizationActivity.kt

@@ -27,6 +27,8 @@ class MapViewCustomizationActivity : AppCompatActivity() {
   override fun onCreate(savedInstanceState: Bundle?) {
     super.onCreate(savedInstanceState)
 
+    val initialTileStore = MapboxOptions.mapsOptions.tileStore
+    val initialTileStoreUsageMode = MapboxOptions.mapsOptions.tileStoreUsageMode
     // Set tile store and tile store usage mode so that all MapViews created from now on will apply
     // these settings.
     MapboxOptions.mapsOptions.tileStore = tileStore
@@ -40,6 +42,10 @@ class MapViewCustomizationActivity : AppCompatActivity() {
     // But you can also add your style to the map layout with xml attribute `app:mapbox_styleUri="mapbox://styles/mapbox/dark-v11"`
     binding.mapView.mapboxMap.loadStyle(Style.DARK)
     configureMapViewFromCode()
+
+    // Reset to original state
+    MapboxOptions.mapsOptions.tileStore = initialTileStore
+    MapboxOptions.mapsOptions.tileStoreUsageMode = initialTileStoreUsageMode
   }
 
   private fun configureMapViewFromCode() {

app/src/main/java/com/mapbox/maps/testapp/examples/OfflineActivity.kt

@@ -51,9 +51,7 @@ import kotlinx.coroutines.launch
  */
 class OfflineActivity : AppCompatActivity() {
   // We use the default tile store
-  private val tileStore: TileStore by lazy {
-    MapboxOptions.mapsOptions.tileStore!!
-  }
+  private val tileStore: TileStore = MapboxOptions.mapsOptions.tileStore!!
   private val offlineManager: OfflineManager = OfflineManager()
   private val offlineLogsAdapter: OfflineLogsAdapter = OfflineLogsAdapter()
   private lateinit var binding: ActivityOfflineBinding

app/src/main/java/com/mapbox/maps/testapp/examples/linesandpolygons/LineGradientActivity.kt

@@ -5,6 +5,7 @@ import androidx.appcompat.app.AppCompatActivity
 import com.mapbox.geojson.Feature
 import com.mapbox.geojson.LineString
 import com.mapbox.geojson.Point
+import com.mapbox.maps.MapboxExperimental
 import com.mapbox.maps.Style
 import com.mapbox.maps.extension.style.expressions.dsl.generated.interpolate
 import com.mapbox.maps.extension.style.layers.generated.LineLayer
@@ -19,6 +20,7 @@ import com.mapbox.maps.testapp.databinding.ActivityLineGradientBinding
 
 class LineGradientActivity : AppCompatActivity() {
 
+  @OptIn(MapboxExperimental::class)
   override fun onCreate(savedInstanceState: Bundle?) {
     super.onCreate(savedInstanceState)
     val binding = ActivityLineGradientBinding.inflate(layoutInflater)
@@ -29,7 +31,11 @@ class LineGradientActivity : AppCompatActivity() {
       binding.trimOffsetButton.setOnClickListener {
         val lineLayer = style.getLayerAs<LineLayer>(LAYER_ID)
         val lastTrimPosition = lineLayer?.lineTrimOffset?.last() ?: 0.0
-        lineLayer?.lineTrimOffset(listOf(0.0, (lastTrimPosition + 0.05).coerceAtMost(1.0)))
+        lineLayer?.let { layer ->
+          layer.lineTrimOffset(listOf(0.0, (lastTrimPosition + 0.05).coerceAtMost(1.0)))
+          layer.lineTrimColor("rgba(6, 1, 255, 0.2)")
+          layer.lineTrimFadeRange(listOf(0.0, 0.0001))
+        }
       }
     }
   }

app/src/main/java/com/mapbox/maps/testapp/utils/NavigationSimulator.kt

@@ -7,7 +7,6 @@ import com.mapbox.geojson.Point
 import com.mapbox.maps.EdgeInsets
 import com.mapbox.maps.ImageHolder
 import com.mapbox.maps.MapView
-import com.mapbox.maps.MapboxExperimental
 import com.mapbox.maps.extension.style.expressions.dsl.generated.interpolate
 import com.mapbox.maps.extension.style.layers.addLayer
 import com.mapbox.maps.extension.style.layers.generated.LineLayer
@@ -74,7 +73,6 @@ class NavigationSimulator(
     initMapboxMap()
   }
 
-  @OptIn(MapboxExperimental::class)
   private fun initMapboxMap() {
     routeLayer = lineLayer(ROUTE_LINE_LAYER_ID, GEOJSON_SOURCE_ID) {
       lineWidth(
@@ -141,8 +139,6 @@ class NavigationSimulator(
           }
         }
       )
-      lineTrimColor("rgba(6, 1, 255, 0.2)")
-      lineTrimFadeRange(listOf(0.0, 0.0001))
     }
     casingLayer = lineLayer(ROUTE_CASING_LAYER_ID, GEOJSON_SOURCE_ID) {
       lineWidth(

compose-app/src/main/java/com/mapbox/maps/compose/testapp/examples/location/NavigationSimulationActivity.kt

@@ -18,7 +18,6 @@ import androidx.compose.runtime.remember
 import androidx.compose.runtime.setValue
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
-import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.unit.dp
 import com.mapbox.api.directions.v5.models.DirectionsResponse
@@ -38,7 +37,6 @@ import com.mapbox.maps.extension.compose.animation.viewport.rememberMapViewportS
 import com.mapbox.maps.extension.compose.style.BooleanValue
 import com.mapbox.maps.extension.compose.style.ColorValue
 import com.mapbox.maps.extension.compose.style.DoubleListValue
-import com.mapbox.maps.extension.compose.style.DoubleRangeValue
 import com.mapbox.maps.extension.compose.style.DoubleValue
 import com.mapbox.maps.extension.compose.style.MapboxStyleComposable
 import com.mapbox.maps.extension.compose.style.layers.generated.LineCapValue
@@ -260,8 +258,6 @@ public class NavigationSimulationActivity : ComponentActivity() {
                 }
               }
             )
-            lineTrimColor = ColorValue(Color(6, 1, 255, 51))
-            lineTrimFadeRange = DoubleRangeValue(0.0, 0.0001)
           }
           LineLayer(
             sourceState = geoJsonSource