Skip to content

Commit 06ac19a

Browse files
authored
Merge branch 'main' into rl/puck_pulsing_ios
2 parents d7a5bb2 + 5ac5cb1 commit 06ac19a

File tree

4 files changed

+12
-13
lines changed

4 files changed

+12
-13
lines changed

android/src/main/kotlin/com/mapbox/maps/mapbox_maps/mapping/LocationComponentMappings.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,11 @@ fun LocationComponentSettingsInterface2.applyFromFLT(settings: FLTSettings.Locat
5555
fun LocationComponentSettingsInterface2.toFLT() = FLTSettings.LocationComponentSettings.Builder().let { settings ->
5656
settings.setEnabled(enabled)
5757
settings.setPulsingEnabled(pulsingEnabled)
58-
settings.setPulsingColor(pulsingColor.toLong())
58+
settings.setPulsingColor(pulsingColor.toUInt().toLong())
5959
settings.setPulsingMaxRadius(pulsingMaxRadius.toDouble())
6060
settings.setShowAccuracyRing(showAccuracyRing)
61-
settings.setAccuracyRingColor(accuracyRingColor.toLong())
62-
settings.setAccuracyRingBorderColor(accuracyRingBorderColor.toLong())
61+
settings.setAccuracyRingColor(accuracyRingColor.toUInt().toLong())
62+
settings.setAccuracyRingBorderColor(accuracyRingBorderColor.toUInt().toLong())
6363
settings.setLayerAbove(layerAbove)
6464
settings.setLayerBelow(layerBelow)
6565
settings.setPuckBearingEnabled(puckBearingEnabled)

android/src/main/kotlin/com/mapbox/maps/mapbox_maps/mapping/ScaleBarMappings.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ fun ScaleBarSettingsInterface.toFLT() = FLTSettings.ScaleBarSettings.Builder().l
3434
settings.setMarginTop(marginTop.toDouble())
3535
settings.setMarginRight(marginRight.toDouble())
3636
settings.setMarginBottom(marginBottom.toDouble())
37-
settings.setTextColor(textColor.toLong())
38-
settings.setPrimaryColor(primaryColor.toLong())
39-
settings.setSecondaryColor(secondaryColor.toLong())
37+
settings.setTextColor(textColor.toUInt().toLong())
38+
settings.setPrimaryColor(primaryColor.toUInt().toLong())
39+
settings.setSecondaryColor(secondaryColor.toUInt().toLong())
4040
settings.setBorderWidth(borderWidth.toDouble())
4141
settings.setHeight(height.toDouble())
4242
settings.setTextBarMargin(textBarMargin.toDouble())

example/integration_test/location_test.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,8 @@ void main() {
6565
expect(updatedSettings.puckBearingSource, settings.puckBearingSource);
6666
expect(updatedSettings.showAccuracyRing, settings.showAccuracyRing);
6767
// FIXME bitmaps are decoded incorrectly for some reason
68-
// expect(updatedSettings.accuracyRingBorderColor,
69-
// settings.accuracyRingBorderColor);
70-
// expect(updatedSettings.accuracyRingColor, settings.accuracyRingColor);
68+
expect(updatedSettings.accuracyRingBorderColor, settings.accuracyRingBorderColor);
69+
expect(updatedSettings.accuracyRingColor, settings.accuracyRingColor);
7170
// expect(updatedSettings.locationPuck?.locationPuck2D?.bearingImage,
7271
// settings.locationPuck?.locationPuck2D?.bearingImage);
7372
// expect(updatedSettings.locationPuck?.locationPuck2D?.topImage,

example/integration_test/scale_bar_test.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ void main() {
4747
expect(updatedSettings.marginTop, 2);
4848
expect(updatedSettings.marginRight, 3);
4949
expect(updatedSettings.marginBottom, 4);
50-
// FIXME colors are decoded incorrectly for some reason
51-
// expect(updatedSettings.textColor, Colors.black.value);
52-
// expect(updatedSettings.primaryColor, Colors.red.value);
53-
// expect(updatedSettings.secondaryColor, Colors.blue.value);
50+
// iOS doesn't support these settings
51+
expect(updatedSettings.textColor, Colors.black.value);
52+
expect(updatedSettings.primaryColor, Colors.red.value);
53+
expect(updatedSettings.secondaryColor, Colors.blue.value);
5454
expect(updatedSettings.borderWidth, 2);
5555
expect(updatedSettings.height, 10);
5656
expect(updatedSettings.textBarMargin, 1);

0 commit comments

Comments
 (0)