[iOS] Fix onScroll being triggered only once at the end of pan gesture (#410)

* [iOS] Fix onScroll being triggered only once at the end of pan gesture

* Add changelog entry

Author: evil159

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 * Add `LogConfiguration` allowing to intercept logs produced by the plugin. Pass your custom `LogWriterBackend` to `LogConfiguration.registerLogWriterBackend()` to redirect logs produced by the mapping engine to your desired destination.
 * Add `MapWidget.onResourceRequestListener` that can be used to subscribe to resource requests made by the map.
+* [iOS] Re-wire `MapWidget`'s `onScroll` event to be triggered whenever map is being panned instead of triggering it only after pan ends.
 
 ### 1.0.0-beta.3
 

ios/Classes/GesturesController.swift

@@ -9,19 +9,25 @@ class GesturesController: NSObject, FLT_SETTINGSGesturesSettingsInterface, UIGes
     func gestureManager(_ gestureManager: MapboxMaps.GestureManager, didBegin gestureType: MapboxMaps.GestureType) {}
 
     func gestureManager(_ gestureManager: MapboxMaps.GestureManager, didEnd gestureType: MapboxMaps.GestureType, willAnimate: Bool) {
-        switch gestureType {
-        case .pan:
-            let point = Point(mapView.mapboxMap.coordinate(for: gestureManager.panGestureRecognizer.location(in: mapView)))
-            self.onGestureListener?.onScroll(FLT_GESTURESScreenCoordinate.makeWith(x: point.coordinates.latitude, y: point.coordinates.longitude), completion: {_ in })
-        case .singleTap:
-            let point = Point(mapView.mapboxMap.coordinate(for: gestureManager.singleTapGestureRecognizer.location(in: mapView)))
-            self.onGestureListener?.onTap(FLT_GESTURESScreenCoordinate.makeWith(x: point.coordinates.latitude, y: point.coordinates.longitude), completion: {_ in })
-        default: break
+        guard gestureType == .singleTap else {
+            return
         }
+
+        let point = Point(mapView.mapboxMap.coordinate(for: gestureManager.singleTapGestureRecognizer.location(in: mapView)))
+        self.onGestureListener?.onTap(FLT_GESTURESScreenCoordinate.makeWith(x: point.coordinates.latitude, y: point.coordinates.longitude), completion: {_ in })
     }
 
     func gestureManager(_ gestureManager: MapboxMaps.GestureManager, didEndAnimatingFor gestureType: MapboxMaps.GestureType) {}
 
+    @objc private func onMapPan(_ sender: UIPanGestureRecognizer) {
+        guard sender.state == .began || sender.state == .changed || sender.state == .ended else {
+            return
+        }
+
+        let point = Point(mapView.mapboxMap.coordinate(for: sender.location(in: mapView)))
+        self.onGestureListener?.onScroll(FLT_GESTURESScreenCoordinate.makeWith(x: point.coordinates.latitude, y: point.coordinates.longitude), completion: {_ in })
+    }
+
     @objc private func onMapLongTap(_ sender: UITapGestureRecognizer) {
         guard sender.state == .ended else { return }
         let point = Point(mapView.mapboxMap.coordinate(for: sender.location(in: mapView)))
@@ -113,6 +119,7 @@ class GesturesController: NSObject, FLT_SETTINGSGesturesSettingsInterface, UIGes
         gestureRecognizer = UILongPressGestureRecognizer(target: self, action: #selector(onMapLongTap))
         mapView.addGestureRecognizer(gestureRecognizer!)
         mapView.gestures.delegate = self
+        mapView.gestures.panGestureRecognizer.addTarget(self, action: #selector(onMapPan))
         onGestureListener = FLT_GESTURESGestureListener(binaryMessenger: messenger)
     }
 
@@ -124,7 +131,6 @@ class GesturesController: NSObject, FLT_SETTINGSGesturesSettingsInterface, UIGes
 
     private var mapView: MapView
     private var gestureRecognizer: UIGestureRecognizer?
-    private var cancelable: Cancelable?
 
     init(withMapView mapView: MapView) {
         self.mapView = mapView