Prevent multiple results being submitted by viewport transition completion on Android (#813)

evil159 · web-flow · commit c67811818e8f · 2024-12-17T15:11:40.000+02:00
diff --git a/android/src/main/kotlin/com/mapbox/maps/mapbox_maps/ViewportController.kt b/android/src/main/kotlin/com/mapbox/maps/mapbox_maps/ViewportController.kt
@@ -54,8 +54,10 @@ class ViewportController(
         return
       }
       val transition = viewportPlugin.transitionFromFLTTransition(transitionStorage, cameraPlugin)
+      var callbackCopy: ((Result<Boolean>) -> Unit)? = callback
       viewportPlugin.transitionTo(state, transition) { success ->
-        callback(Result.success(success))
+        callbackCopy?.invoke(Result.success(success))
+        callbackCopy = null
       }
     } catch (error: Exception) {
       logE("Viewport", "Could not create viewport state ouf of options: $stateStorage")

Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,10 @@ class ViewportController(`
`54`	`54`	`return`
`55`	`55`	`}`
`56`	`56`	`val transition = viewportPlugin.transitionFromFLTTransition(transitionStorage, cameraPlugin)`
	`57`	`+ var callbackCopy: ((Result<Boolean>) -> Unit)? = callback`
`57`	`58`	`viewportPlugin.transitionTo(state, transition) { success ->`
`58`		`- callback(Result.success(success))`
	`59`	`+ callbackCopy?.invoke(Result.success(success))`
	`60`	`+ callbackCopy = null`
`59`	`61`	`}`
`60`	`62`	`} catch (error: Exception) {`
`61`	`63`	`logE("Viewport", "Could not create viewport state ouf of options: $stateStorage")`