Skip to content

Commit 635de57

Browse files
evil159github-actions[bot]
authored andcommitted
Remove unneeded logs (#7325)
In the scope of review of logging I went through logs in the sdk and found couple that could be removed. Other than that I couldn't find anything blatantly against the [Good Logging Principles](https://mapbox.atlassian.net/wiki/spaces/CORESDK/pages/1657536581/Good+logging+principles), it looks like on iOS side logs are held as a last resort action mostly for legitimate warning/error cases. With only a few logs of debug/info level that appear to be legitimately used as well. Addresses: https://mapbox.atlassian.net/browse/MAPSIOS-1889 cc @mapbox/maps-ios GitOrigin-RevId: 2d537e6afe2f0ffed4abe42e8851aad4b98ee32a
1 parent c71e940 commit 635de57

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

Sources/Examples/AppDelegate.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
1919
geofencing.addObserver(observer: self, callback: { result in
2020
switch result {
2121
case .success:
22-
os_log(.info, "Geofencing: Observer added properly")
22+
break
2323
case .failure(let error):
2424
os_log(.error, "Geofencing: Error while adding observer %@", error.message)
2525
}
@@ -34,7 +34,6 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
3434
let tabBarAppearance = UITabBarAppearance()
3535
tabBarAppearance.configureWithOpaqueBackground()
3636

37-
3837
UITabBar.appearance().scrollEdgeAppearance = tabBarAppearance
3938

4039
return true

Sources/MapboxMaps/Foundation/MapView.swift

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -513,12 +513,6 @@ open class MapView: UIView, SizeTrackingLayerDelegate {
513513
return
514514
}
515515

516-
// Metal is unavailable on older simulators
517-
guard ProcessInfo().isOperatingSystemAtLeast(OperatingSystemVersion(majorVersion: 13, minorVersion: 0, patchVersion: 0)) else {
518-
Log.warning("Metal rendering is not supported on iOS versions < iOS 13. Please test on device or on iOS simulators version >= 13.", category: "MapView")
519-
return
520-
}
521-
522516
// Metal is unavailable for a different reason
523517
Log.error("No suitable Metal simulator can be found.", category: "MapView")
524518
#endif

0 commit comments

Comments
 (0)