Style spec changes for LocationIndicatorLayer (#2482)

Co-authored-by: Release SDK bot for Maps SDK team <[email protected]>

Author: pjleonard37

CHANGELOG.md

@@ -4,6 +4,8 @@ Mapbox welcomes participation and contributions from everyone.
 
 ## main
 
+* `top-image`, `bearing-image`, and `shadow-image` properties on `LocationIndicatorLayer` are now paint properties instead of layout properties.
+
 ## 11.11.0-rc.1 – 12 March, 2025
 
 * Expose experimental API for setting ColorTheme on style imports.

Sources/MapboxMaps/Location/Puck/Puck2DRenderer.swift

@@ -114,12 +114,12 @@ final class Puck2DRenderer: PuckRenderer {
                 StyleTransition.CodingKeys.duration.rawValue: 0,
                 StyleTransition.CodingKeys.delay.rawValue: 0]
 
-            newLayerLayoutProperties[.topImage] = Self.topImageId
+            newLayerPaintProperties[.topImage] = Self.topImageId
             if newConfiguration.bearingImage != nil {
-                newLayerLayoutProperties[.bearingImage] = Self.bearingImageId
+                newLayerPaintProperties[.bearingImage] = Self.bearingImageId
             }
             if newConfiguration.shadowImage != nil {
-                newLayerLayoutProperties[.shadowImage] = Self.shadowImageId
+                newLayerPaintProperties[.shadowImage] = Self.shadowImageId
             }
 
             newLayerPaintProperties[.locationTransition] = immediateTransition

Sources/MapboxMaps/Style/Generated/Layers/LocationIndicatorLayer.swift

@@ -131,19 +131,19 @@ final class Puck2DRendererTests: XCTestCase {
         with state: PuckRendererState<Puck2DConfiguration>,
         bearing: Double? = nil
     ) -> [String: Any] {
+        var expectedPaintLayerProperties = [LocationIndicatorLayer.PaintCodingKeys: Any]()
         var expectedLayoutLayerProperties = [LocationIndicatorLayer.LayoutCodingKeys: Any]()
-        expectedLayoutLayerProperties[.topImage] = "locationIndicatorLayerTopImage"
+        expectedPaintLayerProperties[.topImage] = "locationIndicatorLayerTopImage"
         if state.configuration.bearingImage != nil {
-            expectedLayoutLayerProperties[.bearingImage] = "locationIndicatorLayerBearingImage"
+            expectedPaintLayerProperties[.bearingImage] = "locationIndicatorLayerBearingImage"
         }
         if state.configuration.shadowImage != nil {
-            expectedLayoutLayerProperties[.shadowImage] = "locationIndicatorLayerShadowImage"
+            expectedPaintLayerProperties[.shadowImage] = "locationIndicatorLayerShadowImage"
         }
 
         let resolvedScale = state.configuration.scale ?? .constant(1)
         let scale = try! resolvedScale.toJSON()
 
-        var expectedPaintLayerProperties = [LocationIndicatorLayer.PaintCodingKeys: Any]()
         expectedPaintLayerProperties[.location] = [state.coordinate.latitude, state.coordinate.longitude, 0]
         expectedPaintLayerProperties[.locationTransition] = ["duration": 0, "delay": 0]
         expectedPaintLayerProperties[.topImageSize] = scale
@@ -208,7 +208,7 @@ final class Puck2DRendererTests: XCTestCase {
         let state = updateState(with: .fullAccuracy, heading: nil, configuration: .init(topImage: nil, bearingImage: nil, shadowImage: nil))
 
         var expectedProperties = makeExpectedLayerProperties(with: state)
-        expectedProperties.removeValue(forKey: LocationIndicatorLayer.LayoutCodingKeys.bearingImage.rawValue)
+        expectedProperties.removeValue(forKey: LocationIndicatorLayer.PaintCodingKeys.bearingImage.rawValue)
         let actualProperties = try XCTUnwrap(style.addPersistentLayerWithPropertiesStub.invocations.first?.parameters.properties)
         XCTAssertEqual(actualProperties as NSDictionary, expectedProperties as NSDictionary)
     }