Avoid unnecessary navigation arrow GeoJSON updates (#9738)

Navigation arrows were updating frequently, consuming unnecessary CPU
due to frequent GeoJSON source updates. This change checks if the arrow geometry has changed before updating its GeoJSON.

GitOrigin-RevId: 17632eff128da688c62e0f1e97dcc3886a31c4ee

Author: tobrun

ui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/arrow/api/MapboxRouteArrowApi.kt

@@ -237,9 +237,7 @@ class MapboxRouteArrowApi {
 
     private fun getShaftFeatureCollection(): FeatureCollection {
         val shaftFeatures = arrows.map {
-            LineString.fromLngLats(it.points)
-        }.map {
-            Feature.fromGeometry(it)
+            Feature.fromGeometry(LineString.fromLngLats(it.points))
         }
         return FeatureCollection.fromFeatures(shaftFeatures)
     }

ui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/arrow/api/MapboxRouteArrowView.kt

@@ -48,6 +48,12 @@ class MapboxRouteArrowView(private val options: RouteArrowOptions) {
         private const val LOG_CATEGORY = "MapboxRouteArrowView"
     }
 
+    /**
+     * Keep a map of current sources (either [Feature] or [FeatureCollection]) per source id
+     * (usually [RouteLayerConstants.ARROW_SHAFT_SOURCE_ID] or [RouteLayerConstants.ARROW_HEAD_SOURCE_ID]).
+     */
+    private val currentSourceHashes = mutableMapOf<String, Int>()
+
     /**
      * Renders an [ArrowVisibilityChangeValue] applying view side effects based on the data
      * it contains.
@@ -195,14 +201,26 @@ class MapboxRouteArrowView(private val options: RouteArrowOptions) {
     }
 
     private fun updateSource(style: Style, sourceId: String, feature: Feature) {
-        if (style.styleSourceExists(sourceId)) {
-            style.getSourceAs<GeoJsonSource>(sourceId)?.feature(feature)
+        val newFeatureHash = feature.hashCode()
+        // Only update the sources if it has changed
+        if (currentSourceHashes[sourceId] != newFeatureHash) {
+            val geoJsonSource = style.getSourceAs<GeoJsonSource>(sourceId)
+            if (geoJsonSource != null) {
+                geoJsonSource.feature(feature)
+                currentSourceHashes[sourceId] = newFeatureHash
+            }
         }
     }
 
     private fun updateSource(style: Style, sourceId: String, featureCollection: FeatureCollection) {
-        if (style.styleSourceExists(sourceId)) {
-            style.getSourceAs<GeoJsonSource>(sourceId)?.featureCollection(featureCollection)
+        val newFeatureCollectionHash = featureCollection.hashCode()
+        // Only update the sources if it has changed
+        if (currentSourceHashes[sourceId] != newFeatureCollectionHash) {
+            val geoJsonSource = style.getSourceAs<GeoJsonSource>(sourceId)
+            if (geoJsonSource != null) {
+                geoJsonSource.featureCollection(featureCollection)
+                currentSourceHashes[sourceId] = newFeatureCollectionHash
+            }
         }
     }