Address review comments (#10313) (#10322)

GitOrigin-RevId: 9aa77bfa8d091e1a42e90b1a44e087dd04a74600

Author: DzmitryFomchyn

…avigation/testing/BlockingSAMCallback.kt …avigation/testing/BlockingSamCallback.ktlibtesting-utils/src/main/java/com/mapbox/navigation/testing/BlockingSAMCallback.kt renamed to libtesting-utils/src/main/java/com/mapbox/navigation/testing/BlockingSamCallback.kt libtesting-utils/src/main/java/com/mapbox/navigation/testing/BlockingSAMCallback.kt renamed to libtesting-utils/src/main/java/com/mapbox/navigation/testing/BlockingSamCallback.kt

@@ -2,7 +2,7 @@ package com.mapbox.navigation.testing
 
 import java.util.concurrent.CountDownLatch
 
-class BlockingSAMCallback<T : Any> : (T) -> Unit {
+class BlockingSamCallback<T : Any> : (T) -> Unit {
 
     private var countDownLatch = CountDownLatch(1)
     private lateinit var result: T

navigation/src/main/java/com/mapbox/navigation/core/navigator/offline/DownloadedTilesetsFetcher.kt

@@ -4,6 +4,7 @@ import com.mapbox.bindgen.Expected
 import com.mapbox.bindgen.ExpectedFactory
 import com.mapbox.common.TileStore
 import com.mapbox.navigation.utils.internal.logD
+import com.mapbox.navigation.utils.internal.logE
 import kotlinx.serialization.Serializable
 import kotlinx.serialization.decodeFromString
 import kotlinx.serialization.json.Json
@@ -159,12 +160,12 @@ internal class DownloadedTilesetsFetcher(
                 val response = jsonParser.decodeFromString<TilesetDescriptorMetadataResponse>(json)
                 response.resolved
             } catch (e: kotlinx.serialization.SerializationException) {
-                logD(TilesetVersionManagerImpl.LOG_CATEGORY) {
+                logE(TilesetVersionManagerImpl.LOG_CATEGORY) {
                     "Downloaded tilesets metadata parsing error: $e"
                 }
                 emptyList()
             } catch (e: Exception) {
-                logD(TilesetVersionManagerImpl.LOG_CATEGORY) {
+                logE(TilesetVersionManagerImpl.LOG_CATEGORY) {
                     "Downloaded tilesets metadata error: $e"
                 }
                 emptyList()

navigation/src/main/java/com/mapbox/navigation/core/navigator/offline/TilesetReleaseDateParser.kt

@@ -1,5 +1,6 @@
 package com.mapbox.navigation.core.navigator.offline
 
+import com.mapbox.navigation.utils.internal.logE
 import java.text.SimpleDateFormat
 import java.util.Date
 import java.util.Locale
@@ -11,6 +12,9 @@ internal object TilesetReleaseDateParser {
         return try {
             VERSION_NAME_DATE_FORMATTER.parse(versionName)
         } catch (e: Exception) {
+            logE(TilesetVersionManagerImpl.LOG_CATEGORY) {
+                "Unable to parse date from version name $versionName: $e"
+            }
             null
         }
     }

navigation/src/test/java/com/mapbox/navigation/core/navigator/offline/TilesetReleaseDateParserTest.kt

@@ -1,15 +1,20 @@
 package com.mapbox.navigation.core.navigator.offline
 
+import com.mapbox.navigation.testing.LoggingFrontendTestRule
 import org.junit.Assert.assertEquals
 import org.junit.Assert.assertNotNull
 import org.junit.Assert.assertNull
+import org.junit.Rule
 import org.junit.Test
 import java.text.SimpleDateFormat
 import java.util.Locale
 import java.util.TimeZone
 
 class TilesetReleaseDateParserTest {
 
+    @get:Rule
+    val loggerRule = LoggingFrontendTestRule()
+
     @Test
     fun `parseReleaseDate should parse valid version names correctly`() {
         val formatter = SimpleDateFormat("yyyy_MM_dd-HH_mm_ss", Locale.US).apply {

navigation/src/test/java/com/mapbox/navigation/core/navigator/offline/TilesetVersionManagerTest.kt

@@ -5,7 +5,7 @@ import com.mapbox.bindgen.ExpectedFactory
 import com.mapbox.common.Cancelable
 import com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI
 import com.mapbox.navigation.core.navigator.offline.TilesetVersionManager.AllTilesetsUpdatesCallback
-import com.mapbox.navigation.testing.BlockingSAMCallback
+import com.mapbox.navigation.testing.BlockingSamCallback
 import com.mapbox.navigation.testing.LoggingFrontendTestRule
 import io.mockk.CapturingSlot
 import io.mockk.every
@@ -687,7 +687,7 @@ class TilesetVersionManagerTest {
 
         fun TilesetVersionManager.getAvailableVersionsBlocking():
             Expected<Throwable, List<TilesetVersion>> {
-            val callback = BlockingSAMCallback<Expected<Throwable, List<TilesetVersion>>>()
+            val callback = BlockingSamCallback<Expected<Throwable, List<TilesetVersion>>>()
             getAvailableVersions(callback)
             return callback.getResultBlocking()
         }
@@ -758,7 +758,7 @@ class TilesetVersionManagerTest {
             regionId: String,
             maxAllowedAgeDifferenceMinutes: Long,
         ): Expected<Throwable, TilesetUpdateAvailabilityResult> {
-            val callback = BlockingSAMCallback<
+            val callback = BlockingSamCallback<
                 Expected<Throwable, TilesetUpdateAvailabilityResult>,
                 >()
             getAvailableUpdate(regionId, maxAllowedAgeDifferenceMinutes, callback)
@@ -768,7 +768,7 @@ class TilesetVersionManagerTest {
         fun TilesetVersionManager.getAvailableUpdatesBlocking(
             maxAllowedAgeDifferenceMinutes: Long,
         ): Expected<Throwable, List<TilesetUpdateAvailabilityResult.Available>> {
-            val callback = BlockingSAMCallback<
+            val callback = BlockingSamCallback<
                 Expected<Throwable, List<TilesetUpdateAvailabilityResult.Available>>,
                 >()
             getAvailableUpdates(maxAllowedAgeDifferenceMinutes, callback)

navigation/src/test/java/com/mapbox/navigation/core/navigator/offline/TilesetVersionsApiTest.kt

@@ -16,7 +16,7 @@ import com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI
 import com.mapbox.navigation.base.HttpException
 import com.mapbox.navigation.core.internal.SdkInfoProvider
 import com.mapbox.navigation.core.navigator.offline.TilesetVersionsApi.RouteTileVersionsResponse
-import com.mapbox.navigation.testing.BlockingSAMCallback
+import com.mapbox.navigation.testing.BlockingSamCallback
 import com.mapbox.navigation.testing.LoggingFrontendTestRule
 import io.mockk.CapturingSlot
 import io.mockk.every
@@ -253,7 +253,7 @@ class TilesetVersionsApiTest {
             dataset: String = "test-dataset",
             profile: String = "driving",
         ): Expected<Throwable, RouteTileVersionsResponse> {
-            val callback = BlockingSAMCallback<Expected<Throwable, RouteTileVersionsResponse>>()
+            val callback = BlockingSamCallback<Expected<Throwable, RouteTileVersionsResponse>>()
             getRouteTileVersions(
                 baseUri = baseUri,
                 dataset = dataset,