Fix unexpected camera jumps when showing the list of upcoming maneuvers (#4400)

* Fix camera jumps when showing the list of upcoming maneuvers

Author: azarovalex

CHANGELOG.md

@@ -13,6 +13,10 @@
 **Note:** The Mapbox Electronic Horizon feature of the Mapbox Navigation SDK is in public beta and is subject to changes, including its pricing. Use of the feature is subject to the beta product restrictions in the Mapbox Terms of Service. Mapbox reserves the right to eliminate any free tier or free evaluation offers at any time and require customers to place an order to purchase the Mapbox Electronic Horizon feature, regardless of the level of use of the feature.
 * Added`Interchange.identifier` and `Junction.identifier` fields. ([#4396](https://github.com/mapbox/mapbox-navigation-ios/pull/4396))
 
+### Camera
+
+* Fixes an issue where the camera's position was not calculated correctly when banners fully overlapped the map. ([#4400](https://github.com/mapbox/mapbox-navigation-ios/pull/4400))
+
 ## v2.11.0
 
 ### Packaging

Sources/MapboxNavigation/CameraController.swift

@@ -130,7 +130,17 @@ class CameraController: NavigationComponent, NavigationComponentDelegate {
 
     private func updateNavigationCameraViewport() {
         if let navigationViewportDataSource = navigationMapView.navigationCamera.viewportDataSource as? NavigationViewportDataSource {
-            navigationViewportDataSource.viewportPadding = viewportPadding
+            let newViewport = viewportPadding
+            let visibleRect = navigationMapView.mapView.bounds.inset(by: newViewport)
+
+            guard visibleRect.size.width > 0, visibleRect.size.height > 0 else {
+                // The viewport padding is bigger than the map itself,
+                // this usually means that it is being fully overlapped by one of the banners
+                // In this case, we ignore new viewport to avoid unexpected camera jumps
+                return
+            }
+
+            navigationViewportDataSource.viewportPadding = newViewport
         }
     }