Remove arrow if the route line is removed after arrival (#4040)

Author: ShanMa1991

CHANGELOG.md

@@ -13,6 +13,7 @@
 * Each alternative route shown during turn-by-turn navigation is now annotated with the amount of time it saves or adds to the trip. To hide these annotations, set the `NavigationMapView.showsRelativeDurationOnContinuousAlternativeRoutes` property to `false`. ([#3956](https://github.com/mapbox/mapbox-navigation-ios/pull/3956))
 * Fixed the issue where the route line endpoint is ahead of user location indicator on short straight-line route step when `NavigationViewController.routeLineTracksTraversal` enabled in active navigation. ([#3992](https://github.com/mapbox/mapbox-navigation-ios/pull/3992))
 * Added the ability to provide duration and completion handler while visualizing routes using `NavigationMapView.showcase(_:animated:duration:completion:)`. ([#4022](https://github.com/mapbox/mapbox-navigation-ios/pull/4022))
+* Fixed an issue where the maneuver arrow is not removed after arriving to the final destination. ([#4040](https://github.com/mapbox/mapbox-navigation-ios/pull/4040))
 
 ### CarPlay
 

Sources/MapboxNavigation/CarPlayNavigationViewController.swift

@@ -864,10 +864,14 @@ open class CarPlayNavigationViewController: UIViewController, BuildingHighlighti
         let legIndex = progress.legIndex
         let nextStep = progress.currentLegProgress.stepIndex + 1
 
-        navigationMapView?.addArrow(route: progress.route, legIndex: legIndex, stepIndex: nextStep)
         navigationMapView?.updateRouteLine(routeProgress: progress,
                                            coordinate: navigationService.router.location?.coordinate,
                                            shouldRedraw: true)
+        if navigationMapView?.routes != nil {
+            navigationMapView?.addArrow(route: progress.route, legIndex: legIndex, stepIndex: nextStep)
+        } else {
+            navigationMapView?.removeArrow()
+        }
         navigationMapView?.showWaypoints(on: progress.route, legIndex: legIndex)
     }
 

Sources/MapboxNavigation/NavigationMapView+VanishingRouteLine.swift

@@ -63,6 +63,7 @@ extension NavigationMapView {
         guard !routeProgress.routeIsComplete else {
             removeRoutes()
             removeContinuousAlternativesRoutes()
+            removeArrow()
             return
         }
 

Sources/MapboxNavigation/RouteLineController.swift

@@ -46,7 +46,8 @@ extension NavigationMapView {
             let currentLegProgress = router.routeProgress.currentLegProgress
             let nextStepIndex = currentLegProgress.stepIndex + 1
 
-            if nextStepIndex <= currentLegProgress.leg.steps.count {
+            if nextStepIndex <= currentLegProgress.leg.steps.count,
+               navigationMapView.routes != nil {
                 navigationMapView.addArrow(route: router.route, legIndex: router.routeProgress.legIndex, stepIndex: nextStepIndex)
             }
 
@@ -106,7 +107,8 @@ extension NavigationMapView {
         }
 
         private func updateMapOverlays(for routeProgress: RouteProgress) {
-            if routeProgress.currentLegProgress.followOnStep != nil {
+            if routeProgress.currentLegProgress.followOnStep != nil,
+               navigationMapView.routes != nil {
                 navigationMapView.addArrow(route: routeProgress.route,
                                            legIndex: routeProgress.legIndex,
                                            stepIndex: routeProgress.currentLegProgress.stepIndex + 1)