Skip to content

Commit ba01e71

Browse files
committed
Fix not hidden passed alternative
1 parent f2056a3 commit ba01e71

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77
* MapboxNavigationCore now requires [MapboxMaps v11.19.0-rc.1](https://github.com/mapbox/mapbox-maps-ios/releases/tag/v11.19.0-rc.1)
88
* MapboxNavigationCore now requires [MapboxNavigationNative v324.19.0-rc.1](https://github.com/mapbox/mapbox-navigation-native-ios/releases/tag/v324.19.0-rc.1)
99

10+
### Routing
11+
12+
* Fixed an issue where the passed alternative route was not hidden immediately after the deviation fork was passed.
13+
1014
## 3.19.0-beta.1
1115

1216
### Packaging

Sources/MapboxNavigationCore/Navigator/MapboxNavigator.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1654,7 +1654,7 @@ extension NavigationRoutes {
16541654
mutating func updateForkPointPassed(with status: NavigationStatus) -> Bool {
16551655
let newPassedForkPointRouteIds = Set(
16561656
status.alternativeRouteIndices
1657-
.compactMap { $0.isForkPointPassed ? $0.routeId.uuid : nil }
1657+
.compactMap { $0.isForkPointPassed ? $0.routeId.toRouteIdString() : nil }
16581658
)
16591659
let oldPassedForkPointRouteIds = Set(
16601660
allAlternativeRoutesWithIgnored

Sources/_MapboxNavigationTestHelpers/Core/AlternativeRouteMock.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,10 @@ extension AlternativeRoute {
99
mainRoute: Route = .mock(),
1010
alternativeRoute: Route = .mock(shape: .mock(delta: (0.01, -0.01))),
1111
nativeRouteAlternative: RouteAlternative? = nil,
12-
requestOptions: ResponseOptions? = nil
12+
requestOptions: ResponseOptions? = nil,
13+
routeIndex: Int = 0
1314
) -> Self {
14-
let nativeAlternative = nativeRouteAlternative ?? .mock(route: alternativeRoute)
15+
let nativeAlternative = nativeRouteAlternative ?? .mock(route: alternativeRoute, routeIndex: routeIndex)
1516
let urlString = nativeAlternative.route.getRequestUri()
1617
let requestOptions = requestOptions ?? .mock(routeOptions: .mock(string: urlString))
1718
return self.init(

Sources/_MapboxNavigationTestHelpers/NavNative/RouteInterfaceMock.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public final class RouteInterfaceMock: RouteInterface {
4343

4444
public convenience init(
4545
route: Route,
46-
routeId: String = UUID().uuidString,
46+
routeId: String? = nil,
4747
routeIndex: Int = 0
4848
) {
4949
let json = RouteInterfaceMock.makeRoutesJson(with: [route])
@@ -57,7 +57,7 @@ public final class RouteInterfaceMock: RouteInterface {
5757
}
5858

5959
public init(
60-
routeId: String = UUID().uuidString,
60+
routeId: String? = nil,
6161
responseUuid: String = UUID().uuidString,
6262
routeIndex: UInt32 = 0,
6363
responseJsonRef: DataRef = .init(data: RouteInterfaceMock.realRouteJson.data(using: .utf8)!),
@@ -71,7 +71,7 @@ public final class RouteInterfaceMock: RouteInterface {
7171
mapboxApi: MapboxAPI = .directions,
7272
directionsRouteContextRef: DataRef = DataRef(data: Data())
7373
) {
74-
self.routeId = routeId
74+
self.routeId = routeId ?? "\(responseUuid)#\(routeIndex)"
7575
self.responseUuid = responseUuid
7676
self.routeIndex = routeIndex
7777
self.responseJsonRef = responseJsonRef

0 commit comments

Comments
 (0)