Adding Kotlin lint check plugin and cleanup tweaks (#1012)

Author: Langston Smith

.editorconfig

@@ -0,0 +1,2 @@
+[*.{kt,kts}]
+indent_size=2

Makefile

@@ -6,7 +6,10 @@ MBGL_ANDROID_PLUGINS += places;plugin-places
 MBGL_ANDROID_PLUGINS += localization;plugin-localization
 
 checkstyle:
-	./gradlew checkstyle
+	./gradlew checkstyle && ./gradlew ktlintCheck
+
+kotlin-lint:
+	./gradlew ktlintCheck
 
 test:
 	./gradlew test --info

app/build.gradle

@@ -1,6 +1,7 @@
 apply plugin: 'com.android.application'
 apply plugin: 'kotlin-android'
 apply plugin: 'kotlin-kapt'
+apply plugin: "org.jlleitschuh.gradle.ktlint"
 
 android {
   compileSdkVersion androidVersions.compileSdkVersion

app/src/main/java/com/mapbox/mapboxsdk/plugins/testapp/Utils.kt

@@ -12,7 +12,6 @@ import java.io.Reader
 import java.nio.charset.Charset
 import java.util.*
 
-
 /**
  * Useful utilities used throughout the testapp.
  */

app/src/main/java/com/mapbox/mapboxsdk/plugins/testapp/activity/building/BuildingActivity.kt

@@ -43,7 +43,7 @@ class BuildingActivity : AppCompatActivity(), OnMapReadyCallback {
 
     override fun onMapReady(mapboxMap: MapboxMap) {
         this.mapboxMap = mapboxMap
-        mapboxMap.setStyle(Style.MAPBOX_STREETS){
+        mapboxMap.setStyle(Style.MAPBOX_STREETS) {
             buildingPlugin = BuildingPlugin(mapView, mapboxMap, it)
             buildingPlugin?.setMinZoomLevel(15f)
             fabBuilding.visibility = View.VISIBLE

app/src/main/java/com/mapbox/mapboxsdk/plugins/testapp/activity/ktx/maps/MapboxKtxActivity.kt

@@ -26,7 +26,7 @@ class MapboxKtxActivity : AppCompatActivity(), OnMapReadyCallback, MapboxMap.OnM
         this.mapboxMap = mapboxMap
         mapboxMap.setStyle(Style.MAPBOX_STREETS) {
             mapboxMap.addOnMapClickListener(this)
-            Toast.makeText(this,"Click on the map", Toast.LENGTH_SHORT).show()
+            Toast.makeText(this, "Click on the map", Toast.LENGTH_SHORT).show()
         }
     }
 

app/src/main/java/com/mapbox/mapboxsdk/plugins/testapp/activity/localization/LocalizationActivity.kt

@@ -172,5 +172,4 @@ class LocalizationActivity : AppCompatActivity(), OnMapReadyCallback {
         return LOCALES[index]
       }
   }
-}
-
+}

app/src/main/java/com/mapbox/mapboxsdk/plugins/testapp/activity/offline/OfflineDownloadActivity.kt

@@ -85,11 +85,11 @@ class OfflineDownloadActivity : AppCompatActivity() {
             }
 
             override fun onStartTrackingTouch(seekBar: SeekBar) {
-
+              // Empty on purpose
             }
 
             override fun onStopTrackingTouch(seekBar: SeekBar) {
-
+              // Empty on purpose
             }
         })
 
@@ -99,11 +99,11 @@ class OfflineDownloadActivity : AppCompatActivity() {
             }
 
             override fun onStartTrackingTouch(seekBar: SeekBar) {
-
+              // Empty on purpose
             }
 
             override fun onStopTrackingTouch(seekBar: SeekBar) {
-
+              // Empty on purpose
             }
         })
     }
@@ -152,8 +152,12 @@ class OfflineDownloadActivity : AppCompatActivity() {
         )
     }
 
-    private fun validCoordinates(latitudeNorth: Double, longitudeEast: Double, latitudeSouth: Double,
-                                 longitudeWest: Double): Boolean {
+    private fun validCoordinates(
+      latitudeNorth: Double,
+      longitudeEast: Double,
+      latitudeSouth: Double,
+      longitudeWest: Double
+    ): Boolean {
         if (latitudeNorth < -90 || latitudeNorth > 90) {
             return false
         } else if (longitudeEast < -180 || longitudeEast > 180) {

app/src/main/java/com/mapbox/mapboxsdk/plugins/testapp/activity/offline/OfflineUiComponentsActivity.kt

@@ -23,7 +23,9 @@ class OfflineUiComponentsActivity : AppCompatActivity() {
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.activity_offline_ui_components)
-        fabRegionSelector.setOnClickListener{onOfflineRegionSelectorButtonClicked()}
+        fabRegionSelector.setOnClickListener {
+          onOfflineRegionSelectorButtonClicked()
+        }
     }
 
     fun onOfflineRegionSelectorButtonClicked() {

app/src/main/java/com/mapbox/mapboxsdk/plugins/testapp/activity/places/PickerLauncherActivity.kt

@@ -4,16 +4,13 @@ import android.app.Activity
 import android.content.Intent
 import android.os.Bundle
 import android.support.v7.app.AppCompatActivity
-import android.widget.Switch
 import android.widget.Toast
-
 import com.mapbox.mapboxsdk.Mapbox
 import com.mapbox.mapboxsdk.camera.CameraPosition
 import com.mapbox.mapboxsdk.geometry.LatLng
 import com.mapbox.mapboxsdk.plugins.places.picker.PlacePicker
 import com.mapbox.mapboxsdk.plugins.places.picker.model.PlacePickerOptions
 import com.mapbox.mapboxsdk.plugins.testapp.R
-
 import kotlinx.android.synthetic.main.activity_picker_launcher.*
 
 class PickerLauncherActivity : AppCompatActivity() {