Update the icon offset imediately when first loaded. (#310)

Author: Cameron Mace

app/src/androidTest/java/com/mapbox/mapboxsdk/plugins/locationlayer/LocationLayerTest.java

@@ -8,6 +8,8 @@
 import android.support.test.rule.ActivityTestRule;
 import android.support.test.runner.AndroidJUnit4;
 
+import com.mapbox.mapboxsdk.camera.CameraPosition;
+import com.mapbox.mapboxsdk.camera.CameraUpdateFactory;
 import com.mapbox.mapboxsdk.constants.Style;
 import com.mapbox.mapboxsdk.maps.MapboxMap;
 import com.mapbox.mapboxsdk.plugins.testapp.activity.location.LocationLayerModesActivity;
@@ -16,6 +18,7 @@
 import com.mapbox.mapboxsdk.utils.OnMapReadyIdlingResource;
 
 import org.junit.After;
+import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
@@ -204,6 +207,18 @@ public void onLocationLayerAction(LocationLayerPlugin locationLayerPlugin, Mapbo
       }});
   }
 
+  @Test
+  public void whenMapCameraInitializesTilted_iconsGetPlacedWithCorrectOffset() throws Exception {
+    executeLocationLayerTest((locationLayerPlugin, mapboxMap, uiController, context) -> {
+      mapboxMap.moveCamera(CameraUpdateFactory.newCameraPosition(new CameraPosition.Builder().tilt(60).build()));
+      locationLayerPlugin.setLocationLayerEnabled(LocationLayerMode.TRACKING);
+      locationLayerPlugin.forceLocationUpdate(location);
+      SymbolLayer layer = mapboxMap.getLayerAs(FOREGROUND_LAYER);
+      Float[] value = layer.getIconOffset().getValue();
+      Assert.assertEquals((-0.05 * 60), value[1], 0.1);
+    });
+  }
+
   @After
   public void afterTest() {
     Timber.e("@After: unregister idle resource");

plugin-locationlayer/src/main/java/com/mapbox/mapboxsdk/plugins/locationlayer/LocationLayerPlugin.java

@@ -162,6 +162,10 @@ public void setLocationLayerEnabled(@LocationLayerMode.Mode int locationLayerMod
         locationEngine.addLocationEngineListener(this);
       }
 
+      // On Camera move is called here so that the layer icon offsets adjusted properly when the
+      // maps initially tilted.
+      onCameraMove();
+
       toggleCameraListener();
 
       if (locationLayerMode == LocationLayerMode.COMPASS) {