branch SDK3 V3.06 When using TransformBasedTileProvider setting position via MapInformation.SetInformation does not always update VectorLayerModule correctly

[tapycha]

If you are using TransformBasedTileProvider(didn't test with other stuff) and set a new coordinate via MapInformation.SetInformation VectorLayerModule doesn't update the position of tiles.
For StaticApiLayerModule, if you move the MapInformation latitude and longitude a bit, the tile will update its position. If you move far, the tiles respawn. This is ok!
For VectorLayerModule, if you move the MapInformation latitude and longitude a bit, the tile will not update its position. If you move far, the tiles respawn. This is not ok!
I "think" StaticApiLayerModule works fine cause of MapboxMapVisualizer ->Load -> ShowTile calls for IMapInformation.PositionObjectFor, Load is called every frame and that updates the tile position. VectorLayerModule doesn't have that sort of update. The crude way to fix this is to add the same IMapInformation.PositionObjectFor inside VectorLayerVisualizer -> SetActive

        public void SetActive(CanonicalTileId canonicalTileId, bool isActive, IMapInformation mapInformation)
        {
            if (isActive)
            {
                if (_results.TryGetValue(canonicalTileId, out var visuals))
                {
                    foreach (var entity in visuals)
                    {
                        if (_stackList.TryGetValue(entity.StackId, out var stack))
                        {
                            var isVisible = stack.IsZinSupportedRange(_mapInformation.AbsoluteZoom);
                            entity.GameObject.SetActive(isVisible);
                            _mapInformation.PositionObjectFor(entity.GameObject, canonicalTileId);
                        }
                    }
                }
            }
            else
            {
                UnregisterTile(canonicalTileId);
            }
        }

But it would update every frame, which could impact performance. I think a better approach would be to tie most of the calls to IMapInformation.PositionObjectFor via IMapInformation.LatitudeLongitudeChanged and IMapInformation.WorldScaleChanged, so they don't happen every single frame. (Sorry, don't have time to write a full PR with this idea)

[brnkhy]

@tapycha I'll look into this as soon as possible. if I remember correct vector module was handling those stuff little messy; for example while other systems load tile on retain tile pass and create visuals on load tile pass, vector module does it vice versa.
there's also the general issue where user triggering updates and necessary system updates being tied together (and should be separated).
Is this blocking you at the moment or do you have a working hack around it?

[tapycha]

Hi, this doesn't block me, as I did the crude way described above to fix this for now, just letting you know about the issue.

[brnkhy]

@tapycha I think this is actually a bug more than a design issue and I was under the impression I fixed this before but maybe it got lost somewhere.
The problem is, positioning updates are registered to scale changed but not to view changes. You can see this on MapboxMapVisualizer line 47.
And if you add the other one as well, behaviour should be fixed;

_mapInformation.WorldScaleChanged += RepositionAllTiles;
_mapInformation.ViewChanged += RepositionAllTiles;

I'll investigate a little more and create a fix branch soon.

Edit: too late I noticed you wrote pretty much same thing above.

this works much better;

_mapInformation.WorldScaleChanged += RepositionAllTiles;
_mapInformation.LatitudeLongitudeChanged += RepositionAllTiles;