Skip to content

Commit eb4c210

Browse files
[skills] Address PR feedback - remove non-existent file references and improve token management consistency
1 parent ba33a12 commit eb4c210

File tree

3 files changed

+6
-16
lines changed

3 files changed

+6
-16
lines changed

skills/mapbox-cartography/SKILL.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -310,12 +310,6 @@ Attribution: 8-9px
310310
7. **Neglecting performance**: Complex styles slow rendering
311311
8. **Forgetting mobile**: Test on actual devices
312312

313-
## Resources in This Skill
314-
315-
- See [COLOR_PALETTES.md](COLOR_PALETTES.md) for extended palette library
316-
- See [TYPOGRAPHY_GUIDE.md](TYPOGRAPHY_GUIDE.md) for advanced typography
317-
- See [ACCESSIBILITY_CHECKLIST.md](ACCESSIBILITY_CHECKLIST.md) for WCAG compliance
318-
319313
## When to Use This Skill
320314

321315
Invoke this skill when:

skills/mapbox-integration-patterns/SKILL.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,15 @@ npm install @mapbox/search-js-web@^1.0.0 # Other frameworks
8484
**Example:**
8585

8686
```javascript
87+
const token = import.meta.env.VITE_MAPBOX_ACCESS_TOKEN; // Use env vars in production
88+
8789
// v2.x pattern (still works in v3.x)
88-
mapboxgl.accessToken = 'pk...';
90+
mapboxgl.accessToken = token;
8991
const map = new mapboxgl.Map({ container: '...' });
9092

9193
// v3.x pattern (preferred)
9294
const map = new mapboxgl.Map({
93-
accessToken: 'pk...',
95+
accessToken: token,
9496
container: '...'
9597
});
9698
```
@@ -111,6 +113,8 @@ const map = new mapboxgl.Map({
111113

112114
**Pattern: useRef + useEffect with cleanup**
113115

116+
> **Note:** These examples use **Vite** (the bundler used in `create-web-app`). If using Create React App, replace `import.meta.env.VITE_MAPBOX_ACCESS_TOKEN` with `process.env.REACT_APP_MAPBOX_TOKEN`. See the [Token Management Patterns](#token-management-patterns) section for other bundlers.
117+
114118
```jsx
115119
import { useRef, useEffect } from 'react';
116120
import mapboxgl from 'mapbox-gl';

skills/mapbox-token-security/SKILL.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -486,14 +486,6 @@ MAPBOX_SECRET_TOKEN=sk.eyJ1IjoiZXhhbXBsZSI...
486486
- [ ] Post-incident review template
487487
- [ ] Team training on security procedures
488488

489-
## Resources in This Skill
490-
491-
For additional security information:
492-
493-
- See [SCOPE_REFERENCE.md](SCOPE_REFERENCE.md) for complete scope catalog
494-
- See [COMPLIANCE_GUIDE.md](COMPLIANCE_GUIDE.md) for regulatory requirements
495-
- See [INCIDENT_TEMPLATE.md](INCIDENT_TEMPLATE.md) for response procedures
496-
497489
## When to Use This Skill
498490

499491
Invoke this skill when:

0 commit comments

Comments
 (0)