speculative fix for appeasing GCC's bounds checker

Author: kkaefer

.github/workflows/clang-tidy.yml

@@ -33,6 +33,7 @@ jobs:
           apt-get install -yq \
             clang-${{ matrix.clang }} \
             clang-tidy-${{ matrix.clang }} \
+            libstdc++-dev \
             cmake \
             libprotobuf-dev \
             make \

include/protozero/varint.hpp

@@ -32,13 +32,11 @@ namespace detail {
 
     // from https://github.com/facebook/folly/blob/master/folly/Varint.h
     inline uint64_t decode_varint_impl(const char** data, const char* end) {
-        const auto* begin = reinterpret_cast<const int8_t*>(*data);
-        const auto* iend = reinterpret_cast<const int8_t*>(end);
-        const int8_t* p = begin;
+        const int8_t* p = reinterpret_cast<const int8_t*>(*data);
+        const int8_t* const iend = reinterpret_cast<const int8_t*>(end);
         uint64_t val = 0;
 
-        if (iend - begin >= max_varint_length) {  // fast path
-            assert(iend - p >= max_varint_length); // help Clang analyzer
+        if (iend - p >= max_varint_length) {  // fast path
             do {
                 int64_t b = *p++;
                           val  = ((static_cast<uint64_t>(b) & 0x7fU)       ); if (b >= 0) { break; }