basic_pbf_builder constructor can not be noexcept

joto · joto · commit 4cd16396a50a · 2024-12-19T16:41:58.000+01:00
Because the class is derived from parent basic_pbf_writer and uses a
non-noexcept constructor of that class.
diff --git a/include/protozero/basic_pbf_builder.hpp b/include/protozero/basic_pbf_builder.hpp
@@ -67,7 +67,7 @@ class basic_pbf_builder : public basic_pbf_writer<TBuffer> {
      * @param tag Tag of the field that will be written
      */
     template <typename P>
-    basic_pbf_builder(basic_pbf_writer<TBuffer>& parent_writer, P tag) noexcept :
+    basic_pbf_builder(basic_pbf_writer<TBuffer>& parent_writer, P tag) :
         basic_pbf_writer<TBuffer>{parent_writer, pbf_tag_type(tag)} {
     }
 

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ class basic_pbf_builder : public basic_pbf_writer<TBuffer> {`
`67`	`67`	`* @param tag Tag of the field that will be written`
`68`	`68`	`*/`
`69`	`69`	`template <typename P>`
`70`		`- basic_pbf_builder(basic_pbf_writer<TBuffer>& parent_writer, P tag) noexcept :`
	`70`	`+ basic_pbf_builder(basic_pbf_writer<TBuffer>& parent_writer, P tag) :`
`71`	`71`	`basic_pbf_writer<TBuffer>{parent_writer, pbf_tag_type(tag)} {`
`72`	`72`	`}`
`73`	`73`