Fix CQS signal cppcoreguidelines-pro-type-member-init in fbcode/mapillary/opensfm

Differential Revision: D89353241

fbshipit-source-id: 5150f66460bcc83775bec32b778410ff84afb613

Author: generatedunixname89002005287564

opensfm/src/bundle/reconstruction_alignment.h

@@ -36,8 +36,8 @@ enum {
 
 struct RAShot {
   std::string id;
-  double parameters[RA_SHOT_NUM_PARAMS];
-  bool constant;
+  double parameters[RA_SHOT_NUM_PARAMS]{};
+  bool constant{};
 
   double GetRX() { return parameters[RA_SHOT_RX]; }
   double GetRY() { return parameters[RA_SHOT_RY]; }
@@ -55,8 +55,8 @@ struct RAShot {
 
 struct RAReconstruction {
   std::string id;
-  double parameters[RA_RECONSTRUCTION_NUM_PARAMS];
-  bool constant;
+  double parameters[RA_RECONSTRUCTION_NUM_PARAMS]{};
+  bool constant{};
 
   double GetRX() { return parameters[RA_RECONSTRUCTION_RX]; }
   double GetRY() { return parameters[RA_RECONSTRUCTION_RY]; }
@@ -110,8 +110,8 @@ struct RARelativeMotionConstraint {
 
   std::string reconstruction_id;
   std::string shot_id;
-  double parameters[RA_SHOT_NUM_PARAMS];
-  double scale_matrix[RA_SHOT_NUM_PARAMS * RA_SHOT_NUM_PARAMS];
+  double parameters[RA_SHOT_NUM_PARAMS]{};
+  double scale_matrix[RA_SHOT_NUM_PARAMS * RA_SHOT_NUM_PARAMS]{};
 };
 
 struct RAAbsolutePositionConstraint {
@@ -420,7 +420,7 @@ class ReconstructionAlignment {
 
   void AddAbsolutePositionConstraint(const std::string& shot_id, double x,
                                      double y, double z, double std_deviation) {
-    RAAbsolutePositionConstraint a;
+    RAAbsolutePositionConstraint a{};
     a.shot = &shots_[shot_id];
     a.position[0] = x;
     a.position[1] = y;
@@ -432,7 +432,7 @@ class ReconstructionAlignment {
   void AddRelativeAbsolutePositionConstraint(
       const std::string& reconstruction_id, const std::string& shot_id,
       double x, double y, double z, double std_deviation) {
-    RARelativeAbsolutePositionConstraint a;
+    RARelativeAbsolutePositionConstraint a{};
     a.reconstruction = &reconstructions_[reconstruction_id];
     a.shot = &shots_[shot_id];
     a.position[0] = x;
@@ -447,7 +447,7 @@ class ReconstructionAlignment {
                                 const std::string& reconstruction_b_id,
                                 double xb, double yb, double zb,
                                 double std_deviation) {
-    RACommonPointConstraint c;
+    RACommonPointConstraint c{};
     c.reconstruction_a = &reconstructions_[reconstruction_a_id];
     c.point_a[0] = xa;
     c.point_a[1] = ya;
@@ -466,7 +466,7 @@ class ReconstructionAlignment {
                                  const std::string& shot_b_id,
                                  double std_deviation_center,
                                  double std_deviation_rotation) {
-    RACommonCameraConstraint c;
+    RACommonCameraConstraint c{};
     c.reconstruction_a = &reconstructions_[reconstruction_a_id];
     c.shot_a = &shots_[shot_a_id];
     c.reconstruction_b = &reconstructions_[reconstruction_b_id];

opensfm/src/bundle/test/reprojection_errors_test.cc

@@ -20,8 +20,8 @@ class ReprojectionError2DFixtureBase : public ::testing::Test {
   AScalar residual_adiff[size_residual];
   AScalar point_adiff[size_point];
 
-  double residuals[size_residual];
-  double jac_point[size_residual * size_point];
+  double residuals[size_residual]{};
+  double jac_point[size_residual * size_point]{};
 };
 
 class ReprojectionError2DFixture : public ReprojectionError2DFixtureBase {
@@ -104,11 +104,11 @@ class ReprojectionError2DFixture : public ReprojectionError2DFixtureBase {
 
   const double rt_instance[size_rt] = {0.1, 0.2, 0.3, 0.4, 0.5, 0.6};
   AScalar rt_instance_adiff[size_rt];
-  double jac_rt_instance[size_residual * size_rt];
+  double jac_rt_instance[size_residual * size_rt]{};
 
   const double rt_camera[size_rt] = {0.1, 0.2, 0.3, 0.4, 0.5, 0.6};
   AScalar rt_camera_adiff[size_rt];
-  double jac_rt_camera[size_residual * size_rt];
+  double jac_rt_camera[size_residual * size_rt]{};
 };
 
 TEST_F(ReprojectionError2DFixture, BrownAnalyticErrorEvaluatesOK) {
@@ -234,10 +234,10 @@ class ReprojectionError3DFixture : public ::testing::Test {
   AScalar rt_instance_adiff[size_rt];
   AScalar rt_camera_adiff[size_rt];
 
-  double residuals[size];
-  double jac_instance_rt[size * size_rt];
-  double jac_camera_rt[size * size_rt];
-  double jac_point[size * size_point];
+  double residuals[size]{};
+  double jac_instance_rt[size * size_rt]{};
+  double jac_camera_rt[size * size_rt]{};
+  double jac_point[size * size_point]{};
 };
 
 TEST_F(ReprojectionError3DFixture, AnalyticErrorEvaluatesOK) {

opensfm/src/geometry/absolute_pose.h

@@ -76,7 +76,7 @@ std::vector<Eigen::Matrix<double, 3, 4>> AbsolutePoseThreePoints(IT begin,
   const auto alpha0 = SQUARE(g7) - SQUARE(g2) - SQUARE(g4);
 
   std::array<double, 5> coefficients = {alpha0, alpha1, alpha2, alpha3, alpha4};
-  std::array<double, 4> roots;
+  std::array<double, 4> roots{};
   const auto solve_result = foundation::SolveQuartic(coefficients, roots);
   if (!solve_result) {
     return RTs;

opensfm/src/geometry/camera_distortions_functions.h

@@ -465,7 +465,7 @@ struct Disto62 : Functor<2, 8, 2> {
 
     Mat2<T> derivative(const Vec2<T>& point) const {
       Mat2<T> jacobian;
-      std::array<double, 2> dummy;
+      std::array<double, 2> dummy{};
       std::array<double, 8> ks{k1, k2, k3, k4, k5, k6, p1, p2};
       Disto62::ForwardDerivatives<T, false>(point.data(), ks.data(),
                                             dummy.data(), jacobian.data());
@@ -683,7 +683,7 @@ struct Disto624 : Functor<2, 12, 2> {
 
     Mat2<T> derivative(const Vec2<T>& point) const {
       Mat2<T> jacobian;
-      std::array<double, 2> dummy;
+      std::array<double, 2> dummy{};
       std::array<double, 12> ks{k1, k2, k3, k4, k5, k6, p1, p2, s0, s1, s2, s3};
       Disto624::ForwardDerivatives<T, false>(point.data(), ks.data(),
                                              dummy.data(), jacobian.data());
@@ -815,7 +815,7 @@ struct DistoBrown : Functor<2, 5, 2> {
 
     Mat2<T> derivative(const Vec2<T>& point) const {
       Mat2<T> jacobian;
-      std::array<double, 2> dummy;
+      std::array<double, 2> dummy{};
       std::array<double, 5> ks{k1, k2, k3, p1, p2};
       DistoBrown::ForwardDerivatives<T, false>(point.data(), ks.data(),
                                                dummy.data(), jacobian.data());

opensfm/src/geometry/test/camera_functions_test.cc

@@ -302,13 +302,13 @@ class CameraDerivativesFixture : public ::testing::Test {
   Vec2d distortion_radial;
   Vec2d principal_point;
 
-  double point[3];
+  double point[3]{};
   using AScalar = Eigen::AutoDiffScalar<VecXd>;
   AScalar point_adiff[3];
   VecX<AScalar> camera_adiff;
 
   AScalar projection_expected[2];
-  double projected[2];
+  double projected[2]{};
 };
 
 TEST_F(CameraDerivativesFixture, ComputePerspectiveAnalyticalDerivatives) {

opensfm/src/geometry/test/camera_test.cc

@@ -62,8 +62,8 @@ class CameraFixture : public ::testing::Test {
   Vec2d distortion_radial;
   Vec2d principal_point;
 
-  double point[3];
-  double projected[2];
+  double point[3]{};
+  double projected[2]{};
 };
 
 TEST_F(CameraFixture, PerspectiveIsConsistent) {

opensfm/src/geometry/test/covariance_test.cc

@@ -66,7 +66,7 @@ class CovarianceFixture : public ::testing::Test {
   }
 
   const double focal{1.0};
-  double point[3];
+  double point[3]{};
   using AScalar = Eigen::AutoDiffScalar<VecXd>;
   AScalar point_adiff[3];
   AScalar projection_expected[2];

opensfm/src/map/observation.h

@@ -43,8 +43,8 @@ struct Observation {
   int feature_id{0};
 
   // Optional data : semantics
-  int segmentation_id;
-  int instance_id;
+  int segmentation_id{};
+  int instance_id{};
 
   // Optional data : depth prior
   std::optional<Depth> depth_prior;