Skip to content

Commit 0269d04

Browse files
committed
introduce env MAPILLARY_TOOLS__DISABLE_AUTH_VERIFICATION
1 parent 6b2c2f5 commit 0269d04

File tree

3 files changed

+25
-7
lines changed

3 files changed

+25
-7
lines changed

mapillary_tools/authenticate.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def authenticate(
6464

6565
if jwt:
6666
user_items: types.UserItem = {"user_upload_token": jwt}
67-
user_items = _authenticate_profile(_validate_profile(user_items))
67+
user_items = _verify_user_auth(_validate_profile(user_items))
6868
else:
6969
user_items = _prompt_login(
7070
user_email=user_email, user_password=user_password
@@ -128,7 +128,7 @@ def fetch_user_items(
128128

129129
assert profile_name is not None, "profile_name should be set"
130130

131-
user_items = _authenticate_profile(_validate_profile(user_items))
131+
user_items = _verify_user_auth(_validate_profile(user_items))
132132

133133
LOG.info(
134134
'Uploading to profile "%s": %s', profile_name, api_v4._sanitize(user_items)
@@ -164,7 +164,13 @@ def _validate_profile(user_items: types.UserItem) -> types.UserItem:
164164
return user_items
165165

166166

167-
def _authenticate_profile(user_items: types.UserItem) -> types.UserItem:
167+
def _verify_user_auth(user_items: types.UserItem) -> types.UserItem:
168+
"""
169+
Verify that the user access token is valid
170+
"""
171+
if constants._DISABLE_AUTH_VERIFICATION:
172+
return user_items
173+
168174
try:
169175
resp = api_v4.fetch_user_or_me(
170176
user_access_token=user_items["user_upload_token"]

mapillary_tools/constants.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,3 +61,11 @@
6161
"TRUE",
6262
"YES",
6363
]
64+
65+
_DISABLE_AUTH_VERIFICATION = os.getenv(
66+
_ENV_PREFIX + "_DISABLE_AUTH_VERIFICATION", "NO"
67+
).upper() in [
68+
"1",
69+
"TRUE",
70+
"YES",
71+
]

tests/integration/fixtures.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
def setup_config(tmpdir: py.path.local):
2929
config_path = tmpdir.mkdir("configs").join("CLIENT_ID")
3030
os.environ["MAPILLARY_CONFIG_PATH"] = str(config_path)
31+
os.environ["MAPILLARY_TOOLS__DISABLE_AUTH_VERIFICATION"] = "YES"
3132
x = subprocess.run(
3233
f"{EXECUTABLE} authenticate --user_name {USERNAME} --jwt test_user_token",
3334
shell=True,
@@ -36,7 +37,8 @@ def setup_config(tmpdir: py.path.local):
3637
yield config_path
3738
if tmpdir.check():
3839
tmpdir.remove(ignore_errors=True)
39-
del os.environ["MAPILLARY_CONFIG_PATH"]
40+
os.environ.pop("MAPILLARY_CONFIG_PATH", None)
41+
os.environ.pop("MAPILLARY_TOOLS__DISABLE_AUTH_VERIFICATION", None)
4042

4143

4244
@pytest.fixture
@@ -53,15 +55,17 @@ def setup_data(tmpdir: py.path.local):
5355
def setup_upload(tmpdir: py.path.local):
5456
upload_dir = tmpdir.mkdir("mapillary_public_uploads")
5557
os.environ["MAPILLARY_UPLOAD_PATH"] = str(upload_dir)
58+
os.environ["MAPILLARY_TOOLS__DISABLE_AUTH_VERIFICATION"] = "YES"
5659
os.environ["MAPILLARY__ENABLE_UPLOAD_HISTORY_FOR_DRY_RUN"] = "YES"
5760
history_path = tmpdir.join("history")
5861
os.environ["MAPILLARY_UPLOAD_HISTORY_PATH"] = str(history_path)
5962
yield upload_dir
6063
if tmpdir.check():
6164
tmpdir.remove(ignore_errors=True)
62-
del os.environ["MAPILLARY_UPLOAD_PATH"]
63-
del os.environ["MAPILLARY_UPLOAD_HISTORY_PATH"]
64-
del os.environ["MAPILLARY__ENABLE_UPLOAD_HISTORY_FOR_DRY_RUN"]
65+
os.environ.pop("MAPILLARY_UPLOAD_PATH", None)
66+
os.environ.pop("MAPILLARY_UPLOAD_HISTORY_PATH", None)
67+
os.environ.pop("MAPILLARY_TOOLS__DISABLE_AUTH_VERIFICATION", None)
68+
os.environ.pop("MAPILLARY__ENABLE_UPLOAD_HISTORY_FOR_DRY_RUN", None)
6569

6670

6771
def _ffmpeg_installed():

0 commit comments

Comments
 (0)