Add updateable support for GeoJSON-VT (#7172)

* experimental updateable

* comment

* result, filter, example

* tests - use spread syntax

* brainstorm cluster update

* pass cluster boolean

* filter predicate

* request data

* total disaster

* Updateable geojsonvt non experimental (#7176)

* Remove experimental

* Reduce diff

* Code simplification

* Remove parameters from getdata

* Fix test

* Fix tests

* Bring back commented out code

* Fix lint

* Remove getData

* Remove supercluster types, update bundle json

* Fix hardcoded clip start and end parameters

* This time for real.

* Fix missing cluster options, add image.

* Use defines from geojson-vt package.

* image, changelog

* demo code reviews

* getData and test

* hardcode updateable

* misc changes

* Addmore test coverage

* Fix lint

---------

Co-authored-by: wayofthefuture <wayofthefuture@users.noreply.github.com>
Co-authored-by: Harel M <harel.mazor@gmail.com>

Author: wayofthefuture

CHANGELOG.md

@@ -2,8 +2,9 @@
 
 ### ✨ Features and improvements
 - Add Etag unmodified support to optimize vector tile reloading ([#7074](https://github.com/maplibre/maplibre-gl-js/pull/7074)) (by [@rivkamatan](https://github.com/rivkamatan and [@wayofthefuture](https://github.com/wayofthefuture))
-- _...Add new stuff here..._
 - Add `boxZoom.boxZoomEnd` option to customize the action after Shift-drag box selection ([#6397](https://github.com/maplibre/maplibre-gl-js/issues/6397))
+- Add updateable support for GeoJSON-VT ([#7172](https://github.com/maplibre/maplibre-gl-js/issues/7172)) (by [@wayofthefuture](https://github.com/wayofthefuture) and [HarelM](https://github.com/HarelM))
+- _...Add new stuff here..._
 
 ### 🐞 Bug fixes
 - _...Add new stuff here..._

docs/assets/examples/update-geojson-polygons.png

@@ -17,27 +17,24 @@
   "types": "dist/maplibre-gl.d.ts",
   "type": "module",
   "dependencies": {
-    "@mapbox/geojson-rewind": "^0.5.2",
     "@mapbox/jsonlint-lines-primitives": "^2.0.2",
     "@mapbox/point-geometry": "^1.1.0",
     "@mapbox/tiny-sdf": "^2.0.7",
     "@mapbox/unitbezier": "^0.0.1",
     "@mapbox/vector-tile": "^2.0.4",
     "@mapbox/whoots-js": "^3.1.0",
-    "@maplibre/geojson-vt": "^5.0.4",
+    "@maplibre/geojson-vt": "^6.0.1",
     "@maplibre/maplibre-gl-style-spec": "^24.6.0",
     "@maplibre/mlt": "^1.1.6",
     "@maplibre/vt-pbf": "^4.3.0",
     "@types/geojson": "^7946.0.16",
-    "@types/supercluster": "^7.1.3",
     "earcut": "^3.0.2",
     "gl-matrix": "^3.4.4",
     "kdbush": "^4.0.2",
     "murmurhash-js": "^1.0.0",
     "pbf": "^4.0.1",
     "potpack": "^2.1.0",
     "quickselect": "^3.0.0",
-    "supercluster": "^8.0.1",
     "tinyqueue": "^3.0.0"
   },
   "devDependencies": {

package-lock.json

@@ -1,5 +1,5 @@
 import {LineLayoutArray, LineExtLayoutArray} from '../array_types.g';
-
+import {GEOJSONVT_CLIP_END, GEOJSONVT_CLIP_START} from '@maplibre/geojson-vt';
 import {members as layoutAttributes} from './line_attributes';
 import {members as layoutAttributesExt} from './line_attributes_ext';
 import {SegmentVector} from '../segment';
@@ -12,6 +12,7 @@ import {hasPattern, addPatternDependencies} from './pattern_bucket_features';
 import {loadGeometry} from '../load_geometry';
 import {toEvaluationFeature} from '../evaluation_feature';
 import {EvaluationParameters} from '../../style/evaluation_parameters';
+import {subdivideVertexLine} from '../../render/subdivision';
 
 import type {CanonicalTileID} from '../../tile/tile_id';
 import type {
@@ -24,16 +25,15 @@ import type {
 import type {LineStyleLayer} from '../../style/style_layer/line_style_layer';
 import type Point from '@mapbox/point-geometry';
 import type {Segment} from '../segment';
-import {type RGBAImage} from '../../util/image';
+import type {RGBAImage} from '../../util/image';
 import type {Context} from '../../gl/context';
 import type {Texture} from '../../render/texture';
 import type {IndexBuffer} from '../../gl/index_buffer';
 import type {VertexBuffer} from '../../gl/vertex_buffer';
 import type {FeatureStates} from '../../source/source_state';
 import type {ImagePosition} from '../../render/image_atlas';
-import {subdivideVertexLine} from '../../render/subdivision';
 import type {SubdivisionGranularitySetting} from '../../render/subdivision_granularity_settings';
-import {type DashEntry} from '../../render/line_atlas';
+import type {DashEntry} from '../../render/line_atlas';
 import type {VectorTileLayerLike} from '@maplibre/vt-pbf';
 
 // NOTE ON EXTRUDE SCALE:
@@ -247,9 +247,9 @@ export class LineBucket implements Bucket {
     }
 
     lineFeatureClips(feature: BucketFeature): LineClips | undefined {
-        if (!!feature.properties && Object.prototype.hasOwnProperty.call(feature.properties, 'mapbox_clip_start') && Object.prototype.hasOwnProperty.call(feature.properties, 'mapbox_clip_end')) {
-            const start = +feature.properties['mapbox_clip_start'];
-            const end = +feature.properties['mapbox_clip_end'];
+        if (!!feature.properties && Object.prototype.hasOwnProperty.call(feature.properties, GEOJSONVT_CLIP_START) && Object.prototype.hasOwnProperty.call(feature.properties, GEOJSONVT_CLIP_END)) {
+            const start = +feature.properties[GEOJSONVT_CLIP_START];
+            const end = +feature.properties[GEOJSONVT_CLIP_END];
             return {start, end};
         }
     }