Supported Node Version?

[astridx]

I'm doing my first steps with Maplibre and I'm not sure which Node version is recommended. Am I reading over this in the documentation? I'm using v10.23.0 because I had problems with 12 and 14. Am I doing something wrong or are the newer versions not supported yet?

[HarelM]

I'm using 14 with no issues except the known ones (running npm start fails due to still existing mapbox token request, there's an open PR on this).
What exactly isn't working? Does it work in 10 and not in 12 and 14?

[astridx]

Thank you @HarelM

Unfortunately, I didn't remember the exact error message and now I can't reproduce it. It was something like npm ERR! Unexpected token < in JSON at position .... I then read on the internet that it could be due to an incorrect node version. So I tested different ones.

Because I now knew from you that it also works under version 14, I called this and now it worked.

$ nvm use 14
Now using node v14.16.0 (npm v7.6.2)
$ git/maplibre/maplibre-gl-js$ rm -rf node_modules
$ maplibre/maplibre-gl-js$ rm package-lock.json
$ maplibre/maplibre-gl-js$ npm cache verify

I had read this in the package.json and thought that it might not be up to date.

  "engines": {
    "node": ">=6.4.0"
  },

However, it was my fault.

[astridx]

But I have many warnings. Is this OK or is there another problem in my installation?

npm i
npm WARN deprecated @types/[email protected]: This is a stub types definition. vfile-message provides its own type definitions, so you do not need this installed.
npm WARN deprecated [email protected]: This is not needed anymore. Use `require('os').homedir()` instead.
npm WARN deprecated [email protected]: Please update to ini >=1.3.6 to avoid a prototype pollution issue
npm WARN deprecated [email protected]: request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: This module has been deprecated and is no longer maintained. Please use @rollup/plugin-buble.
npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated [email protected]: This module has moved and is now available at @rollup/plugin-replace. Please update your dependencies. This version is no longer maintained.
npm WARN deprecated [email protected]: This module has been deprecated and is no longer maintained. Please use @rollup/plugin-json.
npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
npm WARN deprecated [email protected]: Deprecated due to CVE-2021-21366 resolved in 0.5.0
npm WARN deprecated [email protected]: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated [email protected]: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated [email protected]: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated [email protected]: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated [email protected]: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated [email protected]: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated [email protected]: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated [email protected]: Package no longer supported. Contact [email protected] for more info.
npm WARN deprecated @mapbox/[email protected]: Please make plans to check GeoJSON in some other way
npm WARN deprecated [email protected]: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-commonjs.
npm WARN deprecated [email protected]: Please upgrade to @mapbox/node-pre-gyp: the non-scoped node-pre-gyp package is deprecated and only the @mapbox scoped package will recieve updates in the future
npm WARN deprecated [email protected]: Version no longer supported. Upgrade to @latest
npm WARN deprecated [email protected]: This package has moved to the @mapbox namespace. All new version are available via @mapbox/mapbox-gl-styles

added 1883 packages, and audited 2021 packages in 7m

84 packages are looking for funding
  run `npm fund` for details

62 vulnerabilities (13 low, 15 moderate, 31 high, 3 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

[astridx]

And now I can also reproduce the error. It did not occur during npm i, but during the tests.

npm run test

> [email protected] test
> run-s lint lint-css lint-docs test-flow test-unit


> [email protected] lint
> eslint --cache --ignore-path .gitignore src test bench build debug/*.html


> [email protected] lint-css
> stylelint 'src/css/maplibre-gl.css'


> [email protected] lint-docs
> documentation lint src/index.js

Browserslist: caniuse-lite is outdated. Please run the following command: `npx browserslist --update-db`

> [email protected] test-flow
> cross-env build/run-node build/generate-flow-typed-style-spec && flow .

$maplibre/maplibre-gl-js/node_modules/@mapbox/flow-remove-types/index.js:1
SyntaxError: Error parsing $maplibre/maplibre-gl-js/node_modules/babylon/package.json: Unexpected token , in JSON at position 726
    at JSON.parse (<anonymous>) {
  path: '$maplibre/maplibre-gl-js/node_modules/babylon/package.json'
}
npm ERR! code 1
npm ERR! path $maplibre/maplibre-gl-js
npm ERR! command failed
npm ERR! command sh -c cross-env build/run-node build/generate-flow-typed-style-spec && flow .

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/astrid/.npm/_logs/2021-06-29T15_39_01_050Z-debug.log
ERROR: "test-flow" exited with 1.
npm ERR! code 1
npm ERR! path $maplibre/maplibre-gl-js
npm ERR! command failed
npm ERR! command sh -c run-s lint lint-css lint-docs test-flow test-unit

[HarelM]

Yes, I've seen this too, I think it's related to this PR: #88
I'm still figuring this out too...

[astridx]

Yes, I've seen this too, I think it's related to this PR: #88
I'm still figuring this out too...

Why do you say that? PR: #88 is not merged. Do you mean that with the code from PR: #88 the tests run without errors?

I mean it has something to do with node versions. I just tested it again. With Node v10 the error does not occur.

[HarelM]

Hmm, interesting, I was under the impression this was related to the code and not node version...
Because starting debug server does seem to work (at least not fail with the above version).
In any case, it seems like you are figuring this out faster than me :-)
Let me know what you find out.

[astridx]

In any case, it seems like you are figuring this out faster than me :-)

No. I'm sure you are faster because you have more experience than me. But I think everyone should share it if he/she finds out something :)

I hadn't noticed that npm run start-debug was working. npm run start-test works not. So watch-query contains the problem for sure.

[HarelM]

Seems like the ci, which is running all the tests and finishes successfully is using node 10, so it might it...
This needs to be upgraded I believe, but it needs to be working first... :-)
If you manage to fix this please send a PR and I'll review.

[ka7eh]

Today I cloned the project and faced some issues when running npm i. Here are the solutions that worked for me, in case others run into similar issues:

With node 14, I needed to downgrade npm from v8 to v6 to get npm i work. npm 8 was throwing lots of build errors related to node-gyp.

I also needed to adjust my python alias for the build. I use pyenv to manage python versions, and by default, there's no python command on my system (I have python2 and python3 commands, and manage python per project). The build fails if it doesn't find python.

[astridx]

With node 14, I needed to downgrade npm from v8 to v6 to get npm i work. npm 8 was throwing lots of build errors related to node-gyp.

@ka7eh Please see #408 for npm v6

[birkskyum]

Here's a PR for supporting the latest LTS (16). #781 . That way we don't have to downgrade node and npm etc. anymore, and we get apple silicon support as well.