Custom Layer attached to a Source

[wazolab]

Hi !

I am facing an issue while trying to implement a type: 'custom' Layer.

Goal: Create a type: 'custom' Layer (implementing CustomLayerInterface where I could manipulate features and their rendering through render().

Issue: Not having any data while requesting querySourceFeatures() on the Source.

• Unless I add another type: 'symbol' Layer which ‘enables’ the Source and then makes it present while inside render().

I am aware of the Source enabling process: when at least one of its layers becomes visible in style sense (inside the layer's zoom range and with layout.visibility set to 'visible'), but I don't understand how to satisfy this with type: 'custom' `Layer ?

Reproduction link: https://codesandbox.io/p/sandbox/kgz6hn

Thank in advance for any help :)

[HarelM]

What data manipulation you would like to do? You might be better off using addProtocol?

[frodrigo]

The code on codesandbox, does not help?

The console.log show that there is no features available, unless the commented layer is uncommented.

[HarelM]

Oh, Sorry, I missed that, but in any case, custom layer can't satisfy the visibility part of query source features as far as I know. but you can dive into the code and see if you manage to understand it better than I do.

[frodrigo]

Do you think that by design or some kind of implementation issue?

Custom layers are supposed to access features from sources, or there are not designed for that?

We are trying to implement a plugin to render clusters as custom layer.

[HarelM]

Custom layers are more designed to interact with the gl context and less about using source cache and stuff like that.
But I don't see a problem with asking the user to create a layer of circles with a radius of 0 or non visible to allow this layer to query the source features. This is basically what I did here (minus the usage of the webgl part):
Using a geojson to cluster the points:
https://github.com/IsraelHikingMap/Site/blob/776478d6f20d4587fc721b9d042762629b35700b/IsraelHiking.Web/src/application/components/map/layers-view.component.html#L16-L22
Add a source and a transparent layer:
https://github.com/IsraelHikingMap/Site/blob/776478d6f20d4587fc721b9d042762629b35700b/IsraelHiking.Web/src/application/services/poi.service.ts#L126-L139
Getting the data from the tiles when the map moves:
https://github.com/IsraelHikingMap/Site/blob/776478d6f20d4587fc721b9d042762629b35700b/IsraelHiking.Web/src/application/services/poi.service.ts#L288-L302

[wazolab]

Thanks for your answer, we'll go with the transparent layer tweak :)