-
Notifications
You must be signed in to change notification settings - Fork 27
Description
I'm sorry in advance for (1) not following the issue template and (2) using incorrect language when referring to SSSOM concepts. I am new to this and still getting familiar with correct terminology etc.
We (well, specifically @a-chahin) are creating SSSOM-formatted tables to map terms in the MIMIC-IV database to common vocabularies. For example, the following pull request maps MIMIC-IV lab results to LOINC: MIT-LCP/mimic-code#1418
@matentzn kindly reviewed this work and gave helpful advice on steps towards SSSOM compliance. During review, the following question was raised. For background, see: MIT-LCP/mimic-code#1418 (comment).
Question
Our source list includes a lot of junk terms that just don't make sense to map to LOINC.
Despite the source terms being meaningless, it is important for us to maintain a complete list of them in the mapping file. The question is how best to do this.
In cases where no target term is found, @matentzn suggests that standard practice is to define the predicate_id (e.g skos:exactMatch
) and then add a sssom:NoTermFound
placeholder.
NoTermFound
is perhaps true in our case, but something like sssom:OutOfScope
would be more informative. This makes it clear that not only was no target found but that there is no desire to create a mapping.
We would appreciate your thoughts on this!