fix nested serialized array (related to export-import issue of widget roles & admin page's roles)

Author: contactjavas

helpers/class-array-helper.php

@@ -36,4 +36,32 @@ public function find_assoc_array_index_by_value( $array, $key, $value ) {
 
 		return false;
 	}
+
+	/**
+	 * Clean a serialized array from nested-serialized.
+	 *
+	 * The returned $value after unserialized should be an array.
+	 * If it's still a string, then we need to unserialize it.
+	 * This was related to roles issue on export / import.
+	 *
+	 * @param string $value The value to clean.
+	 * @param int    $depth The depth of the checking.
+	 *
+	 * @return array The unserialized array.
+	 */
+	public function clean_unserialize( $value, $depth = 2 ) {
+		for ( $i = 0; $i < $depth; $i++ ) {
+			if ( is_serialized( $value ) ) {
+				$value = unserialize( $value );
+
+				if ( ! is_serialized( $value ) ) {
+					break;
+				}
+			} else {
+				break;
+			}
+		}
+
+		return $value;
+	}
 }

modules/tool/inc/process-import.php

@@ -7,12 +7,15 @@
 
 defined( 'ABSPATH' ) || die( "Can't access directly" );
 
+use Udb\Helpers\Array_Helper;
+
 return function () {
 
-	$import_file = $_FILES['udb_import_file'];
-	$file_name   = basename( sanitize_file_name( wp_unslash( $import_file['name'] ) ) );
-	$explodes    = explode( '.', $file_name );
-	$ext         = end( $explodes );
+	$array_helper = new Array_Helper();
+	$import_file  = $_FILES['udb_import_file'];
+	$file_name    = basename( sanitize_file_name( wp_unslash( $import_file['name'] ) ) );
+	$explodes     = explode( '.', $file_name );
+	$ext          = end( $explodes );
 
 	// wp_check_filetype fails here, so let's check it manually.
 	if ( 'json' !== $ext ) {
@@ -119,19 +122,7 @@
 
 			foreach ( $meta as $meta_key => $meta_value ) {
 				if ( false !== stripos( $meta_key, '_roles' ) || false !== stripos( $meta_key, '_users' ) ) {
-					if ( is_serialized( $meta_value ) ) {
-						$unserialized_meta_value = unserialize( $meta_value );
-
-						/**
-						 * The value of $meta_value after serialized should be an array.
-						 * If it's still a string, then we need to unserialize it.
-						 *
-						 * This was related to widget roles issue on export / import.
-						 */
-						if ( is_string( $unserialized_meta_value ) ) {
-							$meta_value = $unserialized_meta_value;
-						}
-					}
+					$meta_value = $array_helper->clean_unserialize( $meta_value, 3 );
 				}
 
 				update_post_meta( $post_id, $meta_key, $meta_value );
@@ -168,6 +159,10 @@
 			}
 
 			foreach ( $meta as $meta_key => $meta_value ) {
+				if ( false !== stripos( $meta_key, '_roles' ) || false !== stripos( $meta_key, '_users' ) ) {
+					$meta_value = $array_helper->clean_unserialize( $meta_value, 3 );
+				}
+
 				update_post_meta( $post_id, $meta_key, $meta_value );
 			}
 		}