Skip to content

Commit 531da0d

Browse files
committed
#226: Fix reference for package private methods in the same package
1 parent be40513 commit 531da0d

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/main/java/org/mapstruct/intellij/codeinsight/references/MapstructMappingQualifiedByNameReference.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,10 +136,6 @@ private boolean methodIsAccessibleFrom(PsiMethod method, PsiClass containingClas
136136
return true;
137137
}
138138

139-
if ( method.hasModifierProperty( PsiModifier.PROTECTED ) ) {
140-
return methodClass.equals( containingClass );
141-
}
142-
143139
return haveSamePackage( containingClass, methodClass );
144140
}
145141

src/test/java/org/mapstruct/intellij/completion/MappingQualifiedByNameCompletionTestCase.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ private void assertAutoCompleteOfValidVisibilities() {
106106
"superClassModifierProtected",
107107
"superClassModifierPublic",
108108
"samePackageModifierPackagePrivate",
109+
"samePackageModifierProtected",
109110
"samePackageModifierPublic",
110111
"externalPackageModifierPublic"
111112
);
@@ -137,6 +138,11 @@ private void assertAutoCompleteOfValidVisibilities() {
137138
"String",
138139
" SamePackageMapper#samePackageModifierPackagePrivate(String)"
139140
),
141+
createMethod(
142+
"samePackageModifierProtected",
143+
"String",
144+
" SamePackageMapper#samePackageModifierProtected(String)"
145+
),
140146
createMethod(
141147
"samePackageModifierPublic",
142148
"String",

0 commit comments

Comments
 (0)