#236: Do not register problems when on mapping composition annotations

Author: thunderhook

src/main/java/org/mapstruct/intellij/inspection/MapstructReferenceInspection.java

@@ -5,14 +5,18 @@
  */
 package org.mapstruct.intellij.inspection;
 
+import java.util.Optional;
+
 import com.intellij.codeInspection.ProblemHighlightType;
 import com.intellij.codeInspection.ProblemsHolder;
 import com.intellij.openapi.util.TextRange;
 import com.intellij.psi.ContributedReferenceHost;
+import com.intellij.psi.PsiClass;
 import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiElementVisitor;
 import com.intellij.psi.PsiLanguageInjectionHost;
 import com.intellij.psi.PsiReference;
+import com.intellij.psi.util.PsiTreeUtil;
 import org.jetbrains.annotations.NotNull;
 import org.mapstruct.intellij.codeinsight.references.BaseReference;
 import org.mapstruct.intellij.codeinsight.references.BaseValueMappingReference;
@@ -64,7 +68,14 @@ private boolean shouldRegisterProblem(BaseReference reference) {
             if ( reference instanceof BaseValueMappingReference valueMappingReference ) {
                 return valueMappingReference.getEnumClass() != null;
             }
-            return true;
+
+            return !containingClassIsAnnotationType( reference.getElement() );
+        }
+
+        private boolean containingClassIsAnnotationType(PsiElement element) {
+            return Optional.ofNullable( PsiTreeUtil.getParentOfType( element, PsiClass.class ) )
+                .map( PsiClass::isAnnotationType )
+                .orElse( false );
         }
     }
 }

src/test/java/org/mapstruct/intellij/bugs/_236/DisableSourceAndTargetPropertyInspectionOnAnnotationsTest.java

@@ -0,0 +1,31 @@
+/*
+ * Copyright MapStruct Authors.
+ *
+ * Licensed under the Apache License version 2.0, available at https://www.apache.org/licenses/LICENSE-2.0
+ */
+package org.mapstruct.intellij.bugs._236;
+
+import org.jetbrains.annotations.NotNull;
+import org.mapstruct.intellij.inspection.BaseInspectionTest;
+import org.mapstruct.intellij.inspection.MapstructReferenceInspection;
+
+/**
+ * @author Oliver Erhart
+ */
+public class DisableSourceAndTargetPropertyInspectionOnAnnotationsTest extends BaseInspectionTest {
+
+    @Override
+    protected String getTestDataPath() {
+        return "testData/bugs/_236";
+    }
+
+    @NotNull
+    @Override
+    protected Class<MapstructReferenceInspection> getInspection() {
+        return MapstructReferenceInspection.class;
+    }
+
+    public void testDisableSourceAndTargetPropertyInspectionOnAnnotations() {
+        doTest();
+    }
+}

testData/bugs/_236/DisableSourceAndTargetPropertyInspectionOnAnnotations.java

@@ -0,0 +1,16 @@
+/*
+ * Copyright MapStruct Authors.
+ *
+ * Licensed under the Apache License version 2.0, available at https://www.apache.org/licenses/LICENSE-2.0
+ */
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+import org.mapstruct.Mapping;
+
+@Retention(RetentionPolicy.CLASS)
+@Mapping(target = "id", ignore = true)
+@Mapping(target = "creationDate", expression = "java(new java.util.Date())")
+@Mapping(target = "name", source = "groupName")
+@interface ToEntity { }