Skip to content

Commit c797758

Browse files
authored
Merge pull request #10 from mapstruct/issue8-remove-direct-dependency-on-spring
Closes #8.
2 parents f346334 + 4b5e479 commit c797758

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

extensions/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
dependencies {
22
implementation project(":annotations")
33
implementation 'org.mapstruct:mapstruct:1.4.0-SNAPSHOT'
4-
implementation 'org.springframework:spring-core:5.0.0.RELEASE'
54
implementation 'com.squareup:javapoet:1.12.1'
65
implementation 'org.apache.commons:commons-lang3:3.10'
76

87
testImplementation 'org.assertj:assertj-core:3.15.0'
98
testImplementation 'commons-io:commons-io:2.6'
109
testImplementation 'com.google.guava:guava:28.2-jre'
1110
testImplementation 'org.mockito:mockito-junit-jupiter:3.3.3'
11+
testImplementation 'org.springframework:spring-core:5.0.0.RELEASE'
1212
}

extensions/src/main/java/org/mapstruct/extensions/spring/converter/ConversionServiceAdapterGenerator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import java.time.Clock;
1111
import java.time.ZonedDateTime;
1212
import java.time.format.DateTimeFormatter;
13-
import org.springframework.core.convert.ConversionService;
1413

1514
public class ConversionServiceAdapterGenerator {
1615
private final Clock clock;
@@ -75,7 +74,8 @@ private static ParameterSpec buildSourceParameterSpec(final TypeName sourceClass
7574
}
7675

7776
private static FieldSpec buildInjectedConversionServiceFieldSpec() {
78-
return FieldSpec.builder(ConversionService.class, "conversionService", PRIVATE)
77+
return FieldSpec.builder(ClassName.get("org.springframework.core.convert","ConversionService"),
78+
"conversionService", PRIVATE)
7979
.addAnnotation(ClassName.get("org.springframework.beans.factory.annotation", "Autowired"))
8080
.build();
8181
}

extensions/src/main/java/org/mapstruct/extensions/spring/converter/ConverterMapperProcessor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import org.apache.commons.lang3.StringUtils;
2828
import org.apache.commons.lang3.tuple.MutablePair;
2929
import org.apache.commons.lang3.tuple.Pair;
30-
import org.springframework.core.convert.converter.Converter;
3130
import org.mapstruct.extensions.spring.SpringMapperConfig;
3231

3332
@SupportedAnnotationTypes({
@@ -38,6 +37,7 @@ public class ConverterMapperProcessor extends AbstractProcessor {
3837
protected static final String MAPPER = "org.mapstruct.Mapper";
3938
protected static final String SPRING_MAPPER_CONFIG =
4039
"org.mapstruct.extensions.spring.SpringMapperConfig";
40+
protected static final String SPRING_CONVERTER_FULL_NAME = "org.springframework.core.convert.converter.Converter";
4141

4242
private final ConversionServiceAdapterGenerator adapterGenerator;
4343

@@ -170,7 +170,7 @@ private Optional<? extends TypeMirror> getConverterSupertype(final Element mappe
170170
final Types typeUtils = processingEnv.getTypeUtils();
171171
return typeUtils.directSupertypes(mapper.asType()).stream()
172172
.filter(
173-
supertype -> typeUtils.erasure(supertype).toString().equals(Converter.class.getName()))
173+
supertype -> typeUtils.erasure(supertype).toString().equals(SPRING_CONVERTER_FULL_NAME))
174174
.findFirst();
175175
}
176176

0 commit comments

Comments
 (0)