Merge pull request #80 from mapswipe/feature/validation-team-on-project

Add validation check for team on project

Author: tnagorra

apps/project/serializers.py

@@ -6,6 +6,7 @@
 from rest_framework import serializers
 
 from apps.common.serializers import ArchivableResourceSerializer, UserResourceSerializer
+from apps.contributor.models import ContributorTeam
 from apps.project.firebase import push_organization_to_firebase
 from apps.tutorial.models import Tutorial
 from project_types.store import get_project_property
@@ -61,6 +62,13 @@ class Meta:  # type: ignore[reportIncompatibleVariableOverride]
             "team",
         )
 
+    def validate_team(self, team: ContributorTeam | None) -> ContributorTeam | None:
+        if team and team.is_archived:
+            raise serializers.ValidationError(
+                gettext("Cannot use archived team on a project."),
+            )
+        return team
+
 
 # NOTE: Make sure this matches with the strawberry Input ./graphql/inputs.py
 class ProjectUpdateSerializer(UserResourceSerializer[Project]):
@@ -90,6 +98,13 @@ class Meta:  # type: ignore[reportIncompatibleVariableOverride]
             "team",
         )
 
+    def validate_team(self, team: ContributorTeam | None) -> ContributorTeam | None:
+        if team and team.is_archived:
+            raise serializers.ValidationError(
+                gettext("Cannot use archived team on a project."),
+            )
+        return team
+
     def validate_status(self, new_status: Project.Status | int) -> Project.Status:
         assert self.instance is not None, "Project does not exist."
 
@@ -246,6 +261,13 @@ class Meta:  # type: ignore[reportIncompatibleVariableOverride]
             "team",
         )
 
+    def validate_team(self, team: ContributorTeam | None) -> ContributorTeam | None:
+        if team and team.is_archived:
+            raise serializers.ValidationError(
+                gettext("Cannot use archived team on a project."),
+            )
+        return team
+
     def validate_status(self, new_status: Project.Status | int):
         assert self.instance is not None, "Project does not exist."
 

apps/project/tests/mutation_test.py

@@ -6,6 +6,7 @@
 from django.core.files.temp import NamedTemporaryFile
 from ulid import ULID
 
+from apps.contributor.factories import ContributorTeamFactory
 from apps.project.factories import OrganizationFactory, ProjectFactory
 from apps.project.models import (
     Project,
@@ -496,6 +497,16 @@ def test_project_create(self):
         response = content["data"]["createProject"]
         assert response["errors"] is not None, content
 
+        # Creating project with archived team
+        # Fails as team is archived
+        archived_team = ContributorTeamFactory.create(
+            **self.user_resource_kwargs,
+            is_archived=True,
+        )
+        project_data["team"] = archived_team.pk
+        response = content["data"]["createProject"]
+        assert response["errors"] is not None, content
+
         latest_project = Project.objects.get(pk=resp_data["result"]["id"])
         assert latest_project.created_by_id == self.user.pk
         assert latest_project.modified_by_id == self.user.pk
@@ -613,6 +624,16 @@ def test_project_update(self, mock_requests):
             ),
         ), content
 
+        # Updating project with archived team
+        # fails as team is archived
+        archived_team = ContributorTeamFactory.create(
+            **self.user_resource_kwargs,
+            is_archived=True,
+        )
+        project_data["team"] = archived_team.pk
+        content = self._update_project_mutation(str(latest_project.pk), project_data)
+        assert content["data"]["updateProject"]["errors"] is not None, content
+
         # Updating project with archived Organization
         # Fails as organization is archived
         archived_organization = OrganizationFactory.create(
@@ -819,6 +840,16 @@ def test_project_update(self, mock_requests):
         assert content["data"]["updateProcessedProject"]["errors"] is None, content
         assert content["data"]["updateProcessedProject"]["result"]["status"] == self.genum(ProjectStatusEnum.ARCHIVED)
 
+        # Updating project with archived team
+        # fails as team is archived
+        archived_team = ContributorTeamFactory.create(
+            **self.user_resource_kwargs,
+            is_archived=True,
+        )
+        project_data["team"] = archived_team.pk
+        content = self._update_processed_project_mutation(str(latest_project.pk), project_data)
+        assert content["data"]["updateProcessedProject"]["errors"] is not None, content
+
 
 class TestProjectTypeMutation(TestCase):
     @typing.override