fix(file): add is_file_empty to check for file with empty content

- add typing for file content on asset serializers
- update firebase submodule to develop

Author: tnagorra

apps/common/utils.py

@@ -4,6 +4,7 @@
 from django.db.models.fields import files
 
 from main.config import Config
+from utils.common import is_file_empty
 
 
 @typing.overload
@@ -15,7 +16,7 @@ def get_absolute_uri(file: files.FieldFile) -> str: ...
 
 
 def get_absolute_uri(file: files.FieldFile | None) -> str | None:
-    if not file:
+    if is_file_empty(file):
         return None
     if isinstance(file.storage, FileSystemStorage):
         # FIXME(tnagorra): We should change the url method in storage

apps/project/serializers.py

@@ -22,6 +22,9 @@
 from .models import Organization, Project, ProjectAsset, ProjectAssetInputTypeEnum, ProjectTypeEnum
 from .tasks import process_project_task, push_project_to_firebase
 
+if typing.TYPE_CHECKING:
+    from django.core.files.base import ContentFile
+
 VALID_PROJECT_STATUS_TRANSITIONS = set(
     [
         (Project.Status.DRAFT, Project.Status.MARKED_AS_READY),
@@ -371,7 +374,7 @@ def _validate_aoi_geometry(
         attrs: dict[str, typing.Any],
         mimetype: AssetMimetypeEnum | None,
     ) -> None:
-        file = attrs.get("file")
+        file: ContentFile[bytes] | None = attrs.get("file")
         if not file:
             raise ValidationError("Required field file is not provided.")
 
@@ -421,7 +424,7 @@ def _validate_cover_image(
         attrs: dict[str, typing.Any],
         mimetype: AssetMimetypeEnum | None,
     ) -> None:
-        file = attrs.get("file")
+        file: ContentFile[bytes] | None = attrs.get("file")
         if not file:
             raise ValidationError("Required field file is not provided.")
 
@@ -437,7 +440,7 @@ def _validate_object_image(
         attrs: dict[str, typing.Any],
         mimetype: AssetMimetypeEnum | None,
     ) -> None:
-        file = attrs.get("file")
+        file: ContentFile[bytes] | None = attrs.get("file")
         if not file:
             return
 

apps/tutorial/serializers.py

@@ -25,6 +25,9 @@
 )
 from .tasks import push_tutorial_to_firebase
 
+if typing.TYPE_CHECKING:
+    from django.core.files.base import ContentFile
+
 
 class TutorialTaskSerializerContextType(DrfContextType):
     scenario: TutorialScenarioPage
@@ -461,7 +464,7 @@ def _validate_information_block_image(
         attrs: dict[str, typing.Any],
         mimetype: AssetMimetypeEnum | None,
     ) -> None:
-        file = attrs.get("file")
+        file: ContentFile[bytes] | None = attrs.get("file")
         if not file:
             raise ValidationError("Required field file is not provided.")
 

firebase

@@ -11,11 +11,21 @@
 from django.core.files.base import ContentFile
 from django.core.serializers.json import DjangoJSONEncoder
 from django.db import models
+from django.db.models.fields import files
 from django.utils.translation import gettext
 from geojson_pydantic import FeatureCollection
 from ulid import ULID
 
 
+# NOTE: We are treating file with empty name as None as well
+def is_file_empty(file: files.FieldFile | None) -> typing.TypeIs[None]:
+    if not file:
+        return True
+    if not file.name:  # noqa: SIM103
+        return True
+    return False
+
+
 def validate_imagery_url(url: str, *, support_quad_key: bool | None = True):
     """Check if imagery url contains xyz or quad key placeholders."""
     if all([substring in url for substring in ["{x}", "{y}", "{z}"]]) and not any(