Skip to content

Commit e553d3c

Browse files
committed
fixup! fix(mapping): add unsynced user to the firebase user update list
1 parent ef140e4 commit e553d3c

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

apps/contributor/firebase/pull.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,13 @@ def pull_users_from_firebase():
3838

3939
users_to_pull = list[ContributorUser]()
4040
for key, valid_user in valid_users:
41+
username = valid_user.username
42+
# XXX: For OSM users, firebase doesn't include username
43+
if username in ["", None, firebase_models.UNDEFINED]:
44+
username = key
4145
user = ContributorUser(
4246
firebase_id=key,
43-
username=valid_user.username or key, # XXX: For OSM users, firebase doesn't include username
47+
username=username,
4448
created_at=valid_user.created,
4549
modified_at=valid_user.created,
4650
# NOTE: Setting firebase_last_pushed so that we can send updates to firebase.

0 commit comments

Comments
 (0)