Skip to content

Commit 8b0d683

Browse files
authored
Merge pull request #46 from mapswipe/fix/osm-user-type
fix(user): change username to optional field
2 parents 93b3ffc + f1bb50a commit 8b0d683

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

functions/definition/user.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ FbUserReadonlyType:
2121
optional: true
2222
username:
2323
type: string
24+
optional: true # XXX: For OSM users this is not provided
2425
usernameKey:
2526
# NOTE: web does not set usernameKey
2627
type: string

functions/generated/pyfirebase/pyfirebase_mapswipe/models.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1116,7 +1116,7 @@ class FbUserReadonlyType(TypesyncModel):
11161116
str | TypesyncUndefined | None,
11171117
pydantic.Field(deprecated=True),
11181118
] = UNDEFINED
1119-
username: str
1119+
username: str | TypesyncUndefined | None = UNDEFINED
11201120
usernameKey: str | TypesyncUndefined | None = UNDEFINED
11211121
accessibility: bool | TypesyncUndefined | None = UNDEFINED
11221122
userGroups: dict[str, typing.Any] | TypesyncUndefined | None = UNDEFINED
@@ -1137,6 +1137,8 @@ def __setattr__(self, name: str, value: typing.Any) -> None:
11371137
raise ValueError("'userName' field cannot be set to None")
11381138
if name == "userNameKey" and value is None:
11391139
raise ValueError("'userNameKey' field cannot be set to None")
1140+
if name == "username" and value is None:
1141+
raise ValueError("'username' field cannot be set to None")
11401142
if name == "usernameKey" and value is None:
11411143
raise ValueError("'usernameKey' field cannot be set to None")
11421144
if name == "accessibility" and value is None:

0 commit comments

Comments
 (0)