Skip to content

Commit c24b59b

Browse files
committed
feat(street): error handling for panoramax image provider
1 parent 9ad395c commit c24b59b

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

src/components/StreetProject.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ export default defineComponent({
9595
saveResults: 'saveResults',
9696
showSnackbar: 'showSnackbar',
9797
},
98+
emits: ['created'],
9899
computed: {
99100
mission() {
100101
const message = isDefined(this.project.projectInstruction)
@@ -133,7 +134,6 @@ export default defineComponent({
133134
this.errorLoading = true
134135
this.addResult(null)
135136
this.showSnackbar(this.$t('streetProject.couldNotLoadImage'), 'error', 1200)
136-
this.forward()
137137
},
138138
isAnswered() {
139139
const result = this.results[this.taskId]
@@ -177,14 +177,14 @@ export default defineComponent({
177177
:taskId="taskId"
178178
:endpoint="project.tileServer?.url"
179179
@dataloading="(e) => (isLoading = e)"
180-
@imageError="handleImageError(taskId)"
180+
@imageError="handleImageError()"
181181
style="position: relative; height: calc(100vh - 390px)"
182182
/>
183183
<street-project-task
184184
v-else
185185
:taskId="taskId"
186186
@dataloading="(e) => (isLoading = e.loading)"
187-
@imageError="handleImageError(taskId)"
187+
@imageError="handleImageError()"
188188
style="position: relative; height: calc(100vh - 390px)"
189189
/>
190190
<option-buttons

src/components/StreetProjectTask.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ export default defineComponent({
1414
containerId: {
1515
type: String,
1616
default: 'mapillary',
17-
required: true,
1817
},
1918
taskId: {
2019
type: String,

src/components/StreetProjectTaskPanoramax.vue

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ export default defineComponent({
88
containerId: {
99
type: String,
1010
default: 'panoramax',
11-
required: true,
1211
},
1312
taskId: { type: String, required: true },
1413
endpoint: { type: String, default: 'https://api.panoramax.xyz/api' },
@@ -35,12 +34,9 @@ export default defineComponent({
3534
this.viewer.addEventListener('psv:picture-loaded', () => {
3635
this.$emit('dataloading', false)
3736
})
38-
/* TODO
3937
this.viewer.addEventListener('broken', () => {
4038
this.$emit('imageError', this.taskId)
41-
console.log("broken")
4239
})
43-
*/
4440
},
4541
moveViewer(pictureId) {
4642
this.viewer.select(undefined, pictureId, true)

0 commit comments

Comments
 (0)